vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-14 06:20:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(agents): demote embedded run stage logs to trace

Browse Source
This commit is contained in:
Peter Steinberger
2026-04-29 14:51:20 +01:00
parent 6bbacd14a3
commit 66cdbccc8a
5 changed files with 42 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/agents/pi-embedded-runner/run.ts
View File

@@ -93,7 +93,7 @@ import { handleAssistantFailover } from "./run/assistant-failover.js";
import {
createEmbeddedRunStageTracker,
formatEmbeddedRunStageSummary,
shouldEmitEmbeddedRunStageSummary,
shouldWarnEmbeddedRunStageSummary,
} from "./run/attempt-stage-timing.js";
import { forgetPromptBuildDrainCacheForRun } from "./run/attempt.prompt-helpers.js";
import { createEmbeddedRunAuthController } from "./run/auth-controller.js";
@@ -333,14 +333,18 @@ export async function runEmbeddedPiAgent(
let startupStagesEmitted = false;
const emitStartupStageSummary = (phase: string) => {
const summary = startupStages.snapshot();
const shouldWarn = shouldWarnEmbeddedRunStageSummary(summary);
if (!shouldWarn && !log.isEnabled("trace")) {
return;
}
const message = formatEmbeddedRunStageSummary(
`embedded run startup stages: runId=${params.runId} sessionId=${params.sessionId} phase=${phase}`,
`[trace:embedded-run] startup stages: runId=${params.runId} sessionId=${params.sessionId} phase=${phase}`,
summary,
);
if (shouldEmitEmbeddedRunStageSummary(summary)) {
if (shouldWarn) {
log.warn(message);
} else if (log.isEnabled("debug")) {
log.debug(message);
} else {
log.trace(message);
}
};
params.onExecutionStarted?.();

36
src/agents/pi-embedded-runner/run/attempt-stage-timing.test.ts
View File

@@ -2,7 +2,7 @@ import { describe, expect, it } from "vitest";
import {
createEmbeddedRunStageTracker,
formatEmbeddedRunStageSummary,
shouldEmitEmbeddedRunStageSummary,
shouldWarnEmbeddedRunStageSummary,
} from "./attempt-stage-timing.js";
describe("embedded run stage timing", () => {
@@ -25,18 +25,25 @@ describe("embedded run stage timing", () => {
});
});
it("emits only slow stage summaries", () => {
it("warns only for very slow stage summaries by default", () => {
expect(
shouldEmitEmbeddedRunStageSummary(
{
totalMs: 1_999,
stages: [{ name: "auth", durationMs: 999, elapsedMs: 999 }],
},
{ totalThresholdMs: 2_000, stageThresholdMs: 1_000 },
),
shouldWarnEmbeddedRunStageSummary({
totalMs: 9_999,
stages: [{ name: "auth", durationMs: 4_999, elapsedMs: 4_999 }],
}),
).toBe(false);
expect(shouldWarnEmbeddedRunStageSummary({ totalMs: 10_000, stages: [] })).toBe(true);
expect(
shouldEmitEmbeddedRunStageSummary(
shouldWarnEmbeddedRunStageSummary({
totalMs: 10,
stages: [{ name: "auth", durationMs: 5_000, elapsedMs: 5_000 }],
}),
).toBe(true);
});
it("supports custom warning thresholds", () => {
expect(
shouldWarnEmbeddedRunStageSummary(
{
totalMs: 2_000,
stages: [{ name: "auth", durationMs: 10, elapsedMs: 10 }],
@@ -44,15 +51,6 @@ describe("embedded run stage timing", () => {
{ totalThresholdMs: 2_000, stageThresholdMs: 1_000 },
),
).toBe(true);
expect(
shouldEmitEmbeddedRunStageSummary(
{
totalMs: 10,
stages: [{ name: "auth", durationMs: 1_000, elapsedMs: 1_000 }],
},
{ totalThresholdMs: 2_000, stageThresholdMs: 1_000 },
),
).toBe(true);
});
it("formats summaries compactly for logs", () => {

9
src/agents/pi-embedded-runner/run/attempt-stage-timing.ts
View File

@@ -14,6 +14,9 @@ export type EmbeddedRunStageTracker = {
snapshot: () => EmbeddedRunStageSummary;
};
export const EMBEDDED_RUN_STAGE_WARN_TOTAL_MS = 10_000;
export const EMBEDDED_RUN_STAGE_WARN_STAGE_MS = 5_000;
export function createEmbeddedRunStageTracker(options?: {
now?: () => number;
}): EmbeddedRunStageTracker {
@@ -43,15 +46,15 @@ export function createEmbeddedRunStageTracker(options?: {
};
}
export function shouldEmitEmbeddedRunStageSummary(
export function shouldWarnEmbeddedRunStageSummary(
summary: EmbeddedRunStageSummary,
options?: {
totalThresholdMs?: number;
stageThresholdMs?: number;
},
): boolean {
const totalThresholdMs = options?.totalThresholdMs ?? 2_000;
const stageThresholdMs = options?.stageThresholdMs ?? 1_000;
const totalThresholdMs = options?.totalThresholdMs ?? EMBEDDED_RUN_STAGE_WARN_TOTAL_MS;
const stageThresholdMs = options?.stageThresholdMs ?? EMBEDDED_RUN_STAGE_WARN_STAGE_MS;
return (
summary.totalMs >= totalThresholdMs ||
summary.stages.some((stage) => stage.durationMs >= stageThresholdMs)

14
src/agents/pi-embedded-runner/run/attempt.ts
View File

@@ -245,7 +245,7 @@ import { configureEmbeddedAttemptHttpRuntime } from "./attempt-http-runtime.js";
import {
createEmbeddedRunStageTracker,
formatEmbeddedRunStageSummary,
shouldEmitEmbeddedRunStageSummary,
shouldWarnEmbeddedRunStageSummary,
} from "./attempt-stage-timing.js";
import {
assembleAttemptContextEngine,
@@ -597,14 +597,18 @@ export async function runEmbeddedAttempt(
const prepStages = createEmbeddedRunStageTracker();
const emitPrepStageSummary = (phase: string) => {
const summary = prepStages.snapshot();
const shouldWarn = shouldWarnEmbeddedRunStageSummary(summary);
if (!shouldWarn && !log.isEnabled("trace")) {
return;
}
const message = formatEmbeddedRunStageSummary(
`embedded run prep stages: runId=${params.runId} sessionId=${params.sessionId} phase=${phase}`,
`[trace:embedded-run] prep stages: runId=${params.runId} sessionId=${params.sessionId} phase=${phase}`,
summary,
);
if (shouldEmitEmbeddedRunStageSummary(summary)) {
if (shouldWarn) {
log.warn(message);
} else if (log.isEnabled("debug")) {
log.debug(message);
} else {
log.trace(message);
}
};