From 6a5ecb955c1c5973606cc8045a39bbd35b151803 Mon Sep 17 00:00:00 2001
From: Vincent Koc <vincentkoc@ieee.org>
Date: Sun, 26 Apr 2026 18:19:05 -0700
Subject: [PATCH] refactor(plugins): drop provider discovery alias

---
 src/plugins/provider-discovery.test.ts |  5 +++++
 src/plugins/provider-discovery.ts      | 12 ------------
 2 files changed, 5 insertions(+), 12 deletions(-)

diff --git a/src/plugins/provider-discovery.test.ts b/src/plugins/provider-discovery.test.ts
index 65e4bddbf22..23aaf1f9201 100644
--- a/src/plugins/provider-discovery.test.ts
+++ b/src/plugins/provider-discovery.test.ts
@@ -10,6 +10,7 @@ import {
   runProviderCatalog,
   runProviderStaticCatalog,
 } from "./provider-discovery.js";
+import * as providerDiscoveryModule from "./provider-discovery.js";
 import { cleanupTrackedTempDirs, makeTrackedTempDir } from "./test-helpers/fs-fixtures.js";
 import type { ProviderCatalogResult, ProviderDiscoveryOrder, ProviderPlugin } from "./types.js";
 
@@ -179,6 +180,10 @@ describe("resolveInstalledPluginProviderContributionIds", () => {
     }
   });
 
+  it("does not keep exporting the ambiguous runtime-discovery alias", () => {
+    expect(Object.keys(providerDiscoveryModule)).not.toContain("resolvePluginDiscoveryProviders");
+  });
+
   it("reads provider ids from the installed plugin index without importing runtime entries", () => {
     const candidate = createProviderContributionCandidate({
       pluginId: "demo",
diff --git a/src/plugins/provider-discovery.ts b/src/plugins/provider-discovery.ts
index 5168ed924cc..48f00710264 100644
--- a/src/plugins/provider-discovery.ts
+++ b/src/plugins/provider-discovery.ts
@@ -79,18 +79,6 @@ export async function resolveRuntimePluginDiscoveryProviders(
     .filter((provider) => resolveProviderCatalogOrderHook(provider));
 }
 
-/**
- * @deprecated Runtime-backed provider discovery must be explicit at call sites.
- * Use `resolveRuntimePluginDiscoveryProviders(...)` for paths that intentionally
- * import provider plugin runtime, or `resolveInstalledPluginProviderContributionIds(...)`
- * for cold installed-index reads.
- */
-export async function resolvePluginDiscoveryProviders(
-  params: ResolveRuntimePluginDiscoveryProvidersParams,
-): Promise<ProviderPlugin[]> {
-  return resolveRuntimePluginDiscoveryProviders(params);
-}
-
 export function groupPluginDiscoveryProvidersByOrder(
   providers: ProviderPlugin[],
 ): Record<ProviderDiscoveryOrder, ProviderPlugin[]> {