From 6f5b7120b8cf15ec7f88928453842fb63d521f8f Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Tue, 21 Apr 2026 04:31:22 +0100 Subject: [PATCH] fix: trim windows dev update preflight --- src/infra/update-runner.test.ts | 1 + src/infra/update-runner.ts | 28 +++++++++++++++++----------- 2 files changed, 18 insertions(+), 11 deletions(-) diff --git a/src/infra/update-runner.test.ts b/src/infra/update-runner.test.ts index 27548f7de86..769051dec31 100644 --- a/src/infra/update-runner.test.ts +++ b/src/infra/update-runner.test.ts @@ -701,6 +701,7 @@ describe("runGatewayUpdate", () => { ); expect(result.steps.map((step) => step.name)).toContain("deps install (ignore scripts)"); expect(calls).toContain("pnpm install --ignore-scripts"); + expect(calls).not.toContain("pnpm lint"); } finally { platformSpy.mockRestore(); } diff --git a/src/infra/update-runner.ts b/src/infra/update-runner.ts index 96d193d53fc..1c1366588b2 100644 --- a/src/infra/update-runner.ts +++ b/src/infra/update-runner.ts @@ -503,6 +503,10 @@ function mergeCommandEnvironments( }; } +function shouldRunDevPreflightLint(): boolean { + return process.platform !== "win32"; +} + export async function runGatewayUpdate(opts: UpdateRunnerOptions = {}): Promise { const startedAt = Date.now(); const defaultCommandEnv = await createGlobalInstallEnv(); @@ -885,17 +889,19 @@ export async function runGatewayUpdate(opts: UpdateRunnerOptions = {}): Promise< continue; } - const lintStep = await runStep( - step( - `preflight lint (${shortSha})`, - managerScriptArgs(manager.manager, "lint"), - worktreeDir, - manager.env, - ), - ); - steps.push(lintStep); - if (lintStep.exitCode !== 0) { - continue; + if (shouldRunDevPreflightLint()) { + const lintStep = await runStep( + step( + `preflight lint (${shortSha})`, + managerScriptArgs(manager.manager, "lint"), + worktreeDir, + manager.env, + ), + ); + steps.push(lintStep); + if (lintStep.exitCode !== 0) { + continue; + } } selectedSha = sha;