From 78ff2519e01b760639a4b609d97a985d07c756bf Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Tue, 7 Apr 2026 11:07:07 +0800 Subject: [PATCH] Tests: drop duplicate cron text failure cases --- ...p-recipient-besteffortdeliver-true.test.ts | 39 ------------------- 1 file changed, 39 deletions(-) diff --git a/src/cron/isolated-agent.skips-delivery-without-whatsapp-recipient-besteffortdeliver-true.test.ts b/src/cron/isolated-agent.skips-delivery-without-whatsapp-recipient-besteffortdeliver-true.test.ts index f1e19541b56..2df1fe82f17 100644 --- a/src/cron/isolated-agent.skips-delivery-without-whatsapp-recipient-besteffortdeliver-true.test.ts +++ b/src/cron/isolated-agent.skips-delivery-without-whatsapp-recipient-besteffortdeliver-true.test.ts @@ -164,30 +164,6 @@ async function withTelegramTextDelivery( }, fixtureParams); } -async function expectTelegramTextDeliveryFailure(params: { - bestEffort: boolean; - expectedStatus: "ok" | "error"; - expectedErrorFragment?: string; -}) { - await withTelegramTextDelivery( - { bestEffort: params.bestEffort }, - async ({ deps, res }) => { - expectFailedTelegramDeliveryResult({ - res, - deps, - expectedStatus: params.expectedStatus, - expectedErrorFragment: params.expectedErrorFragment, - expectDeliveryAttempted: true, - }); - }, - { - deps: { - sendMessageTelegram: vi.fn().mockRejectedValue(new Error("boom")), - }, - }, - ); -} - async function runSignalDeliveryResult(bestEffort: boolean) { let outcome: | { @@ -231,13 +207,6 @@ describe("runCronIsolatedAgentTurn", () => { setupIsolatedAgentTurnMocks({ fast: true }); }); - it("reports not-delivered when text direct delivery fails and best-effort is enabled", async () => { - await expectTelegramTextDeliveryFailure({ - bestEffort: true, - expectedStatus: "ok", - }); - }); - it("delivers text directly when best-effort is disabled", async () => { const { res, deps } = await runTelegramDeliveryResult(false); expectSuccessfulTelegramTextDelivery({ res, deps }); @@ -247,14 +216,6 @@ describe("runCronIsolatedAgentTurn", () => { }); }); - it("returns error when text direct delivery fails and best-effort is disabled", async () => { - await expectTelegramTextDeliveryFailure({ - bestEffort: false, - expectedStatus: "error", - expectedErrorFragment: "boom", - }); - }); - it("retries transient text direct delivery failures before succeeding", async () => { const previousFastMode = process.env.OPENCLAW_TEST_FAST; process.env.OPENCLAW_TEST_FAST = "1";