refactor: finish plugin-owned channel runtime seams

2026-04-29 01:52:04 +00:00 · 2026-03-16 00:24:40 -07:00
parent e90c1d9add
commit 7964563299
29 changed files with 488 additions and 296 deletions
--- a/src/plugins/runtime/runtime-channel.ts
+++ b/src/plugins/runtime/runtime-channel.ts
@@ -1,59 +1,4 @@
-import { auditDiscordChannelPermissions } from "../../../extensions/discord/src/audit.js";
-import {
-  listDiscordDirectoryGroupsLive,
-  listDiscordDirectoryPeersLive,
-} from "../../../extensions/discord/src/directory-live.js";
-import { monitorDiscordProvider } from "../../../extensions/discord/src/monitor.js";
-import { probeDiscord } from "../../../extensions/discord/src/probe.js";
-import { resolveDiscordChannelAllowlist } from "../../../extensions/discord/src/resolve-channels.js";
-import { resolveDiscordUserAllowlist } from "../../../extensions/discord/src/resolve-users.js";
-import {
-  createThreadDiscord,
-  deleteMessageDiscord,
-  editChannelDiscord,
-  editMessageDiscord,
-  pinMessageDiscord,
-  sendDiscordComponentMessage,
-  sendMessageDiscord,
-  sendPollDiscord,
-  sendTypingDiscord,
-  unpinMessageDiscord,
-} from "../../../extensions/discord/src/send.js";
-import { monitorIMessageProvider } from "../../../extensions/imessage/src/monitor.js";
-import { probeIMessage } from "../../../extensions/imessage/src/probe.js";
-import { sendMessageIMessage } from "../../../extensions/imessage/src/send.js";
-import { monitorSignalProvider } from "../../../extensions/signal/src/index.js";
-import { probeSignal } from "../../../extensions/signal/src/probe.js";
-import { sendMessageSignal } from "../../../extensions/signal/src/send.js";
-import {
-  listSlackDirectoryGroupsLive,
-  listSlackDirectoryPeersLive,
-} from "../../../extensions/slack/src/directory-live.js";
-import { monitorSlackProvider } from "../../../extensions/slack/src/index.js";
-import { probeSlack } from "../../../extensions/slack/src/probe.js";
-import { resolveSlackChannelAllowlist } from "../../../extensions/slack/src/resolve-channels.js";
-import { resolveSlackUserAllowlist } from "../../../extensions/slack/src/resolve-users.js";
-import { sendMessageSlack } from "../../../extensions/slack/src/send.js";
-import {
-  auditTelegramGroupMembership,
-  collectTelegramUnmentionedGroupIds,
-} from "../../../extensions/telegram/src/audit.js";
-import { monitorTelegramProvider } from "../../../extensions/telegram/src/monitor.js";
-import { probeTelegram } from "../../../extensions/telegram/src/probe.js";
-import {
-  deleteMessageTelegram,
-  editMessageReplyMarkupTelegram,
-  editMessageTelegram,
-  pinMessageTelegram,
-  renameForumTopicTelegram,
-  sendMessageTelegram,
-  sendPollTelegram,
-  sendTypingTelegram,
-  unpinMessageTelegram,
-} from "../../../extensions/telegram/src/send.js";
-import { resolveTelegramToken } from "../../../extensions/telegram/src/token.js";
 import { resolveEffectiveMessagesConfig, resolveHumanDelayConfig } from "../../agents/identity.js";
-import { handleSlackAction } from "../../agents/tools/slack-actions.js";
 import {
  chunkByNewline,
  chunkMarkdownText,
@@ -90,9 +35,6 @@ import { dispatchReplyWithBufferedBlockDispatcher } from "../../auto-reply/reply
 import { createReplyDispatcherWithTyping } from "../../auto-reply/reply/reply-dispatcher.js";
 import { removeAckReactionAfterReply, shouldAckReaction } from "../../channels/ack-reactions.js";
 import { resolveCommandAuthorizedFromAuthorizers } from "../../channels/command-gating.js";
-import { discordMessageActions } from "../../channels/plugins/actions/discord.js";
-import { signalMessageActions } from "../../channels/plugins/actions/signal.js";
-import { telegramMessageActions } from "../../channels/plugins/actions/telegram.js";
 import { recordInboundSession } from "../../channels/session.js";
 import {
  resolveChannelGroupPolicy,
@@ -134,8 +76,11 @@ import {
  upsertChannelPairingRequest,
 } from "../../pairing/pairing-store.js";
 import { buildAgentSessionKey, resolveAgentRoute } from "../../routing/resolve-route.js";
-import { createDiscordTypingLease } from "./runtime-discord-typing.js";
-import { createTelegramTypingLease } from "./runtime-telegram-typing.js";
+import { createRuntimeDiscord } from "./runtime-discord.js";
+import { createRuntimeIMessage } from "./runtime-imessage.js";
+import { createRuntimeSignal } from "./runtime-signal.js";
+import { createRuntimeSlack } from "./runtime-slack.js";
+import { createRuntimeTelegram } from "./runtime-telegram.js";
 import { createRuntimeWhatsApp } from "./runtime-whatsapp.js";
 import type { PluginRuntime } from "./types.js";

@@ -222,100 +167,11 @@ export function createRuntimeChannel(): PluginRuntime["channel"] {
      shouldComputeCommandAuthorized,
      shouldHandleTextCommands,
    },
-    discord: {
-      messageActions: discordMessageActions,
-      auditChannelPermissions: auditDiscordChannelPermissions,
-      listDirectoryGroupsLive: listDiscordDirectoryGroupsLive,
-      listDirectoryPeersLive: listDiscordDirectoryPeersLive,
-      probeDiscord,
-      resolveChannelAllowlist: resolveDiscordChannelAllowlist,
-      resolveUserAllowlist: resolveDiscordUserAllowlist,
-      sendComponentMessage: sendDiscordComponentMessage,
-      sendMessageDiscord,
-      sendPollDiscord,
-      monitorDiscordProvider,
-      typing: {
-        pulse: sendTypingDiscord,
-        start: async ({ channelId, accountId, cfg, intervalMs }) =>
-          await createDiscordTypingLease({
-            channelId,
-            accountId,
-            cfg,
-            intervalMs,
-            pulse: async ({ channelId, accountId, cfg }) =>
-              void (await sendTypingDiscord(channelId, {
-                accountId,
-                cfg,
-              })),
-          }),
-      },
-      conversationActions: {
-        editMessage: editMessageDiscord,
-        deleteMessage: deleteMessageDiscord,
-        pinMessage: pinMessageDiscord,
-        unpinMessage: unpinMessageDiscord,
-        createThread: createThreadDiscord,
-        editChannel: editChannelDiscord,
-      },
-    },
-    slack: {
-      listDirectoryGroupsLive: listSlackDirectoryGroupsLive,
-      listDirectoryPeersLive: listSlackDirectoryPeersLive,
-      probeSlack,
-      resolveChannelAllowlist: resolveSlackChannelAllowlist,
-      resolveUserAllowlist: resolveSlackUserAllowlist,
-      sendMessageSlack,
-      monitorSlackProvider,
-      handleSlackAction,
-    },
-    telegram: {
-      auditGroupMembership: auditTelegramGroupMembership,
-      collectUnmentionedGroupIds: collectTelegramUnmentionedGroupIds,
-      probeTelegram,
-      resolveTelegramToken,
-      sendMessageTelegram,
-      sendPollTelegram,
-      monitorTelegramProvider,
-      messageActions: telegramMessageActions,
-      typing: {
-        pulse: sendTypingTelegram,
-        start: async ({ to, accountId, cfg, intervalMs, messageThreadId }) =>
-          await createTelegramTypingLease({
-            to,
-            accountId,
-            cfg,
-            intervalMs,
-            messageThreadId,
-            pulse: async ({ to, accountId, cfg, messageThreadId }) =>
-              await sendTypingTelegram(to, {
-                accountId,
-                cfg,
-                messageThreadId,
-              }),
-          }),
-      },
-      conversationActions: {
-        editMessage: editMessageTelegram,
-        editReplyMarkup: editMessageReplyMarkupTelegram,
-        clearReplyMarkup: async (chatIdInput, messageIdInput, opts = {}) =>
-          await editMessageReplyMarkupTelegram(chatIdInput, messageIdInput, [], opts),
-        deleteMessage: deleteMessageTelegram,
-        renameTopic: renameForumTopicTelegram,
-        pinMessage: pinMessageTelegram,
-        unpinMessage: unpinMessageTelegram,
-      },
-    },
-    signal: {
-      probeSignal,
-      sendMessageSignal,
-      monitorSignalProvider,
-      messageActions: signalMessageActions,
-    },
-    imessage: {
-      monitorIMessageProvider,
-      probeIMessage,
-      sendMessageIMessage,
-    },
+    discord: createRuntimeDiscord(),
+    slack: createRuntimeSlack(),
+    telegram: createRuntimeTelegram(),
+    signal: createRuntimeSignal(),
+    imessage: createRuntimeIMessage(),
    whatsapp: createRuntimeWhatsApp(),
    line: {
      listLineAccountIds,
--- a/src/plugins/runtime/runtime-discord.ts
+++ b/src/plugins/runtime/runtime-discord.ts
@@ -0,0 +1,60 @@
+import { auditDiscordChannelPermissions } from "../../../extensions/discord/src/audit.js";
+import {
+  listDiscordDirectoryGroupsLive,
+  listDiscordDirectoryPeersLive,
+} from "../../../extensions/discord/src/directory-live.js";
+import { monitorDiscordProvider } from "../../../extensions/discord/src/monitor.js";
+import { probeDiscord } from "../../../extensions/discord/src/probe.js";
+import { resolveDiscordChannelAllowlist } from "../../../extensions/discord/src/resolve-channels.js";
+import { resolveDiscordUserAllowlist } from "../../../extensions/discord/src/resolve-users.js";
+import {
+  createThreadDiscord,
+  deleteMessageDiscord,
+  editChannelDiscord,
+  editMessageDiscord,
+  pinMessageDiscord,
+  sendDiscordComponentMessage,
+  sendMessageDiscord,
+  sendPollDiscord,
+  sendTypingDiscord,
+  unpinMessageDiscord,
+} from "../../../extensions/discord/src/send.js";
+import { discordMessageActions } from "../../channels/plugins/actions/discord.js";
+import { createDiscordTypingLease } from "./runtime-discord-typing.js";
+import type { PluginRuntimeChannel } from "./types-channel.js";
+
+export function createRuntimeDiscord(): PluginRuntimeChannel["discord"] {
+  return {
+    messageActions: discordMessageActions,
+    auditChannelPermissions: auditDiscordChannelPermissions,
+    listDirectoryGroupsLive: listDiscordDirectoryGroupsLive,
+    listDirectoryPeersLive: listDiscordDirectoryPeersLive,
+    probeDiscord,
+    resolveChannelAllowlist: resolveDiscordChannelAllowlist,
+    resolveUserAllowlist: resolveDiscordUserAllowlist,
+    sendComponentMessage: sendDiscordComponentMessage,
+    sendMessageDiscord,
+    sendPollDiscord,
+    monitorDiscordProvider,
+    typing: {
+      pulse: sendTypingDiscord,
+      start: async ({ channelId, accountId, cfg, intervalMs }) =>
+        await createDiscordTypingLease({
+          channelId,
+          accountId,
+          cfg,
+          intervalMs,
+          pulse: async ({ channelId, accountId, cfg }) =>
+            void (await sendTypingDiscord(channelId, { accountId, cfg })),
+        }),
+    },
+    conversationActions: {
+      editMessage: editMessageDiscord,
+      deleteMessage: deleteMessageDiscord,
+      pinMessage: pinMessageDiscord,
+      unpinMessage: unpinMessageDiscord,
+      createThread: createThreadDiscord,
+      editChannel: editChannelDiscord,
+    },
+  };
+}
--- a/src/plugins/runtime/runtime-imessage.ts
+++ b/src/plugins/runtime/runtime-imessage.ts
@@ -0,0 +1,12 @@
+import { monitorIMessageProvider } from "../../../extensions/imessage/src/monitor.js";
+import { probeIMessage } from "../../../extensions/imessage/src/probe.js";
+import { sendMessageIMessage } from "../../../extensions/imessage/src/send.js";
+import type { PluginRuntimeChannel } from "./types-channel.js";
+
+export function createRuntimeIMessage(): PluginRuntimeChannel["imessage"] {
+  return {
+    monitorIMessageProvider,
+    probeIMessage,
+    sendMessageIMessage,
+  };
+}
--- a/src/plugins/runtime/runtime-signal.ts
+++ b/src/plugins/runtime/runtime-signal.ts
@@ -0,0 +1,14 @@
+import { monitorSignalProvider } from "../../../extensions/signal/src/index.js";
+import { probeSignal } from "../../../extensions/signal/src/probe.js";
+import { sendMessageSignal } from "../../../extensions/signal/src/send.js";
+import { signalMessageActions } from "../../channels/plugins/actions/signal.js";
+import type { PluginRuntimeChannel } from "./types-channel.js";
+
+export function createRuntimeSignal(): PluginRuntimeChannel["signal"] {
+  return {
+    probeSignal,
+    sendMessageSignal,
+    monitorSignalProvider,
+    messageActions: signalMessageActions,
+  };
+}
--- a/src/plugins/runtime/runtime-slack.ts
+++ b/src/plugins/runtime/runtime-slack.ts
@@ -0,0 +1,24 @@
+import {
+  listSlackDirectoryGroupsLive,
+  listSlackDirectoryPeersLive,
+} from "../../../extensions/slack/src/directory-live.js";
+import { monitorSlackProvider } from "../../../extensions/slack/src/index.js";
+import { probeSlack } from "../../../extensions/slack/src/probe.js";
+import { resolveSlackChannelAllowlist } from "../../../extensions/slack/src/resolve-channels.js";
+import { resolveSlackUserAllowlist } from "../../../extensions/slack/src/resolve-users.js";
+import { sendMessageSlack } from "../../../extensions/slack/src/send.js";
+import { handleSlackAction } from "../../agents/tools/slack-actions.js";
+import type { PluginRuntimeChannel } from "./types-channel.js";
+
+export function createRuntimeSlack(): PluginRuntimeChannel["slack"] {
+  return {
+    listDirectoryGroupsLive: listSlackDirectoryGroupsLive,
+    listDirectoryPeersLive: listSlackDirectoryPeersLive,
+    probeSlack,
+    resolveChannelAllowlist: resolveSlackChannelAllowlist,
+    resolveUserAllowlist: resolveSlackUserAllowlist,
+    sendMessageSlack,
+    monitorSlackProvider,
+    handleSlackAction,
+  };
+}
--- a/src/plugins/runtime/runtime-telegram.ts
+++ b/src/plugins/runtime/runtime-telegram.ts
@@ -0,0 +1,61 @@
+import {
+  auditTelegramGroupMembership,
+  collectTelegramUnmentionedGroupIds,
+} from "../../../extensions/telegram/src/audit.js";
+import { monitorTelegramProvider } from "../../../extensions/telegram/src/monitor.js";
+import { probeTelegram } from "../../../extensions/telegram/src/probe.js";
+import {
+  deleteMessageTelegram,
+  editMessageReplyMarkupTelegram,
+  editMessageTelegram,
+  pinMessageTelegram,
+  renameForumTopicTelegram,
+  sendMessageTelegram,
+  sendPollTelegram,
+  sendTypingTelegram,
+  unpinMessageTelegram,
+} from "../../../extensions/telegram/src/send.js";
+import { resolveTelegramToken } from "../../../extensions/telegram/src/token.js";
+import { telegramMessageActions } from "../../channels/plugins/actions/telegram.js";
+import { createTelegramTypingLease } from "./runtime-telegram-typing.js";
+import type { PluginRuntimeChannel } from "./types-channel.js";
+
+export function createRuntimeTelegram(): PluginRuntimeChannel["telegram"] {
+  return {
+    auditGroupMembership: auditTelegramGroupMembership,
+    collectUnmentionedGroupIds: collectTelegramUnmentionedGroupIds,
+    probeTelegram,
+    resolveTelegramToken,
+    sendMessageTelegram,
+    sendPollTelegram,
+    monitorTelegramProvider,
+    messageActions: telegramMessageActions,
+    typing: {
+      pulse: sendTypingTelegram,
+      start: async ({ to, accountId, cfg, intervalMs, messageThreadId }) =>
+        await createTelegramTypingLease({
+          to,
+          accountId,
+          cfg,
+          intervalMs,
+          messageThreadId,
+          pulse: async ({ to, accountId, cfg, messageThreadId }) =>
+            await sendTypingTelegram(to, {
+              accountId,
+              cfg,
+              messageThreadId,
+            }),
+        }),
+    },
+    conversationActions: {
+      editMessage: editMessageTelegram,
+      editReplyMarkup: editMessageReplyMarkupTelegram,
+      clearReplyMarkup: async (chatIdInput, messageIdInput, opts = {}) =>
+        await editMessageReplyMarkupTelegram(chatIdInput, messageIdInput, [], opts),
+      deleteMessage: deleteMessageTelegram,
+      renameTopic: renameForumTopicTelegram,
+      pinMessage: pinMessageTelegram,
+      unpinMessage: unpinMessageTelegram,
+    },
+  };
+}