From 7b73faaa7eae48c6fc3afa4a5ffa642da1abe969 Mon Sep 17 00:00:00 2001 From: Shakker Date: Sat, 9 May 2026 05:13:55 +0100 Subject: [PATCH] test: tighten task empty array assertions --- .../isolated-agent.delivery-awareness.test.ts | 2 +- .../isolated-agent/run-fallback-policy.test.ts | 4 ++-- .../run.cron-model-override-forwarding.test.ts | 2 +- src/cron/normalize.test.ts | 6 +++--- src/cron/run-log.test.ts | 6 +++--- src/cron/service/timer.regression.test.ts | 4 ++-- src/tasks/task-boundaries.test.ts | 2 +- src/tasks/task-executor.test.ts | 2 +- src/tasks/task-flow-owner-access.test.ts | 2 +- src/tasks/task-flow-registry.audit.test.ts | 2 +- ...sk-registry.maintenance.issue-60299.test.ts | 2 +- src/tasks/task-registry.test.ts | 18 +++++++++--------- 12 files changed, 26 insertions(+), 26 deletions(-) diff --git a/src/cron/isolated-agent.delivery-awareness.test.ts b/src/cron/isolated-agent.delivery-awareness.test.ts index 09529359c72..1f811df8ea2 100644 --- a/src/cron/isolated-agent.delivery-awareness.test.ts +++ b/src/cron/isolated-agent.delivery-awareness.test.ts @@ -132,7 +132,7 @@ describe("runCronIsolatedAgentTurn cron delivery awareness", () => { expect(result.status).toBe("ok"); expect(result.delivered).toBe(true); - expect(peekSystemEvents("agent:main:main")).toEqual([]); + expect(peekSystemEvents("agent:main:main")).toStrictEqual([]); }); }); }); diff --git a/src/cron/isolated-agent/run-fallback-policy.test.ts b/src/cron/isolated-agent/run-fallback-policy.test.ts index 367fcfa9f4d..36eab9d5165 100644 --- a/src/cron/isolated-agent/run-fallback-policy.test.ts +++ b/src/cron/isolated-agent/run-fallback-policy.test.ts @@ -53,7 +53,7 @@ describe("resolveCronFallbacksOverride", () => { model: "google/gemini-2.0-flash", }), }), - ).toEqual([]); + ).toStrictEqual([]); }); it("lets payload fallbacks override the configured fallback policy", () => { @@ -68,7 +68,7 @@ describe("resolveCronFallbacksOverride", () => { fallbacks: [], }), }), - ).toEqual([]); + ).toStrictEqual([]); }); it("leaves the default model path to the fallback runner when no payload model is set", () => { diff --git a/src/cron/isolated-agent/run.cron-model-override-forwarding.test.ts b/src/cron/isolated-agent/run.cron-model-override-forwarding.test.ts index 089e54a8b6e..370cd75a9a5 100644 --- a/src/cron/isolated-agent/run.cron-model-override-forwarding.test.ts +++ b/src/cron/isolated-agent/run.cron-model-override-forwarding.test.ts @@ -220,7 +220,7 @@ describe("runCronIsolatedAgentTurn — cron model override forwarding (#58065)", // With the fix, the shared override helper resolves an explicit empty // list here: no configured fallback chain, and no silent agent-primary // append on retry. - expect(capturedFallbacksOverride).toEqual([]); + expect(capturedFallbacksOverride).toStrictEqual([]); }); it("preserves default fallback chain for cron payload model overrides", async () => { diff --git a/src/cron/normalize.test.ts b/src/cron/normalize.test.ts index c08fdcf6311..4b1a10b0613 100644 --- a/src/cron/normalize.test.ts +++ b/src/cron/normalize.test.ts @@ -540,7 +540,7 @@ describe("normalizeCronJobCreate", () => { }) as unknown as Record; const payload = normalized.payload as Record; - expect(payload.toolsAllow).toEqual([]); + expect(payload.toolsAllow).toStrictEqual([]); expect(validateCronAddParams(normalized)).toBe(true); }); @@ -799,7 +799,7 @@ describe("normalizeCronJobPatch", () => { const payload = normalized.payload as Record; expect(payload.kind).toBe("agentTurn"); - expect(payload.fallbacks).toEqual([]); + expect(payload.fallbacks).toStrictEqual([]); }); it("preserves empty toolsAllow lists so patches can disable all tools", () => { @@ -811,7 +811,7 @@ describe("normalizeCronJobPatch", () => { const payload = normalized.payload as Record; expect(payload.kind).toBe("agentTurn"); - expect(payload.toolsAllow).toEqual([]); + expect(payload.toolsAllow).toStrictEqual([]); expect(validateCronUpdateParams({ id: "job-1", patch: normalized })).toBe(true); }); diff --git a/src/cron/run-log.test.ts b/src/cron/run-log.test.ts index 7ab892b80d6..62b16184922 100644 --- a/src/cron/run-log.test.ts +++ b/src/cron/run-log.test.ts @@ -126,7 +126,7 @@ describe("cron run log", () => { durationMs: 100, }), ]); - expect(readCronRunLogEntriesSync(path.join(dir, "runs", "missing.jsonl"))).toEqual([]); + expect(readCronRunLogEntriesSync(path.join(dir, "runs", "missing.jsonl"))).toStrictEqual([]); }); }); @@ -223,7 +223,7 @@ describe("cron run log", () => { limit: 10, jobId: "b", }); - expect(wrongFilter).toEqual([]); + expect(wrongFilter).toStrictEqual([]); }); }); @@ -310,7 +310,7 @@ describe("cron run log", () => { query: "-100", }) ).entries, - ).toEqual([]); + ).toStrictEqual([]); }); }); diff --git a/src/cron/service/timer.regression.test.ts b/src/cron/service/timer.regression.test.ts index 66c4f5d9536..100d1db4a0f 100644 --- a/src/cron/service/timer.regression.test.ts +++ b/src/cron/service/timer.regression.test.ts @@ -1070,7 +1070,7 @@ describe("cron service timer regressions", () => { await onTimer(state); - expect(state.store?.jobs).toEqual([]); + expect(state.store?.jobs).toStrictEqual([]); expect(log.warn).not.toHaveBeenCalledWith( expect.anything(), "cron: applyOutcomeToStoredJob — job not found after forceReload, result discarded", @@ -1124,7 +1124,7 @@ describe("cron service timer regressions", () => { await onTimer(state); - expect(state.store?.jobs).toEqual([]); + expect(state.store?.jobs).toStrictEqual([]); expect(log.warn).toHaveBeenCalledWith( { jobId: failedJob.id }, "cron: applyOutcomeToStoredJob — job not found after forceReload, result discarded", diff --git a/src/tasks/task-boundaries.test.ts b/src/tasks/task-boundaries.test.ts index 77561c7bdff..5a4966d40dc 100644 --- a/src/tasks/task-boundaries.test.ts +++ b/src/tasks/task-boundaries.test.ts @@ -61,7 +61,7 @@ describe("task boundaries", () => { } } } - expect(offenders).toEqual([]); + expect(offenders).toStrictEqual([]); }); it("keeps direct task-flow-registry imports behind approved task-flow access seams", () => { diff --git a/src/tasks/task-executor.test.ts b/src/tasks/task-executor.test.ts index 6016fb56478..416a4423ba8 100644 --- a/src/tasks/task-executor.test.ts +++ b/src/tasks/task-executor.test.ts @@ -358,7 +358,7 @@ describe("task-executor", () => { }); expect(created.parentFlowId).toBeUndefined(); - expect(listTaskFlowRecords()).toEqual([]); + expect(listTaskFlowRecords()).toStrictEqual([]); }); }); diff --git a/src/tasks/task-flow-owner-access.test.ts b/src/tasks/task-flow-owner-access.test.ts index be58a535d58..23195e69e6b 100644 --- a/src/tasks/task-flow-owner-access.test.ts +++ b/src/tasks/task-flow-owner-access.test.ts @@ -94,6 +94,6 @@ describe("task flow owner access", () => { listTaskFlowsForOwner({ callerOwnerKey: "agent:main:other", }), - ).toEqual([]); + ).toStrictEqual([]); }); }); diff --git a/src/tasks/task-flow-registry.audit.test.ts b/src/tasks/task-flow-registry.audit.test.ts index 84daacb7bd3..1bf6d681fc2 100644 --- a/src/tasks/task-flow-registry.audit.test.ts +++ b/src/tasks/task-flow-registry.audit.test.ts @@ -93,7 +93,7 @@ describe("task-flow-registry audit", () => { }, }); - expect(listTaskFlowAuditFindings()).toEqual([]); + expect(listTaskFlowAuditFindings()).toStrictEqual([]); }); it("detects stuck managed flows and missing blocked tasks", async () => { diff --git a/src/tasks/task-registry.maintenance.issue-60299.test.ts b/src/tasks/task-registry.maintenance.issue-60299.test.ts index d249a6f98f4..22543f69bba 100644 --- a/src/tasks/task-registry.maintenance.issue-60299.test.ts +++ b/src/tasks/task-registry.maintenance.issue-60299.test.ts @@ -471,7 +471,7 @@ describe("task-registry maintenance issue #60299", () => { error: "backing session missing", }), ]); - expect(getInspectableActiveTaskRestartBlockers()).toEqual([]); + expect(getInspectableActiveTaskRestartBlockers()).toStrictEqual([]); expect(await runTaskRegistryMaintenance()).toMatchObject({ reconciled: 1 }); expect(currentTasks.get(task.taskId)).toMatchObject({ status: "lost" }); }); diff --git a/src/tasks/task-registry.test.ts b/src/tasks/task-registry.test.ts index 4c6451c2883..1659ba83d41 100644 --- a/src/tasks/task-registry.test.ts +++ b/src/tasks/task-registry.test.ts @@ -808,7 +808,7 @@ describe("task-registry", () => { }), ), ); - expect(peekSystemEvents("agent:main:main")).toEqual([]); + expect(peekSystemEvents("agent:main:main")).toStrictEqual([]); }); }); @@ -1098,7 +1098,7 @@ describe("task-registry", () => { }), ), ); - expect(peekSystemEvents("agent:main:main")).toEqual([]); + expect(peekSystemEvents("agent:main:main")).toStrictEqual([]); expect(hasPendingHeartbeatWake()).toBe(false); }); }); @@ -1546,7 +1546,7 @@ describe("task-registry", () => { expect(getTaskById(task.taskId)).toMatchObject({ status: "running", }); - expect(peekSystemEvents("agent:main:main")).toEqual([]); + expect(peekSystemEvents("agent:main:main")).toStrictEqual([]); }); }); @@ -1978,7 +1978,7 @@ describe("task-registry", () => { cleanupStamped: 0, pruned: 1, }); - expect(listTaskRecords()).toEqual([]); + expect(listTaskRecords()).toStrictEqual([]); }); }); @@ -2117,7 +2117,7 @@ describe("task-registry", () => { startTaskRegistryMaintenance(); await vi.advanceTimersByTimeAsync(5_000); await flushAsyncWork(); - expect(unhandled).toEqual([]); + expect(unhandled).toStrictEqual([]); } finally { process.off("unhandledRejection", onUnhandledRejection); } @@ -2528,7 +2528,7 @@ describe("task-registry", () => { }); vi.advanceTimersByTime(10); - expect(peekSystemEvents("agent:main:main")).toEqual([]); + expect(peekSystemEvents("agent:main:main")).toStrictEqual([]); expect(hoisted.sendMessageMock).not.toHaveBeenCalled(); emitAgentEvent({ @@ -2548,7 +2548,7 @@ describe("task-registry", () => { content: "Background task done: ACP background task (run run-quie).", }), ); - expect(peekSystemEvents("agent:main:main")).toEqual([]); + expect(peekSystemEvents("agent:main:main")).toStrictEqual([]); relay.dispose(); vi.useRealTimers(); }); @@ -2601,7 +2601,7 @@ describe("task-registry", () => { "Background task failed: ACP background task (run run-fail). Permission denied by ACP runtime", }), ); - expect(peekSystemEvents("agent:main:main")).toEqual([]); + expect(peekSystemEvents("agent:main:main")).toStrictEqual([]); }); }); @@ -2662,7 +2662,7 @@ describe("task-registry", () => { }), ); - expect(peekSystemEvents("agent:main:main")).toEqual([]); + expect(peekSystemEvents("agent:main:main")).toStrictEqual([]); relay.dispose(); vi.useRealTimers(); });