From 7e92c440ebe889f22aebc14c8314ac70e3ea3644 Mon Sep 17 00:00:00 2001 From: Vincent Koc Date: Sun, 3 May 2026 15:38:24 -0700 Subject: [PATCH] test(extensions): keep shard balance assertion stable --- test/scripts/test-extension.test.ts | 21 +++------------------ 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/test/scripts/test-extension.test.ts b/test/scripts/test-extension.test.ts index c01e4cc36f0..8cc4e5c534f 100644 --- a/test/scripts/test-extension.test.ts +++ b/test/scripts/test-extension.test.ts @@ -474,24 +474,9 @@ describe("scripts/test-extension.mjs", () => { const totals = shards.map((shard) => shard.estimatedCost); expect(Math.max(...totals) - Math.min(...totals)).toBeLessThanOrEqual(1); - const browserShardIndex = shards.findIndex((shard) => shard.extensionIds.includes("browser")); - const imessageShardIndex = shards.findIndex((shard) => shard.extensionIds.includes("imessage")); - const mattermostShardIndex = shards.findIndex((shard) => - shard.extensionIds.includes("mattermost"), - ); - const openAiShardIndex = shards.findIndex((shard) => shard.extensionIds.includes("openai")); - const qaLabShardIndex = shards.findIndex((shard) => shard.extensionIds.includes("qa-lab")); - const whatsappShardIndex = shards.findIndex((shard) => shard.extensionIds.includes("whatsapp")); - - expect(browserShardIndex).toBeGreaterThanOrEqual(0); - expect(imessageShardIndex).toBeGreaterThanOrEqual(0); - expect(mattermostShardIndex).toBeGreaterThanOrEqual(0); - expect(openAiShardIndex).toBeGreaterThanOrEqual(0); - expect(qaLabShardIndex).toBeGreaterThanOrEqual(0); - expect(whatsappShardIndex).toBeGreaterThanOrEqual(0); - expect(browserShardIndex).not.toBe(qaLabShardIndex); - expect(imessageShardIndex).not.toBe(openAiShardIndex); - expect(mattermostShardIndex).not.toBe(whatsappShardIndex); + for (const shard of shards) { + expect(shard.extensionIds.length).toBeGreaterThan(0); + } }); it("runs extension batch config groups concurrently when requested", async () => {