refactor(cli): rely on Commander contracts (#106366)

This commit is contained in:
Peter Steinberger
2026-07-13 05:05:31 -07:00
committed by GitHub
parent a03df5fd58
commit 801ec63f92
13 changed files with 42 additions and 155 deletions

View File

@@ -154,7 +154,7 @@ export function registerCronAddCommand(cron: Command) {
nameArg: string | undefined,
messageArg: string | undefined,
opts: GatewayRpcOpts & Record<string, unknown>,
cmd?: Command,
cmd: Command,
) => {
try {
const hasScheduleFlag =
@@ -183,11 +183,6 @@ export function registerCronAddCommand(cron: Command) {
const rawAgentId = normalizeOptionalString(opts.agent);
const agentId = rawAgentId ? sanitizeAgentId(rawAgentId) : undefined;
const optionSource =
typeof cmd?.getOptionValueSource === "function"
? (name: string) => cmd.getOptionValueSource(name)
: () => undefined;
const hasAnnounce = Boolean(opts.announce) || opts.deliver === true;
const hasNoDeliver = opts.deliver === false;
const webhookUrl = normalizeOptionalString(opts.webhook);
@@ -284,7 +279,7 @@ export function registerCronAddCommand(cron: Command) {
};
})();
const sessionSource = optionSource("session");
const sessionSource = cmd.getOptionValueSource("session");
const sessionTargetRaw = normalizeOptionalString(opts.session) ?? "";
const inferredSessionTarget =
payload.kind === "agentTurn" || payload.kind === "command" ? "isolated" : "main";
@@ -331,7 +326,7 @@ export function registerCronAddCommand(cron: Command) {
const threadId = parseCronThreadIdOption(opts.threadId);
const hasThreadId = typeof threadId === "number";
const hasChatDeliveryTarget =
optionSource("channel") === "cli" ||
cmd.getOptionValueSource("channel") === "cli" ||
typeof opts.to === "string" ||
Boolean(accountId) ||
hasThreadId;
@@ -408,7 +403,7 @@ export function registerCronAddCommand(cron: Command) {
declarationKey,
displayName,
description,
...(declarationKey && optionSource("disabled") !== "cli"
...(declarationKey && cmd.getOptionValueSource("disabled") !== "cli"
? {}
: { enabled: !opts.disabled }),
deleteAfterRun: opts.deleteAfterRun ? true : opts.keepAfterRun ? false : undefined,