vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-07-03 03:23:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(cli): reject present-but-invalid --timeout on status/health fast path (#92996)

Browse Source 
Merged via squash.

Prepared head SHA: eda96f9f80
Co-authored-by: Alix-007 <267018309+Alix-007@users.noreply.github.com>
Co-authored-by: steipete <58493+steipete@users.noreply.github.com>
Reviewed-by: @steipete
This commit is contained in:
Alix-007
2026-06-20 03:33:24 +08:00
committed by GitHub
parent 753ff96771
commit 806a37fca8
3 changed files with 91 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
src/cli/program/route-args.test.ts
View File

@@ -44,6 +44,48 @@ describe("route-args", () => {
expect(parseStatusRouteArgs(["node", "openclaw", "status", "--timeout"])).toBeNull();
});
it("defers status/health --timeout with a present-but-invalid value to Commander", () => {
// Regression: the route-first fast path used to silently accept invalid
// --timeout values (0, negative, non-numeric, unit-suffixed) and run with
// the default timeout, diverging from the full Commander path which rejects
// them with a non-zero exit. Returning null defers to Commander so both
// paths share the same validation.
for (const bad of ["0", "-5", "nope", "5s"]) {
expect(parseStatusRouteArgs(["node", "openclaw", "status", "--timeout", bad])).toBeNull();
expect(parseHealthRouteArgs(["node", "openclaw", "health", "--timeout", bad])).toBeNull();
}
expect(
parseStatusRouteArgs([
"node",
"openclaw",
"status",
"--timeout",
"5000",
"--timeout",
"nope",
]),
).toBeNull();
expect(
parseHealthRouteArgs([
"node",
"openclaw",
"health",
"--timeout",
"nope",
"--timeout",
"5000",
]),
).toMatchObject({ timeoutMs: 5000 });
// A valid positive integer still parses on the fast path.
expect(parseStatusRouteArgs(["node", "openclaw", "status", "--timeout", "5000"])).toMatchObject(
{ timeoutMs: 5000 },
);
// No --timeout flag at all still uses the fast path (undefined timeout).
expect(parseStatusRouteArgs(["node", "openclaw", "status"])).toMatchObject({
timeoutMs: undefined,
});
});
it("parses gateway status route args and rejects probe-only ssh flags", () => {
expect(
parseGatewayStatusRouteArgs([