From 83c1d25d6bfc8ea69316158eddc39fc16ae7b17b Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Fri, 1 May 2026 22:24:10 +0100
Subject: [PATCH] refactor: remove unused plugin test reset hooks

---
 src/channels/plugins/configured-binding-builtins.ts |  9 +--------
 src/channels/plugins/stateful-target-builtins.ts    | 11 +----------
 src/plugin-sdk/facade-activation-check.runtime.ts   |  2 --
 src/plugin-sdk/facade-runtime.test.ts               |  2 --
 src/plugin-sdk/facade-runtime.ts                    |  1 -
 5 files changed, 2 insertions(+), 23 deletions(-)

diff --git a/src/channels/plugins/configured-binding-builtins.ts b/src/channels/plugins/configured-binding-builtins.ts
index 2d27e9b5286..46de0b452a6 100644
--- a/src/channels/plugins/configured-binding-builtins.ts
+++ b/src/channels/plugins/configured-binding-builtins.ts
@@ -1,13 +1,6 @@
 import { acpConfiguredBindingConsumer } from "./acp-configured-binding-consumer.js";
-import {
-  registerConfiguredBindingConsumer,
-  unregisterConfiguredBindingConsumer,
-} from "./configured-binding-consumers.js";
+import { registerConfiguredBindingConsumer } from "./configured-binding-consumers.js";
 
 export function ensureConfiguredBindingBuiltinsRegistered(): void {
   registerConfiguredBindingConsumer(acpConfiguredBindingConsumer);
 }
-
-export function resetConfiguredBindingBuiltinsForTesting(): void {
-  unregisterConfiguredBindingConsumer(acpConfiguredBindingConsumer.id);
-}
diff --git a/src/channels/plugins/stateful-target-builtins.ts b/src/channels/plugins/stateful-target-builtins.ts
index e78f168eec7..04275eeff94 100644
--- a/src/channels/plugins/stateful-target-builtins.ts
+++ b/src/channels/plugins/stateful-target-builtins.ts
@@ -1,7 +1,4 @@
-import {
-  registerStatefulBindingTargetDriver,
-  unregisterStatefulBindingTargetDriver,
-} from "./stateful-target-drivers.js";
+import { registerStatefulBindingTargetDriver } from "./stateful-target-drivers.js";
 
 type AcpStatefulTargetDriverModule = typeof import("./acp-stateful-target-driver.js");
 
@@ -33,9 +30,3 @@ export async function ensureStatefulTargetBuiltinsRegistered(): Promise<void> {
     throw error;
   }
 }
-
-export async function resetStatefulTargetBuiltinsForTesting(): Promise<void> {
-  builtinsRegisteredPromise = null;
-  const { acpStatefulBindingTargetDriver } = await loadAcpStatefulTargetDriverModule();
-  unregisterStatefulBindingTargetDriver(acpStatefulBindingTargetDriver.id);
-}
diff --git a/src/plugin-sdk/facade-activation-check.runtime.ts b/src/plugin-sdk/facade-activation-check.runtime.ts
index eada3802343..83a59391202 100644
--- a/src/plugin-sdk/facade-activation-check.runtime.ts
+++ b/src/plugin-sdk/facade-activation-check.runtime.ts
@@ -331,5 +331,3 @@ export function resolveActivatedBundledPluginPublicSurfaceAccessOrThrow(params:
   }
   return access;
 }
-
-export function resetFacadeActivationCheckRuntimeStateForTest(): void {}
diff --git a/src/plugin-sdk/facade-runtime.test.ts b/src/plugin-sdk/facade-runtime.test.ts
index 5465a17e418..d49b80d1713 100644
--- a/src/plugin-sdk/facade-runtime.test.ts
+++ b/src/plugin-sdk/facade-runtime.test.ts
@@ -6,7 +6,6 @@ import { setBundledPluginsDirOverrideForTest } from "../plugins/bundled-dir.js";
 import { createPluginActivationSource, normalizePluginsConfig } from "../plugins/config-state.js";
 import {
   evaluateBundledPluginPublicSurfaceAccess,
-  resetFacadeActivationCheckRuntimeStateForTest,
   resolveBundledPluginPublicSurfaceAccess as resolveActivationCheckBundledPluginPublicSurfaceAccess,
   throwForBundledPluginPublicSurfaceAccess,
 } from "./facade-activation-check.runtime.js";
@@ -89,7 +88,6 @@ afterEach(() => {
   }
   clearRuntimeConfigSnapshot();
   resetFacadeRuntimeStateForTest();
-  resetFacadeActivationCheckRuntimeStateForTest();
   setBundledPluginsDirOverrideForTest(undefined);
   vi.doUnmock("../plugins/manifest-registry.js");
   if (originalBundledPluginsDir === undefined) {
diff --git a/src/plugin-sdk/facade-runtime.ts b/src/plugin-sdk/facade-runtime.ts
index f759419566d..1abb4d5789d 100644
--- a/src/plugin-sdk/facade-runtime.ts
+++ b/src/plugin-sdk/facade-runtime.ts
@@ -245,7 +245,6 @@ export function tryLoadActivatedBundledPluginPublicSurfaceModuleSync<T extends o
 
 export function resetFacadeRuntimeStateForTest(): void {
   resetFacadeLoaderStateForTest();
-  facadeActivationCheckRuntimeModule?.resetFacadeActivationCheckRuntimeStateForTest();
   facadeActivationCheckRuntimeModule = undefined;
   facadeActivationCheckRuntimeJitiLoaders.clear();
 }