vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-02 12:30:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: address review — broaden sonnet-4 check, deduplicate helper

Browse Source 
- Use `sonnet-4` substring match instead of enumerating `sonnet-4-5`,
  `sonnet-4-6` explicitly. This is safe because legacy `claude-3-5-sonnet`
  does not contain `sonnet-4`, and it future-proofs for sonnet-4-7+.
- Export `shouldPreserveThinkingBlocks` from provider-replay-helpers.ts
  and import it in transcript-policy.ts instead of duplicating the logic.

Addresses review feedback from Greptile.
This commit is contained in:
Qinyao He
2026-04-06 02:58:58 -07:00
committed by Peter Steinberger
parent 88b4ebeaf6
commit 8818184da0
2 changed files with 9 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/plugins/provider-replay-helpers.ts
View File

@@ -70,22 +70,20 @@ export function buildStrictAnthropicReplayPolicy(
*
* See: https://platform.claude.com/docs/en/build-with-claude/extended-thinking#differences-in-thinking-across-model-versions
*/
function shouldPreserveThinkingBlocks(modelId?: string): boolean {
export function shouldPreserveThinkingBlocks(modelId?: string): boolean {
const id = (modelId ?? "").toLowerCase();
if (!id.includes("claude")) return false;
// Models that preserve thinking blocks natively:
// - claude-opus-4-5, claude-opus-4-6 (and any future opus-4.x+)
// - claude-sonnet-4-5, claude-sonnet-4-6 (and any future sonnet-4.x+)
// - claude-haiku-4-5 (and any future haiku-4.x+)
// Models that preserve thinking blocks natively (Claude 4.5+):
// - claude-opus-4-x (opus-4-5, opus-4-6, ...)
// - claude-sonnet-4-x (sonnet-4-5, sonnet-4-6, ...)
// Note: "sonnet-4" is safe — legacy "claude-3-5-sonnet" does not contain "sonnet-4"
// - claude-haiku-4-x (haiku-4-5, ...)
// Models that require dropping thinking blocks:
// - claude-3-7-sonnet, claude-3-5-sonnet, and earlier
if (
id.includes("opus-4") ||
id.includes("sonnet-4-5") ||
id.includes("sonnet-4-6") ||
id.includes("sonnet-4.5") ||
id.includes("sonnet-4.6") ||
id.includes("sonnet-4") ||
id.includes("haiku-4")
) {
return true;