From 8cd978c02a746b787644f1b5ce56bd450eb74970 Mon Sep 17 00:00:00 2001 From: Shakker Date: Sat, 9 May 2026 05:12:10 +0100 Subject: [PATCH] test: tighten core empty array assertions --- src/commitments/store.test.ts | 6 +++--- src/process/linux-oom-score.test.ts | 2 +- src/process/supervisor/adapters/child.test.ts | 4 ++-- src/process/supervisor/registry.test.ts | 2 +- src/test-utils/channel-plugins.test.ts | 2 +- src/tools/availability.test.ts | 10 +++++----- src/tools/boundary.test.ts | 2 +- src/tools/planner.test.ts | 4 ++-- 8 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/commitments/store.test.ts b/src/commitments/store.test.ts index 66aa338e5f3..a677fabab4a 100644 --- a/src/commitments/store.test.ts +++ b/src/commitments/store.test.ts @@ -70,7 +70,7 @@ describe("commitment store delivery selection", () => { sessionKey, nowMs, }), - ).resolves.toEqual([]); + ).resolves.toStrictEqual([]); }); it("limits delivered commitments per agent session in a rolling day", async () => { @@ -90,7 +90,7 @@ describe("commitment store delivery selection", () => { sessionKey, nowMs, }), - ).resolves.toEqual([]); + ).resolves.toStrictEqual([]); const store = await loadCommitmentStore(); expect(store.commitments).toHaveLength(2); @@ -118,7 +118,7 @@ describe("commitment store delivery selection", () => { sessionKey, nowMs, }), - ).resolves.toEqual([]); + ).resolves.toStrictEqual([]); const store = await loadCommitmentStore(); expect(store.commitments[0]).toMatchObject({ diff --git a/src/process/linux-oom-score.test.ts b/src/process/linux-oom-score.test.ts index 038b2b893e7..667a5df14ae 100644 --- a/src/process/linux-oom-score.test.ts +++ b/src/process/linux-oom-score.test.ts @@ -47,7 +47,7 @@ describe("wrapArgvForChildOomScoreRaise", () => { }); it("returns empty argv unchanged", () => { - expect(wrapArgvForChildOomScoreRaise([], linux)).toEqual([]); + expect(wrapArgvForChildOomScoreRaise([], linux)).toStrictEqual([]); }); it("skips wrap for command names that exec could parse as options", () => { diff --git a/src/process/supervisor/adapters/child.test.ts b/src/process/supervisor/adapters/child.test.ts index 0ca918c2c5b..c0a23b81f06 100644 --- a/src/process/supervisor/adapters/child.test.ts +++ b/src/process/supervisor/adapters/child.test.ts @@ -129,7 +129,7 @@ describe("createChildAdapter", () => { // on POSIX, detached is true with a no-detach fallback. if (process.platform === "win32") { expect(spawnArgs.options?.detached).toBe(false); - expect(spawnArgs.fallbacks).toEqual([]); + expect(spawnArgs.fallbacks).toStrictEqual([]); } else { expect(spawnArgs.options?.detached).toBe(true); expect(spawnArgs.fallbacks?.[0]?.options?.detached).toBe(false); @@ -263,7 +263,7 @@ describe("createChildAdapter", () => { fallbacks?: Array<{ options?: { detached?: boolean } }>; }; expect(spawnArgs.options?.detached).toBe(false); - expect(spawnArgs.fallbacks ?? []).toEqual([]); + expect(spawnArgs.fallbacks ?? []).toStrictEqual([]); }); it("keeps inherited env when no override env is provided on non-Linux", async () => { diff --git a/src/process/supervisor/registry.test.ts b/src/process/supervisor/registry.test.ts index 59bea5a8b8f..aa4923b9212 100644 --- a/src/process/supervisor/registry.test.ts +++ b/src/process/supervisor/registry.test.ts @@ -91,7 +91,7 @@ describe("process supervisor run registry", () => { startedAtMs: 2, }); - expect(registry.listByScope(" ")).toEqual([]); + expect(registry.listByScope(" ")).toStrictEqual([]); const scoped = registry.listByScope("scope:a"); expect(scoped).toHaveLength(1); const [firstScoped] = scoped; diff --git a/src/test-utils/channel-plugins.test.ts b/src/test-utils/channel-plugins.test.ts index 2076e50758c..d69c4e22dfe 100644 --- a/src/test-utils/channel-plugins.test.ts +++ b/src/test-utils/channel-plugins.test.ts @@ -45,6 +45,6 @@ describe("createOutboundTestPlugin", () => { sendText: async () => ({ channel: "demo-outbound", messageId: "m1" }), }, }); - expect(plugin.config.listAccountIds(cfg)).toEqual([]); + expect(plugin.config.listAccountIds(cfg)).toStrictEqual([]); }); }); diff --git a/src/tools/availability.test.ts b/src/tools/availability.test.ts index 5a28df7be09..26c6b39cf33 100644 --- a/src/tools/availability.test.ts +++ b/src/tools/availability.test.ts @@ -16,7 +16,7 @@ function isRecord(value: unknown): value is Record { describe("evaluateToolAvailability", () => { it("treats descriptors without signals as available", () => { - expect(evaluateToolAvailability({ descriptor: baseDescriptor })).toEqual([]); + expect(evaluateToolAvailability({ descriptor: baseDescriptor })).toStrictEqual([]); }); it("evaluates auth, env, config, plugin, and context signals from data only", () => { @@ -44,7 +44,7 @@ describe("evaluateToolAvailability", () => { values: { channel: "telegram" }, }, }), - ).toEqual([]); + ).toStrictEqual([]); }); it("returns deterministic diagnostics for missing signals", () => { @@ -141,7 +141,7 @@ describe("evaluateToolAvailability", () => { value.id === "OPENAI_API_KEY", }, }), - ).toEqual([]); + ).toStrictEqual([]); }); it("does not infer env-template strings as configured credentials", () => { @@ -192,7 +192,7 @@ describe("evaluateToolAvailability", () => { }, }, }), - ).toEqual([]); + ).toStrictEqual([]); }); it("supports anyOf availability expressions", () => { @@ -221,7 +221,7 @@ describe("evaluateToolAvailability", () => { enabledPluginIds: new Set(), }, }), - ).toEqual([]); + ).toStrictEqual([]); expect( evaluateToolAvailability({ diff --git a/src/tools/boundary.test.ts b/src/tools/boundary.test.ts index 97a4f602963..94bc590440b 100644 --- a/src/tools/boundary.test.ts +++ b/src/tools/boundary.test.ts @@ -40,6 +40,6 @@ describe("tool system boundary", () => { .map((reference) => `${entry.name}:${reference.line} ${reference.specifier}`); }); - expect(violations).toEqual([]); + expect(violations).toStrictEqual([]); }); }); diff --git a/src/tools/planner.test.ts b/src/tools/planner.test.ts index bc2db436f9e..fef42cf5cd7 100644 --- a/src/tools/planner.test.ts +++ b/src/tools/planner.test.ts @@ -92,7 +92,7 @@ describe("buildToolPlan", () => { availability: { enabledPluginIds: new Set() }, }); - expect(plan.visible).toEqual([]); + expect(plan.visible).toStrictEqual([]); const hiddenTool = expectHiddenTool(plan, 0); expect(hiddenTool.descriptor.name).toBe("plugin_tool"); expect(hiddenTool.diagnostics.map((entry) => entry.reason)).toEqual(["plugin-disabled"]); @@ -103,7 +103,7 @@ describe("buildToolPlan", () => { descriptors: [descriptor("malformed", { availability: { allOf: [] } })], }); - expect(plan.visible).toEqual([]); + expect(plan.visible).toStrictEqual([]); const hiddenTool = expectHiddenTool(plan, 0); expect(hiddenTool.descriptor.name).toBe("malformed"); expect(hiddenTool.diagnostics).toEqual([