From 92c1924d27a656f887b376a5d8b7e44ed17bf153 Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Mon, 27 Apr 2026 01:36:45 +0100 Subject: [PATCH] ci: remove duplicate extension fast lane --- .github/workflows/ci.yml | 133 ------------------------------------ docs/ci.md | 20 +++--- docs/reference/RELEASING.md | 5 +- 3 files changed, 11 insertions(+), 147 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e005e97a400..540b4d5e563 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -38,8 +38,6 @@ jobs: run_skills_python: ${{ steps.manifest.outputs.run_skills_python }} run_skills_python_job: ${{ steps.manifest.outputs.run_skills_python_job }} run_windows: ${{ steps.manifest.outputs.run_windows }} - has_changed_extensions: ${{ steps.manifest.outputs.has_changed_extensions }} - changed_extensions_matrix: ${{ steps.manifest.outputs.changed_extensions_matrix }} run_build_artifacts: ${{ steps.manifest.outputs.run_build_artifacts }} run_checks_fast_core: ${{ steps.manifest.outputs.run_checks_fast_core }} run_checks_fast: ${{ steps.manifest.outputs.run_checks_fast }} @@ -52,8 +50,6 @@ jobs: checks_node_core_nondist_matrix: ${{ steps.manifest.outputs.checks_node_core_nondist_matrix }} run_checks_node_core_dist: ${{ steps.manifest.outputs.run_checks_node_core_dist }} checks_node_core_dist_matrix: ${{ steps.manifest.outputs.checks_node_core_dist_matrix }} - run_extension_fast: ${{ steps.manifest.outputs.run_extension_fast }} - extension_fast_matrix: ${{ steps.manifest.outputs.extension_fast_matrix }} run_check: ${{ steps.manifest.outputs.run_check }} run_check_additional: ${{ steps.manifest.outputs.run_check_additional }} run_build_smoke: ${{ steps.manifest.outputs.run_build_smoke }} @@ -102,29 +98,6 @@ jobs: node scripts/ci-changed-scope.mjs --base "$BASE" --head HEAD - - name: Detect changed extensions - id: changed_extensions - if: github.event_name != 'workflow_dispatch' && steps.docs_scope.outputs.docs_only != 'true' && steps.changed_scope.outputs.run_node == 'true' - env: - BASE_SHA: ${{ github.event_name == 'push' && github.event.before || github.event.pull_request.base.sha }} - BASE_REF: ${{ github.event_name == 'push' && github.ref_name || github.event.pull_request.base.ref }} - run: | - node --input-type=module <<'EOF' - import { appendFileSync } from "node:fs"; - import { listChangedExtensionIds } from "./scripts/lib/changed-extensions.mjs"; - - const extensionIds = listChangedExtensionIds({ - base: process.env.BASE_SHA, - head: "HEAD", - fallbackBaseRef: process.env.BASE_REF, - unavailableBaseBehavior: "all", - }); - const matrix = JSON.stringify({ include: extensionIds.map((extension) => ({ extension })) }); - - appendFileSync(process.env.GITHUB_OUTPUT, `has_changed_extensions=${extensionIds.length > 0}\n`, "utf8"); - appendFileSync(process.env.GITHUB_OUTPUT, `changed_extensions_matrix=${matrix}\n`, "utf8"); - EOF - - name: Build CI manifest id: manifest env: @@ -139,8 +112,6 @@ jobs: OPENCLAW_CI_RUN_NODE_FAST_CI_ROUTING: ${{ github.event_name == 'workflow_dispatch' && 'false' || steps.changed_scope.outputs.run_node_fast_ci_routing || 'false' }} OPENCLAW_CI_RUN_SKILLS_PYTHON: ${{ github.event_name == 'workflow_dispatch' && 'true' || steps.changed_scope.outputs.run_skills_python || 'false' }} OPENCLAW_CI_RUN_CONTROL_UI_I18N: ${{ github.event_name == 'workflow_dispatch' && 'true' || steps.changed_scope.outputs.run_control_ui_i18n || 'false' }} - OPENCLAW_CI_HAS_CHANGED_EXTENSIONS: ${{ github.event_name == 'workflow_dispatch' && 'false' || steps.changed_extensions.outputs.has_changed_extensions || 'false' }} - OPENCLAW_CI_CHANGED_EXTENSIONS_MATRIX: ${{ github.event_name == 'workflow_dispatch' && '{"include":[]}' || steps.changed_extensions.outputs.changed_extensions_matrix || '{"include":[]}' }} OPENCLAW_CI_REPOSITORY: ${{ github.repository }} run: | node --input-type=module <<'EOF' @@ -164,18 +135,8 @@ jobs: return fallback; }; - const parseJson = (value, fallback) => { - try { - return value ? JSON.parse(value) : fallback; - } catch { - return fallback; - } - }; - const createMatrix = (include) => ({ include }); const outputPath = process.env.GITHUB_OUTPUT; - const eventName = process.env.GITHUB_EVENT_NAME ?? "pull_request"; - const isPush = eventName === "push"; const isCanonicalRepository = process.env.OPENCLAW_CI_REPOSITORY === "openclaw/openclaw"; const docsOnly = parseBoolean(process.env.OPENCLAW_CI_DOCS_ONLY); const docsChanged = parseBoolean(process.env.OPENCLAW_CI_DOCS_CHANGED); @@ -200,11 +161,6 @@ jobs: const runSkillsPython = parseBoolean(process.env.OPENCLAW_CI_RUN_SKILLS_PYTHON) && !docsOnly; const runControlUiI18n = parseBoolean(process.env.OPENCLAW_CI_RUN_CONTROL_UI_I18N) && !docsOnly; - const hasChangedExtensions = - parseBoolean(process.env.OPENCLAW_CI_HAS_CHANGED_EXTENSIONS) && !docsOnly; - const changedExtensionsMatrix = hasChangedExtensions - ? parseJson(process.env.OPENCLAW_CI_CHANGED_EXTENSIONS_MATRIX, { include: [] }) - : { include: [] }; const extensionTestShardCount = isCanonicalRepository ? DEFAULT_EXTENSION_TEST_SHARD_COUNT : Math.max(DEFAULT_EXTENSION_TEST_SHARD_COUNT, 36); @@ -274,8 +230,6 @@ jobs: run_android: runAndroid, run_skills_python: runSkillsPython, run_windows: runWindows, - has_changed_extensions: hasChangedExtensions, - changed_extensions_matrix: changedExtensionsMatrix, run_build_artifacts: runNodeFull, run_checks_fast_core: runChecksFastCore, run_checks_fast: runNodeFull, @@ -296,15 +250,6 @@ jobs: checks_node_core_nondist_matrix: createMatrix(nodeTestNonDistShards), run_checks_node_core_dist: nodeTestDistShards.length > 0, checks_node_core_dist_matrix: createMatrix(nodeTestDistShards), - run_extension_fast: hasChangedExtensions && !isPush, - extension_fast_matrix: createMatrix( - hasChangedExtensions && !isPush - ? (changedExtensionsMatrix.include ?? []).map((entry) => ({ - check_name: `extension-fast-${entry.extension}`, - extension: entry.extension, - })) - : [], - ), run_check: runNodeFull, run_check_additional: runNodeFull, run_build_smoke: runNodeFull, @@ -1326,84 +1271,6 @@ jobs: exit 1 fi - extension-fast: - permissions: - contents: read - name: "extension-fast" - needs: [preflight] - if: needs.preflight.outputs.run_extension_fast == 'true' - runs-on: ${{ github.repository == 'openclaw/openclaw' && 'blacksmith-8vcpu-ubuntu-2404' || 'ubuntu-24.04' }} - timeout-minutes: 60 - strategy: - fail-fast: false - matrix: ${{ fromJson(needs.preflight.outputs.extension_fast_matrix) }} - steps: - - name: Checkout - shell: bash - env: - CHECKOUT_REPO: ${{ github.repository }} - CHECKOUT_SHA: ${{ github.sha }} - CHECKOUT_TOKEN: ${{ github.token }} - run: | - set -euo pipefail - - workdir="$GITHUB_WORKSPACE" - auth_header="$(printf 'x-access-token:%s' "$CHECKOUT_TOKEN" | base64 | tr -d '\n')" - - reset_checkout_dir() { - mkdir -p "$workdir" - find "$workdir" -mindepth 1 -maxdepth 1 -exec rm -rf {} + - } - - checkout_attempt() { - local attempt="$1" - - reset_checkout_dir - git init "$workdir" >/dev/null - git config --global --add safe.directory "$workdir" - git -C "$workdir" remote add origin "https://github.com/${CHECKOUT_REPO}" - git -C "$workdir" config gc.auto 0 - - timeout --signal=TERM 30s git -C "$workdir" \ - -c protocol.version=2 \ - -c "http.https://github.com/.extraheader=AUTHORIZATION: basic ${auth_header}" \ - fetch --no-tags --prune --no-recurse-submodules --depth=1 origin \ - "+${CHECKOUT_SHA}:refs/remotes/origin/ci-target" || return 1 - - git -C "$workdir" checkout --force --detach "$CHECKOUT_SHA" || return 1 - test -f "$workdir/.github/actions/setup-node-env/action.yml" || return 1 - echo "checkout attempt ${attempt}/5 succeeded" - } - - for attempt in 1 2 3 4 5; do - if checkout_attempt "$attempt"; then - exit 0 - fi - echo "checkout attempt ${attempt}/5 failed" - sleep $((attempt * 5)) - done - - echo "checkout failed after 5 attempts" >&2 - exit 1 - - - name: Setup Node environment - uses: ./.github/actions/setup-node-env - with: - install-bun: "false" - - - name: Run changed extension tests - env: - OPENCLAW_CHANGED_EXTENSION: ${{ matrix.extension }} - run: | - set -euo pipefail - if [ "$OPENCLAW_CHANGED_EXTENSION" = "telegram" ]; then - export OPENCLAW_VITEST_MAX_WORKERS=1 - export NODE_OPTIONS="${NODE_OPTIONS:+$NODE_OPTIONS }--max-old-space-size=6144" - pnpm test:extension "$OPENCLAW_CHANGED_EXTENSION" -- --pool=forks - exit 0 - fi - pnpm test:extension "$OPENCLAW_CHANGED_EXTENSION" - # Types, lint, and format check shards. check-shard: permissions: diff --git a/docs/ci.md b/docs/ci.md index 070e744e576..0ec0e3210a8 100644 --- a/docs/ci.md +++ b/docs/ci.md @@ -66,11 +66,11 @@ gh workflow run duplicate-after-merge.yml \ | `checks-fast-contracts-channels` | Sharded channel contract checks with a stable aggregate check result | Node-relevant changes | | `checks-node-extensions` | Full bundled-plugin test shards across the extension suite | Node-relevant changes | | `checks-node-core-test` | Core Node test shards, excluding channel, bundled, contract, and extension lanes | Node-relevant changes | -| `extension-fast` | Focused tests for only the changed bundled plugins | Pull requests with extension changes | | `check` | Sharded main local gate equivalent: prod types, lint, guards, test types, and strict smoke | Node-relevant changes | | `check-additional` | Architecture, boundary, extension-surface guards, package-boundary, and gateway-watch shards | Node-relevant changes | | `build-smoke` | Built-CLI smoke tests and startup-memory smoke | Node-relevant changes | -| `checks` | Verifier for built-artifact channel tests plus push-only Node 22 compatibility | Node-relevant changes | +| `checks` | Verifier for built-artifact channel tests | Node-relevant changes | +| `checks-node-compat-node22` | Node 22 compatibility build and smoke lane | `main` pushes and manual CI dispatch | | `check-docs` | Docs formatting, lint, and broken-link checks | Docs changed | | `skills-python` | Ruff + pytest for Python-backed skills | Python-skill-relevant changes | | `checks-windows` | Windows-specific test lanes | Windows-relevant changes | @@ -81,12 +81,10 @@ gh workflow run duplicate-after-merge.yml \ Manual CI dispatches run the same job graph as normal CI but force every scoped lane on: Linux Node shards, bundled-plugin shards, channel contracts, -`check`, `check-additional`, build smoke, docs checks, Python skills, Windows, -macOS, Android, and Control UI i18n. They do not run the PR-only -`extension-fast` lane because the full bundled-plugin shard matrix already -covers bundled-plugin tests. Manual runs use a unique concurrency group so a -release-candidate full suite is not cancelled by another push or PR run on the -same ref. +Node 22 compatibility, `check`, `check-additional`, build smoke, docs checks, +Python skills, Windows, macOS, Android, and Control UI i18n. Manual runs use a +unique concurrency group so a release-candidate full suite is not cancelled by +another push or PR run on the same ref. ```bash gh workflow run ci.yml --ref release/YYYY.M.D @@ -99,7 +97,7 @@ Jobs are ordered so cheap checks fail before expensive ones run: 1. `preflight` decides which lanes exist at all. The `docs-scope` and `changed-scope` logic are steps inside this job, not standalone jobs. 2. `security-scm-fast`, `security-dependency-audit`, `security-fast`, `check`, `check-additional`, `check-docs`, and `skills-python` fail quickly without waiting on the heavier artifact and platform matrix jobs. 3. `build-artifacts` overlaps with the fast Linux lanes so downstream consumers can start as soon as the shared build is ready. -4. Heavier platform and runtime lanes fan out after that: `checks-fast-core`, `checks-fast-contracts-channels`, `checks-node-extensions`, `checks-node-core-test`, PR-only `extension-fast`, `checks`, `checks-windows`, `macos-node`, `macos-swift`, and `android`. +4. Heavier platform and runtime lanes fan out after that: `checks-fast-core`, `checks-fast-contracts-channels`, `checks-node-extensions`, `checks-node-core-test`, `checks`, `checks-windows`, `macos-node`, `macos-swift`, and `android`. Scope logic lives in `scripts/ci-changed-scope.mjs` and is covered by unit tests in `src/scripts/ci-changed-scope.test.ts`. Manual dispatch skips changed-scope detection and makes the preflight manifest @@ -111,12 +109,10 @@ The separate `install-smoke` workflow reuses the same scope script through its o Local changed-lane logic lives in `scripts/changed-lanes.mjs` and is executed by `scripts/check-changed.mjs`. That local check gate is stricter about architecture boundaries than the broad CI platform scope: core production changes run core prod and core test typecheck plus core lint/guards, core test-only changes run only core test typecheck plus core lint, extension production changes run extension prod and extension test typecheck plus extension lint, and extension test-only changes run extension test typecheck plus extension lint. Public Plugin SDK or plugin-contract changes expand to extension typecheck because extensions depend on those core contracts, but Vitest extension sweeps are explicit test work. Release metadata-only version bumps run targeted version/config/root-dependency checks. Unknown root/config changes fail safe to all check lanes. -On pushes, the `checks` matrix adds the push-only `compat-node22` lane. On pull requests, that lane is skipped and the matrix stays focused on the normal test/channel lanes. +On pushes and manual dispatches, `checks-node-compat-node22` runs the Node 22 compatibility build/smoke lane. On pull requests, that lane is skipped and the matrix stays focused on the normal Node 24 test/channel lanes. The slowest Node test families are split or balanced so each job stays small without over-reserving runners: channel contracts run as three weighted shards, bundled plugin tests balance across six extension workers, small core unit lanes are paired, auto-reply runs as four balanced workers with the reply subtree split into agent-runner, dispatch, and commands/state-routing shards, and agentic gateway/plugin configs are spread across the existing source-only agentic Node jobs instead of waiting on built artifacts. Broad browser, QA, media, and miscellaneous plugin tests use their dedicated Vitest configs instead of the shared plugin catch-all. Extension shard jobs run up to two plugin config groups at a time with one Vitest worker per group and a larger Node heap so import-heavy plugin batches do not create extra CI jobs. The broad agents lane uses the shared Vitest file-parallel scheduler because it is import/scheduling dominated rather than owned by a single slow test file. `runtime-config` runs with the infra core-runtime shard to keep the shared runtime shard from owning the tail. Include-pattern shards record timing entries using the CI shard name, so `.artifacts/vitest-shard-timings.json` can distinguish a whole config from a filtered shard. `check-additional` keeps package-boundary compile/canary work together and separates runtime topology architecture from gateway watch coverage; the boundary guard shard runs its small independent guards concurrently inside one job. Gateway watch, channel tests, and the core support-boundary shard run concurrently inside `build-artifacts` after `dist/` and `dist-runtime/` are already built, keeping their old check names as lightweight verifier jobs while avoiding two extra Blacksmith workers and a second artifact-consumer queue. Android CI runs both `testPlayDebugUnitTest` and `testThirdPartyDebugUnitTest`, then builds the Play debug APK. The third-party flavor has no separate source set or manifest; its unit-test lane still compiles that flavor with the SMS/call-log BuildConfig flags, while avoiding a duplicate debug APK packaging job on every Android-relevant push. -`extension-fast` is PR-only because push runs already execute the full bundled plugin shards. That keeps changed-plugin feedback for reviews without reserving an extra Blacksmith worker on `main` for coverage already present in `checks-node-extensions`. - GitHub may mark superseded jobs as `cancelled` when a newer push lands on the same PR or `main` ref. Treat that as CI noise unless the newest run for the same ref is also failing. Aggregate shard checks use `!cancelled() && always()` so they still report normal shard failures but do not queue after the whole workflow has already been superseded. The automatic CI concurrency key is versioned (`CI-v7-*`) so a GitHub-side zombie in an old queue group cannot indefinitely block newer main runs. Manual full-suite runs use `CI-manual-v1-*` and do not cancel in-progress runs. diff --git a/docs/reference/RELEASING.md b/docs/reference/RELEASING.md index ea0f9deec96..dfec8dc506a 100644 --- a/docs/reference/RELEASING.md +++ b/docs/reference/RELEASING.md @@ -52,8 +52,9 @@ OpenClaw has three public release lanes: - Run the manual `CI` workflow before release approval when you need full normal CI coverage for the release candidate. Manual CI dispatches bypass changed scoping and force the Linux Node shards, bundled-plugin shards, channel - contracts, `check`, `check-additional`, build smoke, docs checks, Python - skills, Windows, macOS, Android, and Control UI i18n lanes. + contracts, Node 22 compatibility, `check`, `check-additional`, build smoke, + docs checks, Python skills, Windows, macOS, Android, and Control UI i18n + lanes. Example: `gh workflow run ci.yml --ref release/YYYY.M.D` - Run `pnpm qa:otel:smoke` when validating release telemetry. It exercises QA-lab through a local OTLP/HTTP receiver and verifies the exported trace