refactor: remove redundant camera CLI conversions

This commit is contained in:
Peter Steinberger
2026-04-10 21:53:47 +01:00
parent 7ccf4b7d02
commit 9470b616c9
2 changed files with 12 additions and 12 deletions

View File

@@ -49,7 +49,7 @@ export function registerNodesCameraCommands(nodes: Command) {
.requiredOption("--node <idOrNameOrIp>", "Node id, name, or IP")
.action(async (opts: NodesRpcOpts) => {
await runNodesCommand("camera list", async () => {
const nodeId = await resolveNodeId(opts, String(opts.node ?? ""));
const nodeId = await resolveNodeId(opts, opts.node ?? "");
const raw = await callGatewayCli(
"node.invoke",
opts,
@@ -131,15 +131,15 @@ export function registerNodesCameraCommands(nodes: Command) {
);
})();
const maxWidth = opts.maxWidth ? Number.parseInt(String(opts.maxWidth), 10) : undefined;
const quality = opts.quality ? Number.parseFloat(String(opts.quality)) : undefined;
const delayMs = opts.delayMs ? Number.parseInt(String(opts.delayMs), 10) : undefined;
const maxWidth = opts.maxWidth ? Number.parseInt(opts.maxWidth, 10) : undefined;
const quality = opts.quality ? Number.parseFloat(opts.quality) : undefined;
const delayMs = opts.delayMs ? Number.parseInt(opts.delayMs, 10) : undefined;
const deviceId = normalizeOptionalString(opts.deviceId);
if (deviceId && facings.length > 1) {
throw new Error("facing=both is not allowed when --device-id is set");
}
const timeoutMs = opts.invokeTimeout
? Number.parseInt(String(opts.invokeTimeout), 10)
? Number.parseInt(opts.invokeTimeout, 10)
: undefined;
const results: Array<{
@@ -213,11 +213,11 @@ export function registerNodesCameraCommands(nodes: Command) {
await runNodesCommand("camera clip", async () => {
const node = await resolveNode(opts, normalizeOptionalString(opts.node) ?? "");
const nodeId = node.nodeId;
const facing = parseFacing(String(opts.facing ?? "front"));
const durationMs = parseDurationMs(String(opts.duration ?? "3000"));
const facing = parseFacing(opts.facing ?? "front");
const durationMs = parseDurationMs(opts.duration ?? "3000");
const includeAudio = opts.audio !== false;
const timeoutMs = opts.invokeTimeout
? Number.parseInt(String(opts.invokeTimeout), 10)
? Number.parseInt(opts.invokeTimeout, 10)
: undefined;
const deviceId = normalizeOptionalString(opts.deviceId);

View File

@@ -146,7 +146,7 @@ describe("cli program (nodes media)", () => {
nodeId: "ios-node",
command: "camera.clip",
timeoutMs: 90000,
idempotencyKey: "idem-test",
idempotencyKey: expect.any(String),
params: expect.objectContaining({
facing: "front",
durationMs: 3000,
@@ -190,7 +190,7 @@ describe("cli program (nodes media)", () => {
nodeId: "ios-node",
command: "camera.snap",
timeoutMs: 20000,
idempotencyKey: "idem-test",
idempotencyKey: expect.any(String),
params: expect.objectContaining({
facing: "front",
maxWidth: 640,
@@ -233,7 +233,7 @@ describe("cli program (nodes media)", () => {
nodeId: "ios-node",
command: "camera.clip",
timeoutMs: 90000,
idempotencyKey: "idem-test",
idempotencyKey: expect.any(String),
params: expect.objectContaining({
includeAudio: false,
deviceId: "cam-123",
@@ -310,7 +310,7 @@ describe("cli program (nodes media)", () => {
async () =>
new Response("url-content", {
status: 200,
headers: { "content-length": String("11") },
headers: { "content-length": "11" },
}),
) as unknown as typeof globalThis.fetch;
});