Refine tool access controls (#71405)

* feat(ui): refine tool access controls

* fix(ui): tighten tool access scanning

* fix(ui): keep tool access toggles visible (#71405)

* test(daemon): cover launchd restart fallback plist reads (#71405)

* test(daemon): drop duplicate launchd read mock (#71405)

---------

Co-authored-by: Peter Steinberger <steipete@gmail.com>
This commit is contained in:
Val Alexander
2026-04-25 01:22:53 -05:00
committed by GitHub
parent d7fae7a5e7
commit 982230f460
7 changed files with 1263 additions and 167 deletions

View File

@@ -753,6 +753,96 @@
stroke-linejoin: round;
}
.chat-controls {
display: inline-flex;
align-items: center;
gap: 8px;
position: relative;
overflow: visible;
}
.chat-controls__separator {
color: var(--muted);
font-size: 12px;
line-height: 1;
user-select: none;
}
.chat-controls .btn--icon[data-tooltip] {
position: relative;
overflow: visible;
}
.chat-controls .btn--icon[data-tooltip]::before,
.chat-controls .btn--icon[data-tooltip]::after {
position: absolute;
left: 50%;
pointer-events: none;
opacity: 0;
transition:
opacity var(--duration-fast) var(--ease-out),
transform var(--duration-fast) var(--ease-out);
z-index: 40;
}
.chat-controls .btn--icon[data-tooltip]::before {
content: "";
top: calc(100% + 4px);
border-width: 6px;
border-style: solid;
border-color: transparent transparent color-mix(in srgb, var(--card) 94%, black 6%) transparent;
transform: translate(-50%, -3px);
}
.chat-controls .btn--icon[data-tooltip]::after {
content: attr(data-tooltip);
top: calc(100% + 10px);
min-width: max-content;
max-width: min(260px, 60vw);
padding: 7px 9px;
border: 1px solid color-mix(in srgb, var(--border-strong) 84%, transparent);
border-radius: var(--radius-md);
background: color-mix(in srgb, var(--card) 94%, black 6%);
box-shadow:
0 10px 28px rgba(0, 0, 0, 0.24),
0 0 0 1px rgba(255, 255, 255, 0.04);
color: var(--text);
font-size: 11px;
font-weight: 500;
line-height: 1.35;
text-align: center;
white-space: normal;
transform: translate(-50%, -4px);
}
@media (hover: hover) {
.chat-controls .btn--icon[data-tooltip]:hover::before,
.chat-controls .btn--icon[data-tooltip]:hover::after {
opacity: 1;
}
.chat-controls .btn--icon[data-tooltip]:hover::before {
transform: translate(-50%, 0);
}
.chat-controls .btn--icon[data-tooltip]:hover::after {
transform: translate(-50%, 0);
}
}
.chat-controls .btn--icon[data-tooltip]:focus-visible::before,
.chat-controls .btn--icon[data-tooltip]:focus-visible::after {
opacity: 1;
}
.chat-controls .btn--icon[data-tooltip]:focus-visible::before {
transform: translate(-50%, 0);
}
.chat-controls .btn--icon[data-tooltip]:focus-visible::after {
transform: translate(-50%, 0);
}
.btn--ghost {
border-color: transparent;
background: transparent;
@@ -3691,62 +3781,483 @@ td.data-table-key-col {
}
}
.agent-tools-meta {
.agent-tools-header {
display: flex;
align-items: flex-start;
justify-content: space-between;
gap: 16px;
flex-wrap: wrap;
}
.agent-tools-header__intro {
min-width: 0;
}
.agent-tools-header__actions {
display: flex;
gap: 8px;
flex-wrap: wrap;
}
.agent-tools-overview {
display: grid;
gap: 16px;
grid-template-columns: minmax(0, 1.75fr) minmax(280px, 0.9fr);
align-items: start;
margin-top: 16px;
}
.agent-tools-overview__primary {
display: grid;
gap: 12px;
grid-template-columns: repeat(auto-fit, minmax(180px, 1fr));
}
.agent-tools-pane {
display: grid;
gap: 10px;
min-width: 0;
}
.agent-tools-facts {
display: grid;
gap: 10px;
grid-template-columns: repeat(2, minmax(0, 1fr));
align-content: start;
}
.agent-tools-fact {
min-width: 0;
padding: 10px 12px;
border: 1px solid var(--border);
border-radius: var(--radius-md);
background: color-mix(in srgb, var(--bg-elevated) 92%, transparent);
}
.agent-tools-buttons {
display: flex;
gap: 8px;
flex-wrap: wrap;
margin-top: 8px;
}
.agent-tools-grid {
display: grid;
gap: 16px;
margin-top: 20px;
}
.agent-tools-section {
.agent-tools-runtime {
display: flex;
flex-wrap: wrap;
gap: 8px;
}
.agent-tools-runtime-chip {
display: inline-flex;
align-items: center;
gap: 8px;
min-width: 0;
max-width: 100%;
padding: 7px 10px;
border: 1px solid var(--border);
border-radius: var(--radius-md);
padding: 10px;
background: var(--bg-elevated);
border-radius: var(--radius-full);
background: color-mix(in srgb, var(--card) 86%, transparent);
color: inherit;
text-decoration: none;
transition:
background-color var(--duration-fast) var(--ease-in-out),
border-color var(--duration-fast) var(--ease-in-out),
color var(--duration-fast) var(--ease-in-out);
touch-action: manipulation;
}
.agent-tools-header {
.agent-tools-runtime-chip:hover {
background: color-mix(in srgb, var(--card) 92%, transparent);
border-color: color-mix(in srgb, var(--border-strong) 58%, var(--border));
}
.agent-tools-runtime-chip:focus-visible {
outline: none;
box-shadow: var(--focus-ring);
}
.agent-tools-runtime-chip--more {
color: var(--muted);
cursor: default;
background: color-mix(in srgb, var(--bg-elevated) 84%, transparent);
}
.agent-tools-runtime-chip--more:hover {
background: color-mix(in srgb, var(--bg-elevated) 88%, transparent);
border-color: var(--border);
}
.agent-tools-runtime-chip__meta {
color: var(--muted);
font-size: 11px;
white-space: nowrap;
}
.agent-tools-group {
border: 1px solid var(--border);
border-radius: var(--radius-lg);
background: var(--bg-elevated);
overflow: hidden;
}
.agent-tools-group summary::-webkit-details-marker,
.agent-tool-summary::-webkit-details-marker {
display: none;
}
.agent-tools-group summary::marker,
.agent-tool-summary::marker {
content: "";
}
.agent-tools-group__summary {
display: flex;
align-items: flex-start;
gap: 12px;
justify-content: space-between;
padding: 12px 14px;
cursor: pointer;
list-style: none;
transition:
background-color var(--duration-fast) var(--ease-in-out),
color var(--duration-fast) var(--ease-in-out);
touch-action: manipulation;
}
.agent-tools-group__summary::before {
content: "▸";
color: var(--muted);
font-size: 11px;
line-height: 20px;
transition: transform var(--duration-fast) var(--ease-in-out);
}
.agent-tools-group[open] .agent-tools-group__summary::before {
transform: rotate(90deg);
}
.agent-tools-group__summary:hover {
background: color-mix(in srgb, var(--bg-elevated) 96%, var(--text) 4%);
}
.agent-tools-group__summary:hover::before {
color: color-mix(in srgb, var(--text) 78%, var(--muted));
}
.agent-tools-group__summary:focus-visible {
outline: none;
box-shadow: inset var(--focus-ring);
}
.agent-tools-group__title {
display: flex;
align-items: center;
gap: 8px;
min-width: 0;
font-weight: 600;
margin-bottom: 10px;
}
.agent-tools-group__summary-main {
display: grid;
gap: 6px;
min-width: 0;
flex: 1;
}
.agent-tools-group__preview {
display: flex;
gap: 6px;
flex-wrap: wrap;
min-width: 0;
color: var(--muted);
font-size: 11px;
}
.agent-tools-group__preview > span {
min-width: 0;
max-width: min(180px, 100%);
padding: 2px 6px;
border: 1px solid color-mix(in srgb, var(--border) 74%, transparent);
border-radius: var(--radius-full);
background: color-mix(in srgb, var(--card) 70%, transparent);
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
}
.agent-tools-group__counts {
display: flex;
align-items: center;
justify-content: flex-end;
gap: 8px;
flex-wrap: wrap;
color: var(--muted);
font-size: 11px;
font-variant-numeric: tabular-nums;
text-transform: uppercase;
letter-spacing: 0.04em;
}
.agent-tools-group__counts > span {
white-space: nowrap;
}
.agent-tools-list {
display: grid;
gap: 8px 12px;
grid-template-columns: repeat(auto-fit, minmax(220px, 1fr));
gap: 10px;
padding: 0 12px 12px;
}
.agent-tool-row {
display: flex;
justify-content: space-between;
align-items: center;
gap: 12px;
padding: 6px 8px;
.agent-tools-list--stacked {
grid-template-columns: 1fr;
}
.agent-tool-card {
position: relative;
border: 1px solid var(--border);
border-radius: var(--radius-md);
background: var(--card);
overflow: hidden;
scroll-margin-top: 16px;
}
.agent-tool-card[open] {
border-color: color-mix(in srgb, var(--accent) 22%, var(--border));
box-shadow: 0 0 0 1px color-mix(in srgb, var(--accent) 10%, transparent);
}
.agent-tool-summary {
position: relative;
display: grid;
grid-template-columns: minmax(0, 1.7fr) minmax(220px, 0.9fr) auto;
gap: 12px 16px;
align-items: center;
min-width: 0;
padding: 12px 92px 12px 12px;
cursor: pointer;
list-style: none;
transition:
background-color var(--duration-fast) var(--ease-in-out),
color var(--duration-fast) var(--ease-in-out);
touch-action: manipulation;
}
.agent-tool-summary::after {
content: "▸";
position: absolute;
top: 18px;
right: 64px;
color: var(--muted);
font-size: 11px;
transition: transform var(--duration-fast) var(--ease-in-out);
}
.agent-tool-card[open] .agent-tool-summary::after {
transform: rotate(90deg);
}
.agent-tool-summary:hover {
background: color-mix(in srgb, var(--card) 97%, var(--text) 3%);
}
.agent-tool-summary:hover::after {
color: color-mix(in srgb, var(--text) 78%, var(--muted));
}
.agent-tool-summary:focus-visible {
outline: none;
box-shadow: inset var(--focus-ring);
}
.agent-tool-summary__main {
min-width: 0;
}
.agent-tool-summary__title-row {
display: flex;
align-items: center;
gap: 8px;
min-width: 0;
}
.agent-tool-summary__badges {
min-width: 0;
}
.agent-tool-summary__badges .agent-tool-badges {
margin-top: 0;
justify-content: flex-end;
}
.agent-tool-summary__facts {
display: grid;
gap: 8px 12px;
grid-template-columns: repeat(2, minmax(0, 1fr));
margin: 0;
min-width: 0;
}
.agent-tool-summary__fact {
min-width: 0;
}
.agent-tool-summary__fact dd {
margin: 2px 0 0;
font-size: 12px;
}
.agent-tool-toggle {
position: absolute;
top: 12px;
right: 12px;
margin: 0;
z-index: 1;
}
.agent-tool-badges {
display: flex;
gap: 6px;
flex-wrap: wrap;
margin-top: 8px;
}
.agent-tool-title {
font-weight: 600;
font-size: 13px;
min-width: 0;
max-width: 100%;
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
}
.agent-tool-sub {
color: var(--muted);
font-size: 11px;
margin-top: 2px;
margin-top: 3px;
min-width: 0;
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
}
.agent-tool-details {
padding: 0 12px 12px;
border-top: 1px solid color-mix(in srgb, var(--border) 72%, transparent);
}
.agent-tool-card:not([open]) .agent-tool-details {
display: none;
}
.agent-tool-details-strip {
display: flex;
flex-wrap: wrap;
gap: 10px 20px;
align-items: flex-start;
padding-top: 10px;
}
.agent-tool-detail {
min-width: 0;
}
.agent-tool-detail--inline {
max-width: min(100%, 260px);
}
.agent-tool-detail .label {
margin-bottom: 4px;
}
.agent-tool-card[open] .agent-tool-sub {
overflow: visible;
text-overflow: clip;
white-space: normal;
}
.agent-tool-jump {
color: var(--accent);
text-decoration: none;
align-self: end;
margin-left: auto;
}
.agent-tool-jump:hover {
color: var(--accent-hover);
text-decoration: underline;
}
.agent-tool-jump:focus-visible {
outline: none;
box-shadow: var(--focus-ring);
border-radius: var(--radius-sm);
}
@media (prefers-reduced-motion: reduce) {
.agent-tools-runtime-chip,
.agent-tools-group__summary,
.agent-tool-summary,
.agent-tools-group__summary::before,
.agent-tool-summary::after {
transition: none;
}
}
@media (max-width: 1180px) {
.agent-tools-overview {
grid-template-columns: 1fr;
}
.agent-tools-facts {
grid-template-columns: repeat(auto-fit, minmax(160px, 1fr));
}
.agent-tool-summary {
grid-template-columns: minmax(0, 1fr) auto;
}
.agent-tool-summary__facts {
grid-column: 1 / -1;
}
.agent-tool-summary__badges .agent-tool-badges {
justify-content: flex-start;
}
}
@media (max-width: 760px) {
.agent-tools-group__summary {
flex-wrap: wrap;
align-items: flex-start;
}
.agent-tools-group__summary::before {
line-height: 18px;
}
.agent-tools-group__counts {
justify-content: flex-start;
width: 100%;
padding-left: 24px;
}
.agent-tool-summary {
grid-template-columns: 1fr;
padding-right: 92px;
}
.agent-tool-summary__facts {
grid-template-columns: 1fr;
}
.agent-tool-jump {
margin-left: 0;
}
}
.agent-skills-groups {

View File

@@ -1024,6 +1024,7 @@
justify-content: space-between;
gap: 16px;
padding-bottom: 0;
overflow: visible;
}
.content--chat .content-header > div:first-child {
@@ -1032,6 +1033,7 @@
.content--chat .page-meta {
justify-content: flex-start;
overflow: visible;
}
.content--chat .chat-controls {