From 9a1761d80c7b7fb286b1a9b86e60971712f0559c Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Sun, 19 Apr 2026 02:09:17 +0100
Subject: [PATCH] test: share approval session target fixture

---
 .../exec-approval-session-target.test.ts      | 48 +++++++++----------
 1 file changed, 22 insertions(+), 26 deletions(-)

diff --git a/src/infra/exec-approval-session-target.test.ts b/src/infra/exec-approval-session-target.test.ts
index 57c13a3f177..352b814ebbf 100644
--- a/src/infra/exec-approval-session-target.test.ts
+++ b/src/infra/exec-approval-session-target.test.ts
@@ -107,6 +107,24 @@ function buildPluginRequest(
   };
 }
 
+function resolveSlackPluginOriginTarget(params: { cfg: OpenClawConfig; turnSourceTo: string }) {
+  return resolveApprovalRequestOriginTarget({
+    cfg: params.cfg,
+    request: buildPluginRequest({
+      turnSourceChannel: "slack",
+      turnSourceTo: params.turnSourceTo,
+    }),
+    channel: "slack",
+    accountId: "default",
+    resolveTurnSourceTarget: (request) =>
+      request.request.turnSourceChannel === "slack" && request.request.turnSourceTo
+        ? { to: request.request.turnSourceTo }
+        : null,
+    resolveSessionTarget: (sessionTarget) => ({ to: sessionTarget.to }),
+    targetsMatch: (a, b) => a.to === b.to,
+  });
+}
+
 describe("exec approval session target", () => {
   type PlaceholderStoreCase = {
     name: string;
@@ -426,20 +444,9 @@ describe("exec approval session target", () => {
         },
       });
 
-      const target = resolveApprovalRequestOriginTarget({
+      const target = resolveSlackPluginOriginTarget({
         cfg,
-        request: buildPluginRequest({
-          turnSourceChannel: "slack",
-          turnSourceTo: "channel:C123",
-        }),
-        channel: "slack",
-        accountId: "default",
-        resolveTurnSourceTarget: (request) =>
-          request.request.turnSourceChannel === "slack" && request.request.turnSourceTo
-            ? { to: request.request.turnSourceTo }
-            : null,
-        resolveSessionTarget: (sessionTarget) => ({ to: sessionTarget.to }),
-        targetsMatch: (a, b) => a.to === b.to,
+        turnSourceTo: "channel:C123",
       });
 
       expect(target).toEqual({ to: "channel:C123" });
@@ -458,20 +465,9 @@ describe("exec approval session target", () => {
         },
       });
 
-      const target = resolveApprovalRequestOriginTarget({
+      const target = resolveSlackPluginOriginTarget({
         cfg,
-        request: buildPluginRequest({
-          turnSourceChannel: "slack",
-          turnSourceTo: "channel:C999",
-        }),
-        channel: "slack",
-        accountId: "default",
-        resolveTurnSourceTarget: (request) =>
-          request.request.turnSourceChannel === "slack" && request.request.turnSourceTo
-            ? { to: request.request.turnSourceTo }
-            : null,
-        resolveSessionTarget: (sessionTarget) => ({ to: sessionTarget.to }),
-        targetsMatch: (a, b) => a.to === b.to,
+        turnSourceTo: "channel:C999",
       });
 
       expect(target).toBeNull();