From a0dd3ac65c1981d2c5be6d95be64c5126e0f3ec6 Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Fri, 8 May 2026 21:40:05 +0100 Subject: [PATCH] test: avoid messaging filter allocation assertions --- extensions/discord/src/channel.test.ts | 2 +- extensions/matrix/src/resolve-targets.test.ts | 4 ++-- extensions/msteams/src/attachments.test.ts | 2 +- extensions/telegram/src/bot.command-menu.test.ts | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/extensions/discord/src/channel.test.ts b/extensions/discord/src/channel.test.ts index d08bffa8bc8..7401cebb298 100644 --- a/extensions/discord/src/channel.test.ts +++ b/extensions/discord/src/channel.test.ts @@ -503,7 +503,7 @@ describe("discordPlugin outbound", () => { includeApplication: true, }), ); - expect(statusPatches.filter((patch) => "bot" in patch || "application" in patch)).toEqual([]); + expect(statusPatches.some((patch) => "bot" in patch || "application" in patch)).toBe(false); if (!resolveProbe) { throw new Error("Expected Discord startup probe resolver to be initialized"); diff --git a/extensions/matrix/src/resolve-targets.test.ts b/extensions/matrix/src/resolve-targets.test.ts index ca28393fd1e..6db1ed613c1 100644 --- a/extensions/matrix/src/resolve-targets.test.ts +++ b/extensions/matrix/src/resolve-targets.test.ts @@ -140,8 +140,8 @@ describe("resolveMatrixTargets (users)", () => { kind: "group", }); - expect(userResults.filter((entry) => !entry.resolved)).toEqual([]); - expect(groupResults.filter((entry) => !entry.resolved)).toEqual([]); + expect(userResults.every((entry) => entry.resolved)).toBe(true); + expect(groupResults.every((entry) => entry.resolved)).toBe(true); expect(listMatrixDirectoryPeersLive).toHaveBeenCalledTimes(1); expect(listMatrixDirectoryGroupsLive).toHaveBeenCalledTimes(1); }); diff --git a/extensions/msteams/src/attachments.test.ts b/extensions/msteams/src/attachments.test.ts index 66ace547990..308895a744f 100644 --- a/extensions/msteams/src/attachments.test.ts +++ b/extensions/msteams/src/attachments.test.ts @@ -639,7 +639,7 @@ describe("msteams attachments", () => { }); // Should have hit the original host, NOT graph shares. expect(calledUrls).toContain(directUrl); - expect(calledUrls.filter((url) => url.startsWith(GRAPH_SHARES_URL_PREFIX))).toEqual([]); + expect(calledUrls.some((url) => url.startsWith(GRAPH_SHARES_URL_PREFIX))).toBe(false); }); }); diff --git a/extensions/telegram/src/bot.command-menu.test.ts b/extensions/telegram/src/bot.command-menu.test.ts index b19c3de45fc..288c38b302b 100644 --- a/extensions/telegram/src/bot.command-menu.test.ts +++ b/extensions/telegram/src/bot.command-menu.test.ts @@ -214,6 +214,6 @@ describe("createTelegramBot command menu", () => { { command: "custom_generate", description: "Create an image" }, ]); const reserved = new Set(listNativeCommandSpecs().map((command) => command.name)); - expect(registered.filter((command) => reserved.has(command.command))).toEqual([]); + expect(registered.some((command) => reserved.has(command.command))).toBe(false); }); });