From a1d4eb255acf8ce874c0a8e7e42af3757b60b4e4 Mon Sep 17 00:00:00 2001 From: Ayaan Zaidi Date: Wed, 15 Apr 2026 12:14:44 +0530 Subject: [PATCH] fix(inventory): omit qa-matrix dist artifacts --- src/infra/npm-update-compat-sidecars.ts | 2 +- src/infra/package-dist-inventory.test.ts | 9 +++++++++ src/infra/package-dist-inventory.ts | 10 ++++++---- test/scripts/build-all.test.ts | 1 + 4 files changed, 17 insertions(+), 5 deletions(-) diff --git a/src/infra/npm-update-compat-sidecars.ts b/src/infra/npm-update-compat-sidecars.ts index 8eac30d3f1b..3db8bfa1ca8 100644 --- a/src/infra/npm-update-compat-sidecars.ts +++ b/src/infra/npm-update-compat-sidecars.ts @@ -11,6 +11,6 @@ export const NPM_UPDATE_COMPAT_SIDECARS = [ }, ] as const; -export const NPM_UPDATE_COMPAT_SIDECAR_PATHS = new Set( +export const NPM_UPDATE_COMPAT_SIDECAR_PATHS = new Set( NPM_UPDATE_COMPAT_SIDECARS.map((entry) => entry.path), ); diff --git a/src/infra/package-dist-inventory.test.ts b/src/infra/package-dist-inventory.test.ts index b8d564bc249..081ba1f2656 100644 --- a/src/infra/package-dist-inventory.test.ts +++ b/src/infra/package-dist-inventory.test.ts @@ -45,10 +45,19 @@ describe("package dist inventory", () => { "runtime-api.js", ); const omittedQaChunk = path.join(packageRoot, "dist", "extensions", "qa-channel", "cli.js"); + const omittedQaMatrixChunk = path.join( + packageRoot, + "dist", + "extensions", + "qa-matrix", + "index.js", + ); const omittedMap = path.join(packageRoot, "dist", "feature.runtime.js.map"); await fs.mkdir(path.dirname(packagedQaRuntime), { recursive: true }); + await fs.mkdir(path.dirname(omittedQaMatrixChunk), { recursive: true }); await fs.writeFile(packagedQaRuntime, "export {};\n", "utf8"); await fs.writeFile(omittedQaChunk, "export {};\n", "utf8"); + await fs.writeFile(omittedQaMatrixChunk, "export {};\n", "utf8"); await fs.writeFile(omittedMap, "{}", "utf8"); await expect(writePackageDistInventory(packageRoot)).resolves.toEqual([ diff --git a/src/infra/package-dist-inventory.ts b/src/infra/package-dist-inventory.ts index ba52a0b4d7f..2ccfecc81f1 100644 --- a/src/infra/package-dist-inventory.ts +++ b/src/infra/package-dist-inventory.ts @@ -6,6 +6,11 @@ const PACKAGED_QA_RUNTIME_PATHS = new Set([ "dist/extensions/qa-channel/runtime-api.js", "dist/extensions/qa-lab/runtime-api.js", ]); +const OMITTED_QA_EXTENSION_PREFIXES = [ + "dist/extensions/qa-channel/", + "dist/extensions/qa-lab/", + "dist/extensions/qa-matrix/", +]; function normalizeRelativePath(value: string): string { return value.replace(/\\/g, "/"); @@ -24,10 +29,7 @@ function isPackagedDistPath(relativePath: string): boolean { if (relativePath === "dist/plugin-sdk/.tsbuildinfo") { return false; } - if ( - relativePath.startsWith("dist/extensions/qa-channel/") || - relativePath.startsWith("dist/extensions/qa-lab/") - ) { + if (OMITTED_QA_EXTENSION_PREFIXES.some((prefix) => relativePath.startsWith(prefix))) { return PACKAGED_QA_RUNTIME_PATHS.has(relativePath); } return true; diff --git a/test/scripts/build-all.test.ts b/test/scripts/build-all.test.ts index 640ca934782..0ba92b5129c 100644 --- a/test/scripts/build-all.test.ts +++ b/test/scripts/build-all.test.ts @@ -87,6 +87,7 @@ describe("resolveBuildAllSteps", () => { "canvas:a2ui:bundle", "tsdown", "runtime-postbuild", + "write-npm-update-compat-sidecars", "build-stamp", "canvas-a2ui-copy", "copy-hook-metadata",