From a8c67affd8b3aec80bc98ef9c796b0e208eef24c Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Sun, 8 Mar 2026 02:34:43 +0000 Subject: [PATCH] test: cover gemini flash compat normalization --- docs/concepts/model-providers.md | 3 +- src/agents/model-selection.test.ts | 11 ++++++ ...ini-3-ids-preview-google-providers.test.ts | 36 +++++++++++++++++++ 3 files changed, 49 insertions(+), 1 deletion(-) diff --git a/docs/concepts/model-providers.md b/docs/concepts/model-providers.md index 75333b014b0..dec03850189 100644 --- a/docs/concepts/model-providers.md +++ b/docs/concepts/model-providers.md @@ -104,7 +104,8 @@ OpenClaw ships with the pi‑ai catalog. These providers require **no** - Provider: `google` - Auth: `GEMINI_API_KEY` - Optional rotation: `GEMINI_API_KEYS`, `GEMINI_API_KEY_1`, `GEMINI_API_KEY_2`, `GOOGLE_API_KEY` fallback, and `OPENCLAW_LIVE_GEMINI_KEY` (single override) -- Example model: `google/gemini-3.1-pro-preview` +- Example models: `google/gemini-3.1-pro-preview`, `google/gemini-3-flash-preview` +- Compatibility: legacy OpenClaw config using `google/gemini-3.1-flash-preview` is normalized to `google/gemini-3-flash-preview` - CLI: `openclaw onboard --auth-choice gemini-api-key` ### Google Vertex, Antigravity, and Gemini CLI diff --git a/src/agents/model-selection.test.ts b/src/agents/model-selection.test.ts index ab3a421ca1b..08ae7f1c7e2 100644 --- a/src/agents/model-selection.test.ts +++ b/src/agents/model-selection.test.ts @@ -114,6 +114,17 @@ describe("model-selection", () => { }); }); + it("normalizes deprecated google flash preview ids to the working model id", () => { + expect(parseModelRef("google/gemini-3.1-flash-preview", "openai")).toEqual({ + provider: "google", + model: "gemini-3-flash-preview", + }); + expect(parseModelRef("gemini-3.1-flash-preview", "google")).toEqual({ + provider: "google", + model: "gemini-3-flash-preview", + }); + }); + it("keeps openai gpt-5.3 codex refs on the openai provider", () => { expect(parseModelRef("openai/gpt-5.3-codex", "anthropic")).toEqual({ provider: "openai", diff --git a/src/agents/models-config.normalizes-gemini-3-ids-preview-google-providers.test.ts b/src/agents/models-config.normalizes-gemini-3-ids-preview-google-providers.test.ts index 2874209d9c2..8414fb10d08 100644 --- a/src/agents/models-config.normalizes-gemini-3-ids-preview-google-providers.test.ts +++ b/src/agents/models-config.normalizes-gemini-3-ids-preview-google-providers.test.ts @@ -52,4 +52,40 @@ describe("models-config", () => { expect(ids).toEqual(["gemini-3-pro-preview", "gemini-3-flash-preview"]); }); }); + + it("normalizes the deprecated google flash preview id to the working preview id", async () => { + await withModelsTempHome(async () => { + const cfg: OpenClawConfig = { + models: { + providers: { + google: { + baseUrl: "https://generativelanguage.googleapis.com/v1beta", + apiKey: "GEMINI_KEY", // pragma: allowlist secret + api: "google-generative-ai", + models: [ + { + id: "gemini-3.1-flash-preview", + name: "Gemini 3.1 Flash Preview", + api: "google-generative-ai", + reasoning: false, + input: ["text", "image"], + cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0 }, + contextWindow: 1048576, + maxTokens: 65536, + }, + ], + }, + }, + }, + }; + + await ensureOpenClawModelsJson(cfg); + + const parsed = await readGeneratedModelsJson<{ + providers: Record }>; + }>(); + const ids = parsed.providers.google?.models?.map((model) => model.id); + expect(ids).toEqual(["gemini-3-flash-preview"]); + }); + }); });