From a8dcbb26f89ee513301a3ec8b7875745714e96bd Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Fri, 8 May 2026 09:17:15 +0100
Subject: [PATCH] test: clarify security audit assertions

---
 src/security/audit-config-symlink.test.ts    | 12 ++++++------
 src/security/audit-gateway-http-auth.test.ts |  2 +-
 src/security/audit-model-hygiene.test.ts     |  2 +-
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/security/audit-config-symlink.test.ts b/src/security/audit-config-symlink.test.ts
index e922b87ce85..3f377cc9acb 100644
--- a/src/security/audit-config-symlink.test.ts
+++ b/src/security/audit-config-symlink.test.ts
@@ -41,12 +41,12 @@ describe("security audit config symlink findings", () => {
     expect(findings).toEqual(
       expect.arrayContaining([expect.objectContaining({ checkId: "fs.config.symlink" })]),
     );
-    expect(findings.some((finding) => finding.checkId === "fs.config.perms_writable")).toBe(false);
-    expect(findings.some((finding) => finding.checkId === "fs.config.perms_world_readable")).toBe(
-      false,
-    );
-    expect(findings.some((finding) => finding.checkId === "fs.config.perms_group_readable")).toBe(
-      false,
+    expect(findings.map((finding) => finding.checkId)).not.toEqual(
+      expect.arrayContaining([
+        "fs.config.perms_writable",
+        "fs.config.perms_world_readable",
+        "fs.config.perms_group_readable",
+      ]),
     );
   });
 });
diff --git a/src/security/audit-gateway-http-auth.test.ts b/src/security/audit-gateway-http-auth.test.ts
index d4de3ec18b6..9b502cd4e54 100644
--- a/src/security/audit-gateway-http-auth.test.ts
+++ b/src/security/audit-gateway-http-auth.test.ts
@@ -82,7 +82,7 @@ describe("security audit gateway HTTP auth findings", () => {
       }
     }
     if (expectedNoFinding) {
-      expect(findings.some((entry) => entry.checkId === expectedNoFinding)).toBe(false);
+      expect(findings.map((entry) => entry.checkId)).not.toContain(expectedNoFinding);
     }
   });
 });
diff --git a/src/security/audit-model-hygiene.test.ts b/src/security/audit-model-hygiene.test.ts
index 6ceb7f31ddf..fc67db3d768 100644
--- a/src/security/audit-model-hygiene.test.ts
+++ b/src/security/audit-model-hygiene.test.ts
@@ -70,6 +70,6 @@ describe("security audit model hygiene findings", () => {
       },
     } satisfies OpenClawConfig);
 
-    expect(findings.some((finding) => finding.checkId === "models.weak_tier")).toBe(false);
+    expect(findings.map((finding) => finding.checkId)).not.toContain("models.weak_tier");
   });
 });