vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-04-11 09:11:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(pairing): align mobile setup with secure endpoints

Browse Source
This commit is contained in:
Ayaan Zaidi
2026-04-03 12:55:11 +05:30
parent c6f95a0c37
commit acd5734aa9
18 changed files with 412 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files

75
src/pairing/setup-code.test.ts
View File

@@ -43,7 +43,7 @@ describe("pairing setup code", () => {
...config,
gateway: {
bind: "custom",
customBindHost: "gateway.local",
customBindHost: "127.0.0.1",
auth,
},
};
@@ -57,6 +57,23 @@ describe("pairing setup code", () => {
}));
}
function createIpv4NetworkInterfaces(
address: string,
): ReturnType<NonNullable<NonNullable<ResolveSetupOptions>["networkInterfaces"]>> {
return {
en0: [
{
address,
family: "IPv4",
internal: false,
netmask: "255.255.255.0",
mac: "00:00:00:00:00:00",
cidr: `${address}/24`,
},
],
};
}
function expectResolvedSetupOk(
resolved: ResolvedSetup,
params: {
@@ -279,7 +296,7 @@ describe("pairing setup code", () => {
{
gateway: {
bind: "custom",
customBindHost: "gateway.local",
customBindHost: "127.0.0.1",
auth: { token },
},
...defaultEnvSecretProviderConfig,
@@ -351,14 +368,14 @@ describe("pairing setup code", () => {
config: {
gateway: {
bind: "custom",
customBindHost: "gateway.local",
customBindHost: "127.0.0.1",
port: 19001,
auth: { mode: "token", token: "tok_123" },
},
} satisfies ResolveSetupConfig,
expected: {
authLabel: "token",
url: "ws://gateway.local:19001",
url: "ws://127.0.0.1:19001",
urlSource: "gateway.bind=custom",
},
},
@@ -367,7 +384,7 @@ describe("pairing setup code", () => {
config: {
gateway: {
bind: "custom",
customBindHost: "gateway.local",
customBindHost: "127.0.0.1",
auth: { mode: "token", token: "old" },
},
} satisfies ResolveSetupConfig,
@@ -378,7 +395,7 @@ describe("pairing setup code", () => {
} satisfies ResolveSetupOptions,
expected: {
authLabel: "token",
url: "ws://gateway.local:18789",
url: "ws://127.0.0.1:18789",
urlSource: "gateway.bind=custom",
},
},
@@ -390,6 +407,52 @@ describe("pairing setup code", () => {
});
});
it.each([
{
name: "rejects custom bind remote ws setup urls for mobile pairing",
config: {
gateway: {
bind: "custom",
customBindHost: "gateway.local",
auth: { mode: "token", token: "tok_123" },
},
} satisfies ResolveSetupConfig,
expectedError: "Mobile pairing requires a secure remote gateway URL",
},
{
name: "rejects tailnet bind remote ws setup urls for mobile pairing",
config: {
gateway: {
bind: "tailnet",
auth: { mode: "token", token: "tok_123" },
},
} satisfies ResolveSetupConfig,
options: {
networkInterfaces: () => createIpv4NetworkInterfaces("100.64.0.9"),
} satisfies ResolveSetupOptions,
expectedError: "prefer gateway.tailscale.mode=serve",
},
{
name: "rejects lan bind remote ws setup urls for mobile pairing",
config: {
gateway: {
bind: "lan",
auth: { mode: "password", password: "secret" },
},
} satisfies ResolveSetupConfig,
options: {
networkInterfaces: () => createIpv4NetworkInterfaces("192.168.1.20"),
} satisfies ResolveSetupOptions,
expectedError: "ws:// is only valid for localhost",
},
] as const)("$name", async ({ config, options, expectedError }) => {
await expectResolvedSetupFailureCase({
config,
options,
expectedError,
});
});
it.each([
{
name: "errors when gateway is loopback only",