From ad1e14af532fe221a8db44da768bc774973d2705 Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Fri, 1 May 2026 13:11:34 +0100 Subject: [PATCH] refactor: delete unused test helper code --- .../whatsapp/src/outbound-test-support.ts | 27 ----------- .../pi-embedded-runner/model.test-harness.ts | 46 ------------------- .../attempt.spawn-workspace.test-support.ts | 8 ---- src/agents/sandbox/fs-bridge.test-helpers.ts | 4 -- .../server-methods/chat.test-helpers.ts | 17 ------- src/process/test-timeouts.ts | 20 -------- 6 files changed, 122 deletions(-) delete mode 100644 src/process/test-timeouts.ts diff --git a/extensions/whatsapp/src/outbound-test-support.ts b/extensions/whatsapp/src/outbound-test-support.ts index 56d6979cdc9..5c4e806312d 100644 --- a/extensions/whatsapp/src/outbound-test-support.ts +++ b/extensions/whatsapp/src/outbound-test-support.ts @@ -1,5 +1,4 @@ import type { OpenClawConfig } from "openclaw/plugin-sdk/config-types"; -import type { MockInstance } from "vitest"; export function createWhatsAppPollFixture() { const cfg = { marker: "resolved-cfg" } as OpenClawConfig; @@ -15,29 +14,3 @@ export function createWhatsAppPollFixture() { accountId: "work", }; } - -export function expectWhatsAppPollSent( - sendPollWhatsApp: MockInstance, - params: { - cfg: OpenClawConfig; - poll: { question: string; options: string[]; maxSelections: number }; - to?: string; - accountId?: string; - }, -) { - const expected = [ - params.to ?? "+1555", - params.poll, - { - verbose: false, - accountId: params.accountId ?? "work", - cfg: params.cfg, - }, - ]; - const actual = sendPollWhatsApp.mock.calls.at(-1); - if (JSON.stringify(actual) !== JSON.stringify(expected)) { - throw new Error( - `Expected WhatsApp poll send ${JSON.stringify(expected)}, got ${JSON.stringify(actual)}`, - ); - } -} diff --git a/src/agents/pi-embedded-runner/model.test-harness.ts b/src/agents/pi-embedded-runner/model.test-harness.ts index e94cef1cf69..7beb9577529 100644 --- a/src/agents/pi-embedded-runner/model.test-harness.ts +++ b/src/agents/pi-embedded-runner/model.test-harness.ts @@ -87,52 +87,6 @@ export function buildOpenAICodexForwardCompatExpectation( }; } -const GOOGLE_GEMINI_CLI_PRO_TEMPLATE_MODEL = { - id: "gemini-3-pro-preview", - name: "Gemini 3 Pro Preview (Cloud Code Assist)", - provider: "google-gemini-cli", - api: "google-gemini-cli", - baseUrl: "https://cloudcode-pa.googleapis.com", - reasoning: true, - input: ["text", "image"] as const, - cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0 }, - contextWindow: 200000, - maxTokens: 64000, -}; - -const GOOGLE_GEMINI_CLI_FLASH_TEMPLATE_MODEL = { - id: "gemini-3-flash-preview", - name: "Gemini 3 Flash Preview (Cloud Code Assist)", - provider: "google-gemini-cli", - api: "google-gemini-cli", - baseUrl: "https://cloudcode-pa.googleapis.com", - reasoning: false, - input: ["text", "image"] as const, - cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0 }, - contextWindow: 200000, - maxTokens: 64000, -}; - -export function mockGoogleGeminiCliProTemplateModel(discoverModelsMock: DiscoverModelsMock): void { - mockTemplateModel( - discoverModelsMock, - "google-gemini-cli", - "gemini-3-pro-preview", - GOOGLE_GEMINI_CLI_PRO_TEMPLATE_MODEL, - ); -} - -export function mockGoogleGeminiCliFlashTemplateModel( - discoverModelsMock: DiscoverModelsMock, -): void { - mockTemplateModel( - discoverModelsMock, - "google-gemini-cli", - "gemini-3-flash-preview", - GOOGLE_GEMINI_CLI_FLASH_TEMPLATE_MODEL, - ); -} - export function resetMockDiscoverModels(discoverModelsMock: DiscoverModelsMock): void { vi.mocked(discoverModelsMock).mockReturnValue({ find: vi.fn(() => null), diff --git a/src/agents/pi-embedded-runner/run/attempt.spawn-workspace.test-support.ts b/src/agents/pi-embedded-runner/run/attempt.spawn-workspace.test-support.ts index 0628f84ab03..f79a2ea6b51 100644 --- a/src/agents/pi-embedded-runner/run/attempt.spawn-workspace.test-support.ts +++ b/src/agents/pi-embedded-runner/run/attempt.spawn-workspace.test-support.ts @@ -877,14 +877,6 @@ export const testModel = { input: ["text"], } as unknown as Model; -export const cacheTtlEligibleModel = { - api: "anthropic", - provider: "anthropic", - compat: {}, - contextWindow: 8192, - input: ["text"], -} as unknown as Model; - const testAuthStorage = { getApiKey: async () => undefined, }; diff --git a/src/agents/sandbox/fs-bridge.test-helpers.ts b/src/agents/sandbox/fs-bridge.test-helpers.ts index 6de9e890301..dfef0f6b762 100644 --- a/src/agents/sandbox/fs-bridge.test-helpers.ts +++ b/src/agents/sandbox/fs-bridge.test-helpers.ts @@ -86,10 +86,6 @@ export function getDockerArg(args: string[], position: number): string { return args[DOCKER_FIRST_SCRIPT_ARG_INDEX + position - 1] ?? ""; } -export function getDockerPathArg(args: string[]): string { - return getDockerArg(args, 1); -} - export function getScriptsFromCalls(): string[] { return mockedExecDockerRaw.mock.calls.map(([args]) => getDockerScript(args)); } diff --git a/src/gateway/server-methods/chat.test-helpers.ts b/src/gateway/server-methods/chat.test-helpers.ts index c8a772dbf13..602a732ce34 100644 --- a/src/gateway/server-methods/chat.test-helpers.ts +++ b/src/gateway/server-methods/chat.test-helpers.ts @@ -23,20 +23,3 @@ export function createTranscriptFixtureSync(params: { ); return { dir, transcriptPath }; } - -export function createMockSessionEntry(params: { - transcriptPath: string; - sessionId: string; - canonicalKey?: string; - cfg?: Record; -}) { - return { - cfg: params.cfg ?? {}, - storePath: path.join(path.dirname(params.transcriptPath), "sessions.json"), - entry: { - sessionId: params.sessionId, - sessionFile: params.transcriptPath, - }, - canonicalKey: params.canonicalKey ?? "main", - }; -} diff --git a/src/process/test-timeouts.ts b/src/process/test-timeouts.ts deleted file mode 100644 index d1721d5bfcd..00000000000 --- a/src/process/test-timeouts.ts +++ /dev/null @@ -1,20 +0,0 @@ -export const PROCESS_TEST_TIMEOUT_MS = { - tiny: 25, - short: 100, - standard: 3_000, - medium: 5_000, - long: 10_000, - extraLong: 15_000, -} as const; - -export const PROCESS_TEST_SCRIPT_DELAY_MS = { - silentProcess: 120, - streamingInterval: 1_800, - streamingDuration: 9_000, -} as const; - -export const PROCESS_TEST_NO_OUTPUT_TIMEOUT_MS = { - exec: 120, - supervisor: 100, - streamingAllowance: 6_000, -} as const;