Agents: simplify inferred commitment config (#74189)

src/commitments/store.test.ts

@@ -0,0 +1,92 @@
+import fs from "node:fs/promises";
+import os from "node:os";
+import path from "node:path";
+import { afterEach, describe, expect, it, vi } from "vitest";
+import { listDueCommitmentsForSession, loadCommitmentStore, saveCommitmentStore } from "./store.js";
+import type { CommitmentRecord } from "./types.js";
+
+describe("commitment store delivery selection", () => {
+  const tmpDirs: string[] = [];
+  const nowMs = Date.parse("2026-04-29T17:00:00.000Z");
+  const sessionKey = "agent:main:telegram:user-155462274";
+
+  afterEach(async () => {
+    vi.unstubAllEnvs();
+    await Promise.all(tmpDirs.map((dir) => fs.rm(dir, { recursive: true, force: true })));
+    tmpDirs.length = 0;
+  });
+
+  async function useTempStateDir(): Promise<void> {
+    const tmpDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-commitments-store-"));
+    tmpDirs.push(tmpDir);
+    vi.stubEnv("OPENCLAW_STATE_DIR", tmpDir);
+  }
+
+  function commitment(overrides?: Partial<CommitmentRecord>): CommitmentRecord {
+    return {
+      id: "cm_interview",
+      agentId: "main",
+      sessionKey,
+      channel: "telegram",
+      to: "155462274",
+      kind: "event_check_in",
+      sensitivity: "routine",
+      source: "inferred_user_context",
+      status: "pending",
+      reason: "The user said they had an interview yesterday.",
+      suggestedText: "How did the interview go?",
+      dedupeKey: "interview:2026-04-28",
+      confidence: 0.92,
+      dueWindow: {
+        earliestMs: nowMs - 60_000,
+        latestMs: nowMs + 60 * 60_000,
+        timezone: "America/Los_Angeles",
+      },
+      sourceUserText: "I have an interview tomorrow.",
+      createdAtMs: nowMs - 24 * 60 * 60_000,
+      updatedAtMs: nowMs - 24 * 60 * 60_000,
+      attempts: 0,
+      ...overrides,
+    };
+  }
+
+  it("does not surface due commitments unless inferred commitments are enabled", async () => {
+    await useTempStateDir();
+    await saveCommitmentStore(undefined, {
+      version: 1,
+      commitments: [commitment()],
+    });
+
+    await expect(
+      listDueCommitmentsForSession({
+        cfg: {},
+        agentId: "main",
+        sessionKey,
+        nowMs,
+      }),
+    ).resolves.toEqual([]);
+  });
+
+  it("limits delivered commitments per agent session in a rolling day", async () => {
+    await useTempStateDir();
+    await saveCommitmentStore(undefined, {
+      version: 1,
+      commitments: [
+        commitment({ id: "cm_sent", status: "sent", sentAtMs: nowMs - 60_000 }),
+        commitment({ id: "cm_pending", dedupeKey: "interview:followup" }),
+      ],
+    });
+
+    await expect(
+      listDueCommitmentsForSession({
+        cfg: { commitments: { enabled: true, maxPerDay: 1 } },
+        agentId: "main",
+        sessionKey,
+        nowMs,
+      }),
+    ).resolves.toEqual([]);
+
+    const store = await loadCommitmentStore();
+    expect(store.commitments).toHaveLength(2);
+  });
+});