From af49c09d132092cc31e577d9f774110a0aa032e8 Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Fri, 8 May 2026 07:53:35 +0100
Subject: [PATCH] test: clarify kilocode model catalog assertions

---
 extensions/kilocode/provider-models.test.ts | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/extensions/kilocode/provider-models.test.ts b/extensions/kilocode/provider-models.test.ts
index 58de9b6f612..72c7f663f50 100644
--- a/extensions/kilocode/provider-models.test.ts
+++ b/extensions/kilocode/provider-models.test.ts
@@ -121,7 +121,7 @@ describe("discoverKilocodeModels", () => {
   it("returns static catalog in test environment", async () => {
     const models = await discoverKilocodeModels();
     expect(models.length).toBeGreaterThan(0);
-    expect(models.some((m) => m.id === "kilo/auto")).toBe(true);
+    expect(requireModelById(models, "kilo/auto").id).toBe("kilo/auto");
   });
 
   it("static catalog has correct defaults for kilo/auto", async () => {
@@ -185,7 +185,7 @@ describe("discoverKilocodeModels (fetch path)", () => {
     await withFetchPathTest(mockFetch, async () => {
       const models = await discoverKilocodeModels();
       expect(models.length).toBeGreaterThan(0);
-      expect(models.some((m) => m.id === "kilo/auto")).toBe(true);
+      expect(requireModelById(models, "kilo/auto").id).toBe("kilo/auto");
     });
   });
 
@@ -197,7 +197,7 @@ describe("discoverKilocodeModels (fetch path)", () => {
     await withFetchPathTest(mockFetch, async () => {
       const models = await discoverKilocodeModels();
       expect(models.length).toBeGreaterThan(0);
-      expect(models.some((m) => m.id === "kilo/auto")).toBe(true);
+      expect(requireModelById(models, "kilo/auto").id).toBe("kilo/auto");
     });
   });
 
@@ -211,8 +211,10 @@ describe("discoverKilocodeModels (fetch path)", () => {
     });
     await withFetchPathTest(mockFetch, async () => {
       const models = await discoverKilocodeModels();
-      expect(models.some((m) => m.id === "kilo/auto")).toBe(true);
-      expect(models.some((m) => m.id === "anthropic/claude-sonnet-4")).toBe(true);
+      expect(requireModelById(models, "kilo/auto").id).toBe("kilo/auto");
+      expect(requireModelById(models, "anthropic/claude-sonnet-4").id).toBe(
+        "anthropic/claude-sonnet-4",
+      );
     });
   });
 
@@ -256,7 +258,9 @@ describe("discoverKilocodeModels (fetch path)", () => {
       const auto = requireModelById(models, "kilo/auto");
       expect(auto.name).toBe("Kilo: Auto");
       expect(auto.cost.input).toBeCloseTo(5.0);
-      expect(models.some((m) => m.id === "anthropic/claude-sonnet-4")).toBe(true);
+      expect(requireModelById(models, "anthropic/claude-sonnet-4").id).toBe(
+        "anthropic/claude-sonnet-4",
+      );
     });
   });
 });