vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-06 21:00:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(github-copilot): preserve reasoning IDs for Copilot Codex models (#71684)

Browse Source 
* fix(github-copilot): preserve all reasoning IDs and add gpt-5.3-codex support

The existing guard (8fd15ed0e5) only skipped rewriting reasoning item IDs
when encrypted_content was a non-null string. When gpt-5.3-codex is used
via GitHub Copilot, the model falls through to the forward-compat catch-all
with reasoning:false, so encrypted_content is never requested and arrives
as null — bypassing the guard and causing a rewrite. Copilot validates
reasoning item IDs server-side regardless of whether the client includes
encrypted_content, so the rewritten id triggers the 400 error.

Two changes:

1. connection-bound-ids.ts: skip ALL reasoning items unconditionally.
   Reasoning items always reference server-side state bound to their
   original ID; rewriting any of them breaks Copilot's lookup.

2. models.ts + index.ts: extend the forward-compat cloning logic to
   cover gpt-5.3-codex (adds it to the template-target set and to
   CODEX_TEMPLATE_MODEL_IDS so it can also serve as a template source
   for gpt-5.4). Adds gpt-5.3-codex to COPILOT_XHIGH_MODEL_IDS for
   the thinking profile.

Thanks @InvalidPandaa.

* docs(github-copilot): clarify gpt-5.3-codex is a no-op template for itself

https://claude.ai/code/session_01EAFmq4WyKkiUkVAqRXp4Bm

* fix(github-copilot): remove dead reasoning prefix branch in deriveReplacementId

https://claude.ai/code/session_01EAFmq4WyKkiUkVAqRXp4Bm

* fix(github-copilot): align reasoning id replay tests

* test(plugin-sdk): use cjs sidecar for require fast path

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Peter Steinberger <steipete@gmail.com>
This commit is contained in:
InvalidPanda ツ
2026-04-25 21:52:07 +02:00
committed by GitHub
parent 1d49b8cdaa
commit b64bfc5d9a
8 changed files with 101 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
extensions/github-copilot/connection-bound-ids.test.ts
View File

@@ -5,14 +5,14 @@ import {
} from "./connection-bound-ids.js";
describe("github-copilot connection-bound response IDs", () => {
it("rewrites opaque response item IDs deterministically", () => {
const originalId = Buffer.from(`reasoning-${"x".repeat(24)}`).toString("base64");
const first = [{ id: originalId, type: "reasoning" }];
const second = [{ id: originalId, type: "reasoning" }];
it("rewrites opaque message response item IDs deterministically", () => {
const originalId = Buffer.from(`message-${"x".repeat(24)}`).toString("base64");
const first = [{ id: originalId, type: "message" }];
const second = [{ id: originalId, type: "message" }];
expect(rewriteCopilotConnectionBoundResponseIds(first)).toBe(true);
expect(rewriteCopilotConnectionBoundResponseIds(second)).toBe(true);
expect(first[0]?.id).toMatch(/^rs_[a-f0-9]{16}$/);
expect(first[0]?.id).toMatch(/^msg_[a-f0-9]{16}$/);
expect(first[0]?.id).toBe(second[0]?.id);
});
@@ -35,26 +35,20 @@ describe("github-copilot connection-bound response IDs", () => {
expect(input[4]?.id).toMatch(/^msg_[a-f0-9]{16}$/);
});
it("preserves reasoning IDs when encrypted_content is present", () => {
const originalId = Buffer.from(`reasoning-${"e".repeat(24)}`).toString("base64");
it("preserves reasoning IDs regardless of encrypted_content", () => {
const withEncrypted = Buffer.from(`reasoning-${"e".repeat(24)}`).toString("base64");
const withNull = Buffer.from(`reasoning-${"n".repeat(24)}`).toString("base64");
const withoutField = Buffer.from(`reasoning-${"a".repeat(24)}`).toString("base64");
const input = [
{
id: originalId,
type: "reasoning",
encrypted_content: "opaque-encrypted-payload",
},
{ id: withEncrypted, type: "reasoning", encrypted_content: "opaque-encrypted-payload" },
{ id: withNull, type: "reasoning", encrypted_content: null },
{ id: withoutField, type: "reasoning" },
];
expect(rewriteCopilotConnectionBoundResponseIds(input)).toBe(false);
expect(input[0]?.id).toBe(originalId);
});
it("still rewrites reasoning IDs when encrypted_content is absent", () => {
const originalId = Buffer.from(`reasoning-${"n".repeat(24)}`).toString("base64");
const input = [{ id: originalId, type: "reasoning" }];
expect(rewriteCopilotConnectionBoundResponseIds(input)).toBe(true);
expect(input[0]?.id).toMatch(/^rs_[a-f0-9]{16}$/);
expect(input[0]?.id).toBe(withEncrypted);
expect(input[1]?.id).toBe(withNull);
expect(input[2]?.id).toBe(withoutField);
});
it("patches response payload input arrays only", () => {