From bb13dd0c01a88c7ae3b3fc2966d33d00bbd3b9b3 Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Tue, 17 Mar 2026 07:34:53 +0000
Subject: [PATCH] refactor(extension-tests): share safeguard factory setup

---
 .../pi-embedded-runner/extensions.test.ts     | 46 ++++++++-----------
 1 file changed, 20 insertions(+), 26 deletions(-)

diff --git a/src/agents/pi-embedded-runner/extensions.test.ts b/src/agents/pi-embedded-runner/extensions.test.ts
index ff95a0b2dee..948d96bd9df 100644
--- a/src/agents/pi-embedded-runner/extensions.test.ts
+++ b/src/agents/pi-embedded-runner/extensions.test.ts
@@ -6,13 +6,26 @@ import { getCompactionSafeguardRuntime } from "../pi-extensions/compaction-safeg
 import compactionSafeguardExtension from "../pi-extensions/compaction-safeguard.js";
 import { buildEmbeddedExtensionFactories } from "./extensions.js";
 
+function buildSafeguardFactories(cfg: OpenClawConfig) {
+  const sessionManager = {} as SessionManager;
+  const model = {
+    id: "claude-sonnet-4-20250514",
+    contextWindow: 200_000,
+  } as Model<Api>;
+
+  const factories = buildEmbeddedExtensionFactories({
+    cfg,
+    sessionManager,
+    provider: "anthropic",
+    modelId: "claude-sonnet-4-20250514",
+    model,
+  });
+
+  return { factories, sessionManager };
+}
+
 describe("buildEmbeddedExtensionFactories", () => {
   it("does not opt safeguard mode into quality-guard retries", () => {
-    const sessionManager = {} as SessionManager;
-    const model = {
-      id: "claude-sonnet-4-20250514",
-      contextWindow: 200_000,
-    } as Model<Api>;
     const cfg = {
       agents: {
         defaults: {
@@ -22,14 +35,7 @@ describe("buildEmbeddedExtensionFactories", () => {
         },
       },
     } as OpenClawConfig;
-
-    const factories = buildEmbeddedExtensionFactories({
-      cfg,
-      sessionManager,
-      provider: "anthropic",
-      modelId: "claude-sonnet-4-20250514",
-      model,
-    });
+    const { factories, sessionManager } = buildSafeguardFactories(cfg);
 
     expect(factories).toContain(compactionSafeguardExtension);
     expect(getCompactionSafeguardRuntime(sessionManager)).toMatchObject({
@@ -38,11 +44,6 @@ describe("buildEmbeddedExtensionFactories", () => {
   });
 
   it("wires explicit safeguard quality-guard runtime flags", () => {
-    const sessionManager = {} as SessionManager;
-    const model = {
-      id: "claude-sonnet-4-20250514",
-      contextWindow: 200_000,
-    } as Model<Api>;
     const cfg = {
       agents: {
         defaults: {
@@ -56,14 +57,7 @@ describe("buildEmbeddedExtensionFactories", () => {
         },
       },
     } as OpenClawConfig;
-
-    const factories = buildEmbeddedExtensionFactories({
-      cfg,
-      sessionManager,
-      provider: "anthropic",
-      modelId: "claude-sonnet-4-20250514",
-      model,
-    });
+    const { factories, sessionManager } = buildSafeguardFactories(cfg);
 
     expect(factories).toContain(compactionSafeguardExtension);
     expect(getCompactionSafeguardRuntime(sessionManager)).toMatchObject({