From bfa72f8dabf8dc0f564d1d949b4d3bbd3476912e Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Tue, 14 Jul 2026 20:03:26 +0100 Subject: [PATCH] fix(shared): classify trailing-space ignore rules --- src/agents/sessions/package-manager.test.ts | 2 +- src/shared/ignore-rules.ts | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/agents/sessions/package-manager.test.ts b/src/agents/sessions/package-manager.test.ts index afa814c9b764..54f30b5b0632 100644 --- a/src/agents/sessions/package-manager.test.ts +++ b/src/agents/sessions/package-manager.test.ts @@ -134,7 +134,7 @@ describe("DefaultPackageManager", () => { await writeFile(insideSkill, "# Inside\n", "utf-8"); await writeFile(ignoredSkill, "# Ignored\n", "utf-8"); await writeFile(escapedSkill, "# Ignored\n", "utf-8"); - await writeFile(join(agentsSkillsRoot, "group", ".gitignore"), "ignored/\n\\!literal/\n"); + await writeFile(join(agentsSkillsRoot, "group", ".gitignore"), "ignored/ \n\\!literal/\n"); await writeFile(join(outsideRoot, "SKILL.md"), "# Outside\n", "utf-8"); try { diff --git a/src/shared/ignore-rules.ts b/src/shared/ignore-rules.ts index 35ad22080d14..bb826382e8e2 100644 --- a/src/shared/ignore-rules.ts +++ b/src/shared/ignore-rules.ts @@ -36,7 +36,8 @@ function prefixIgnorePattern(line: string, prefix: string): string { const pattern = negated ? line.slice(1) : line; const anchored = pattern.startsWith("/"); const normalized = anchored ? pattern.slice(1) : pattern; - const depthGlob = prefix && !anchored && !normalized.slice(0, -1).includes("/") ? "**/" : ""; + const matchPattern = normalized.replace(/ +$/, ""); + const depthGlob = prefix && !anchored && !matchPattern.slice(0, -1).includes("/") ? "**/" : ""; const prefixed = `${prefix}${depthGlob}${normalized}`; return negated ? `!${prefixed}` : prefixed; }