mirror of
https://github.com/openclaw/openclaw.git
synced 2026-03-14 19:40:40 +00:00
fix: address bot review feedback on #35862
- Remove dead 'return false' in runServiceStart (Greptile) - Include stack trace in run-loop crash guard error log (Greptile) - Only catch startup errors on subsequent restarts, not initial start (Codex P1) - Add JSDoc note about env var false positive edge case (Codex P1)
This commit is contained in:
committed by
Peter Steinberger
parent
335223af32
commit
c79a0dbdb4
@@ -111,7 +111,11 @@ async function resolveServiceLoadedOrFail(params: {
|
||||
/**
|
||||
* Best-effort config validation. Returns a string describing the issues if
|
||||
* config exists and is invalid, or null if config is valid/missing/unreadable.
|
||||
* (#35862)
|
||||
*
|
||||
* Note: This reads the config file snapshot in the current CLI environment.
|
||||
* Configs using env vars only available in the service context (launchd/systemd)
|
||||
* may produce false positives, but the check is intentionally best-effort —
|
||||
* a false positive here is safer than a crash on startup. (#35862)
|
||||
*/
|
||||
async function getConfigValidationError(): Promise<string | null> {
|
||||
try {
|
||||
@@ -214,7 +218,7 @@ export async function runServiceStart(params: {
|
||||
fail(
|
||||
`${params.serviceNoun} aborted: config is invalid.\n${configError}\nFix the config and retry, or run "openclaw doctor" to repair.`,
|
||||
);
|
||||
return false;
|
||||
return;
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user