From c81ae0412cb021a47f9ba26bc55ef4c3e0147b7d Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Sun, 12 Jul 2026 19:33:27 -0700 Subject: [PATCH] fix(ios): localize Settings accessibility labels (#105859) * fix(ios): preserve localized accessibility labels * chore(i18n): refresh native source inventory --- apps/ios/Sources/Design/SettingsProTabSections.swift | 8 ++++---- scripts/apple-app-i18n.ts | 2 ++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/apps/ios/Sources/Design/SettingsProTabSections.swift b/apps/ios/Sources/Design/SettingsProTabSections.swift index 81919b349baf..b94bde2666cf 100644 --- a/apps/ios/Sources/Design/SettingsProTabSections.swift +++ b/apps/ios/Sources/Design/SettingsProTabSections.swift @@ -767,7 +767,7 @@ extension SettingsProTab { /// Native inset-grouped action row (plain tinted text, no pill chrome). func gatewayActionButton( - title: String, + title: LocalizedStringKey, icon: String, color: Color, isBusy: Bool, @@ -788,7 +788,7 @@ extension SettingsProTab { .buttonStyle(.plain) .foregroundStyle(color) .disabled(isBusy || isDisabled) - .accessibilityLabel(title) + .accessibilityLabel(Text(title)) } var aboutDestination: some View { @@ -874,7 +874,7 @@ extension SettingsProTab { } .contentShape(Rectangle()) } - .accessibilityLabel(title) + .accessibilityLabel(Text(title)) } func toggleCard(title: LocalizedStringKey, isOn: Binding) -> some View { @@ -1400,7 +1400,7 @@ extension SettingsProTab { .contentShape(Rectangle()) } .buttonStyle(.plain) - .accessibilityLabel(title) + .accessibilityLabel(Text(title)) .accessibilityValue(isOn.wrappedValue ? String(localized: "On") : String(localized: "Off")) diff --git a/scripts/apple-app-i18n.ts b/scripts/apple-app-i18n.ts index f82e2bb8d567..5afb42b72d43 100644 --- a/scripts/apple-app-i18n.ts +++ b/scripts/apple-app-i18n.ts @@ -281,8 +281,10 @@ const RAW_LOCALIZATION_BYPASSES: Record = { "func settingsListRow(\n icon: String,\n iconColor: Color,\n title: String", "func aboutLinkRow(title: String", "func toggleCard(title: String", + "func gatewayActionButton(\n title: String", "func gatewaySecureField(_ placeholder: String", "func settingsToggle(\n _ title: String", + ".accessibilityLabel(title)", ], "apps/ios/Sources/Gateway/GatewayConnectionController+Capabilities.swift": [ 'helperText: "Secure connection is required for this host."',