From c950ac112ee0ed46bb2223013fa283fdec048499 Mon Sep 17 00:00:00 2001 From: Manolis Nikiforakis Date: Sat, 30 May 2026 13:03:29 +0300 Subject: [PATCH] fix(microsoft-foundry): skip DeepSeek V4 thinking params on Foundry fallback --- .../embedded-agent-runner-extraparams.test.ts | 20 +++++++++++++++++++ .../embedded-agent-runner/extra-params.ts | 1 + 2 files changed, 21 insertions(+) diff --git a/src/agents/embedded-agent-runner-extraparams.test.ts b/src/agents/embedded-agent-runner-extraparams.test.ts index a385a515695..c67c797b9b5 100644 --- a/src/agents/embedded-agent-runner-extraparams.test.ts +++ b/src/agents/embedded-agent-runner-extraparams.test.ts @@ -733,6 +733,26 @@ describe("applyExtraParamsToAgent", () => { expect(messages[2]).not.toHaveProperty("reasoning_content"); }); + it("does not add DeepSeek V4 thinking params on the Foundry fallback path", () => { + const payload = runResponsesPayloadMutationCase({ + applyProvider: "microsoft-foundry", + applyModelId: "deepseek-v4-pro", + thinkingLevel: "high", + model: { + api: "openai-completions", + provider: "microsoft-foundry", + id: "deepseek-v4-pro", + } as Model<"openai-completions">, + payload: { + reasoning_effort: "high", + messages: [{ role: "user", content: "hello" }], + }, + }); + + expect(payload.reasoning_effort).toBe("high"); + expect(payload).not.toHaveProperty("thinking"); + }); + it("fills MiMo V2.6 reasoning_content for unowned OpenAI-compatible proxy models", () => { const payload = runResponsesPayloadMutationCase({ applyProvider: "opencode", diff --git a/src/agents/embedded-agent-runner/extra-params.ts b/src/agents/embedded-agent-runner/extra-params.ts index fda90ba88ee..05172641cad 100644 --- a/src/agents/embedded-agent-runner/extra-params.ts +++ b/src/agents/embedded-agent-runner/extra-params.ts @@ -901,6 +901,7 @@ function isDeepSeekV4OpenAICompatibleModel(model: Parameters[0]): bool const normalizedModelId = normalizeDeepSeekV4CandidateId(model.id); return ( model.api === "openai-completions" && + model.provider !== "microsoft-foundry" && (normalizedModelId === "deepseek-v4-flash" || normalizedModelId === "deepseek-v4-pro") ); }