From ca60e01e8c10cb9a3f3664480cd2ce16fbcf44ed Mon Sep 17 00:00:00 2001
From: 770120041 <770120041@qq.com>
Date: Mon, 9 Mar 2026 15:32:50 -0400
Subject: [PATCH] test(agents): add unit tests for mapBraveLlmContextResults

---
 src/agents/tools/web-search.test.ts | 75 +++++++++++++++++++++++++++++
 src/agents/tools/web-search.ts      | 21 +++++---
 2 files changed, 89 insertions(+), 7 deletions(-)

diff --git a/src/agents/tools/web-search.test.ts b/src/agents/tools/web-search.test.ts
index 4a7b002d784..b8bccd7dfd3 100644
--- a/src/agents/tools/web-search.test.ts
+++ b/src/agents/tools/web-search.test.ts
@@ -23,6 +23,7 @@ const {
   resolveKimiBaseUrl,
   extractKimiCitations,
   resolveBraveMode,
+  mapBraveLlmContextResults,
 } = __testing;
 
 const kimiApiKeyEnv = ["KIMI_API", "KEY"].join("_");
@@ -393,3 +394,77 @@ describe("resolveBraveMode", () => {
     expect(resolveBraveMode({ mode: "invalid" })).toBe("web");
   });
 });
+
+describe("mapBraveLlmContextResults", () => {
+  it("maps plain string snippets correctly", () => {
+    const results = mapBraveLlmContextResults({
+      grounding: {
+        generic: [
+          {
+            url: "https://example.com/page",
+            title: "Example Page",
+            snippets: ["first snippet", "second snippet"],
+          },
+        ],
+      },
+    });
+    expect(results).toEqual([
+      {
+        url: "https://example.com/page",
+        title: "Example Page",
+        snippets: ["first snippet", "second snippet"],
+        siteName: "example.com",
+      },
+    ]);
+  });
+
+  it("filters out non-string and empty snippets", () => {
+    const results = mapBraveLlmContextResults({
+      grounding: {
+        generic: [
+          {
+            url: "https://example.com",
+            title: "Test",
+            snippets: ["valid", "", null, undefined, 42, { text: "object" }] as string[],
+          },
+        ],
+      },
+    });
+    expect(results[0].snippets).toEqual(["valid"]);
+  });
+
+  it("handles missing snippets array", () => {
+    const results = mapBraveLlmContextResults({
+      grounding: {
+        generic: [{ url: "https://example.com", title: "No Snippets" } as never],
+      },
+    });
+    expect(results[0].snippets).toEqual([]);
+  });
+
+  it("handles empty grounding.generic", () => {
+    expect(mapBraveLlmContextResults({ grounding: { generic: [] } })).toEqual([]);
+  });
+
+  it("handles missing grounding.generic", () => {
+    expect(mapBraveLlmContextResults({ grounding: {} } as never)).toEqual([]);
+  });
+
+  it("resolves siteName from URL hostname", () => {
+    const results = mapBraveLlmContextResults({
+      grounding: {
+        generic: [{ url: "https://docs.example.org/path", title: "Docs", snippets: ["text"] }],
+      },
+    });
+    expect(results[0].siteName).toBe("docs.example.org");
+  });
+
+  it("sets siteName to undefined for invalid URLs", () => {
+    const results = mapBraveLlmContextResults({
+      grounding: {
+        generic: [{ url: "not-a-url", title: "Bad URL", snippets: ["text"] }],
+      },
+    });
+    expect(results[0].siteName).toBeUndefined();
+  });
+});
diff --git a/src/agents/tools/web-search.ts b/src/agents/tools/web-search.ts
index d402d9922e6..d4f88caea61 100644
--- a/src/agents/tools/web-search.ts
+++ b/src/agents/tools/web-search.ts
@@ -1428,6 +1428,18 @@ async function runKimiSearch(params: {
   };
 }
 
+function mapBraveLlmContextResults(
+  data: BraveLlmContextResponse,
+): { url: string; title: string; snippets: string[]; siteName?: string }[] {
+  const genericResults = Array.isArray(data.grounding?.generic) ? data.grounding.generic : [];
+  return genericResults.map((entry) => ({
+    url: entry.url ?? "",
+    title: entry.title ?? "",
+    snippets: (entry.snippets ?? []).filter((s) => typeof s === "string" && s.length > 0),
+    siteName: resolveSiteName(entry.url) || undefined,
+  }));
+}
+
 async function runBraveLlmContextSearch(params: {
   query: string;
   apiKey: string;
@@ -1476,13 +1488,7 @@ async function runBraveLlmContextSearch(params: {
       }
 
       const data = (await res.json()) as BraveLlmContextResponse;
-      const genericResults = Array.isArray(data.grounding?.generic) ? data.grounding.generic : [];
-      const mapped = genericResults.map((entry) => ({
-        url: entry.url ?? "",
-        title: entry.title ?? "",
-        snippets: (entry.snippets ?? []).filter((s) => typeof s === "string" && s.length > 0),
-        siteName: resolveSiteName(entry.url) || undefined,
-      }));
+      const mapped = mapBraveLlmContextResults(data);
 
       return { results: mapped, sources: data.sources };
     },
@@ -2121,4 +2127,5 @@ export const __testing = {
   extractKimiCitations,
   resolveRedirectUrl: resolveCitationRedirectUrl,
   resolveBraveMode,
+  mapBraveLlmContextResults,
 } as const;