vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-04-09 08:11:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: harden Feishu comment-thread delivery (#59129)

Browse Source 
* fix: harden Feishu comment-thread delivery

* fix: harden Feishu comment-thread delivery (#59129) (thanks @wittam-01)

---------

Co-authored-by: George Zhang <georgezhangtj97@gmail.com>
This commit is contained in:
wittam-01
2026-04-02 15:31:52 +08:00
committed by GitHub
parent a5cd921053
commit ce0ff42ff5
9 changed files with 1559 additions and 111 deletions
Download Patch File Download Diff File Expand all files Collapse all files

57
extensions/feishu/src/comment-handler.test.ts
View File

@@ -8,7 +8,7 @@ const resolveDriveCommentEventTurnMock = vi.hoisted(() => vi.fn());
const createFeishuCommentReplyDispatcherMock = vi.hoisted(() => vi.fn());
const maybeCreateDynamicAgentMock = vi.hoisted(() => vi.fn());
const createFeishuClientMock = vi.hoisted(() => vi.fn(() => ({ request: vi.fn() })));
const replyCommentMock = vi.hoisted(() => vi.fn());
const deliverCommentThreadTextMock = vi.hoisted(() => vi.fn());
vi.mock("./monitor.comment.js", () => ({
resolveDriveCommentEventTurn: resolveDriveCommentEventTurnMock,
@@ -27,7 +27,7 @@ vi.mock("./client.js", () => ({
}));
vi.mock("./drive.js", () => ({
replyComment: replyCommentMock,
deliverCommentThreadText: deliverCommentThreadTextMock,
}));
function buildConfig(overrides?: Partial<ClawdbotConfig>): ClawdbotConfig {
@@ -66,6 +66,7 @@ describe("handleFeishuCommentEvent", () => {
noticeType: "add_comment",
fileToken: "doc_token_1",
fileType: "docx",
isWholeComment: false,
senderId: "ou_sender",
senderUserId: "on_sender_user",
timestamp: "1774951528000",
@@ -76,7 +77,10 @@ describe("handleFeishuCommentEvent", () => {
rootCommentText: "root comment",
targetReplyText: "latest reply",
});
replyCommentMock.mockResolvedValue({ reply_id: "r1" });
deliverCommentThreadTextMock.mockResolvedValue({
delivery_mode: "reply_comment",
reply_id: "r1",
});
const runtime = createPluginRuntimeMock({
channel: {
@@ -196,7 +200,7 @@ describe("handleFeishuCommentEvent", () => {
typeof vi.fn
>;
expect(dispatchReplyFromConfig).toHaveBeenCalledTimes(1);
expect(replyCommentMock).not.toHaveBeenCalled();
expect(deliverCommentThreadTextMock).not.toHaveBeenCalled();
});
it("issues a pairing challenge in the comment thread when dmPolicy=pairing", async () => {
@@ -232,12 +236,13 @@ describe("handleFeishuCommentEvent", () => {
} as never,
});
expect(replyCommentMock).toHaveBeenCalledWith(
expect(deliverCommentThreadTextMock).toHaveBeenCalledWith(
expect.anything(),
expect.objectContaining({
file_token: "doc_token_1",
file_type: "docx",
comment_id: "comment_1",
is_whole_comment: false,
}),
);
const dispatchReplyFromConfig = runtime.channel.reply.dispatchReplyFromConfig as ReturnType<
@@ -245,4 +250,46 @@ describe("handleFeishuCommentEvent", () => {
>;
expect(dispatchReplyFromConfig).not.toHaveBeenCalled();
});
it("passes whole-comment metadata to the comment reply dispatcher", async () => {
resolveDriveCommentEventTurnMock.mockResolvedValueOnce({
eventId: "evt_whole",
messageId: "drive-comment:evt_whole",
commentId: "comment_whole",
replyId: "reply_whole",
noticeType: "add_reply",
fileToken: "doc_token_1",
fileType: "docx",
isWholeComment: true,
senderId: "ou_sender",
senderUserId: "on_sender_user",
timestamp: "1774951528000",
isMentioned: false,
documentTitle: "Project review",
prompt: "prompt body",
preview: "prompt body",
rootCommentText: "root comment",
targetReplyText: "reply text",
});
await handleFeishuCommentEvent({
cfg: buildConfig(),
accountId: "default",
event: { event_id: "evt_whole" },
botOpenId: "ou_bot",
runtime: {
log: vi.fn(),
error: vi.fn(),
} as never,
});
expect(createFeishuCommentReplyDispatcherMock).toHaveBeenCalledWith(
expect.objectContaining({
commentId: "comment_whole",
fileToken: "doc_token_1",
fileType: "docx",
isWholeComment: true,
}),
);
});
});