fix(release): stabilize final validation checks

This commit is contained in:
Peter Steinberger
2026-05-06 10:18:12 +01:00
parent bf0f547632
commit ceaa56fb12
4 changed files with 99 additions and 50 deletions

View File

@@ -121,16 +121,23 @@ function assertCorruptUpdate(updateJsonPath, pluginId) {
if (!plugins) {
throw new Error(`missing postUpdate.plugins in update output: ${JSON.stringify(payload)}`);
}
if (plugins.status !== "warning") {
throw new Error(
`expected post-update plugin status warning, got ${JSON.stringify(plugins.status)}`,
);
}
assertCorruptPluginDetails(plugins, pluginId);
assertCorruptPluginTolerated(plugins, pluginId);
}
function assertCorruptPluginResult(pluginJsonPath, pluginId) {
const plugins = readJson(pluginJsonPath);
assertCorruptPluginTolerated(plugins, pluginId);
}
function assertCorruptPluginTolerated(plugins, pluginId) {
const evidence = collectPluginEvidence(plugins, pluginId);
if (plugins.status === "ok") {
if (isCorruptPluginDisabledAfterUpdate(evidence, pluginId)) {
return;
}
assertCorruptPluginCleanOrRepaired(evidence);
return;
}
if (plugins.status !== "warning") {
throw new Error(
`expected post-update plugin status warning, got ${JSON.stringify(plugins.status)}`,
@@ -139,23 +146,49 @@ function assertCorruptPluginResult(pluginJsonPath, pluginId) {
assertCorruptPluginDetails(plugins, pluginId);
}
function isCorruptPluginDisabledAfterUpdate(evidence, pluginId) {
const outcome = evidence.outcome;
const message = typeof outcome?.message === "string" ? outcome.message : "";
return (
outcome?.status === "skipped" &&
message.includes(`Disabled "${pluginId}" after plugin update failure`) &&
message.includes("OpenClaw will continue without it")
);
}
function assertCorruptPluginCleanOrRepaired(evidence) {
if (evidence.outcome) {
throw new Error(
`expected clean or repaired corrupt plugin state, got ${JSON.stringify(evidence)}`,
);
}
if (evidence.warning || evidence.integrityDrift || evidence.syncMessages.length > 0) {
throw new Error(
`expected warning post-update status for corrupt plugin evidence, got ok: ${JSON.stringify(
evidence,
)}`,
);
}
}
function assertCorruptPluginDetails(plugins, pluginId) {
const outcomes = plugins.npm?.outcomes ?? [];
const outcome = outcomes.find((entry) => entry?.pluginId === pluginId);
const evidence = collectPluginEvidence(plugins, pluginId);
const outcome = evidence.outcome;
if (!outcome || outcome.status !== "error") {
throw new Error(
`expected error outcome for ${pluginId}, got ${JSON.stringify({
outcomes,
outcomes: plugins.npm?.outcomes ?? [],
warnings: plugins.warnings ?? [],
sync: plugins.sync,
integrityDrifts: plugins.integrityDrifts ?? [],
})}`,
);
}
const warnings = plugins.warnings ?? [];
const warning = warnings.find((entry) => entry?.pluginId === pluginId);
const warning = evidence.warning;
if (!warning) {
throw new Error(`expected warning for ${pluginId}, got ${JSON.stringify(warnings)}`);
throw new Error(
`expected warning for ${pluginId}, got ${JSON.stringify(plugins.warnings ?? [])}`,
);
}
const text = JSON.stringify({ outcome, warning });
for (const expected of [
@@ -169,6 +202,21 @@ function assertCorruptPluginDetails(plugins, pluginId) {
}
}
function collectPluginEvidence(plugins, pluginId) {
const outcomes = plugins.npm?.outcomes ?? [];
const warnings = plugins.warnings ?? [];
const integrityDrifts = plugins.integrityDrifts ?? [];
const syncMessages = [...(plugins.sync?.warnings ?? []), ...(plugins.sync?.errors ?? [])].filter(
(message) => String(message).includes(pluginId),
);
return {
outcome: outcomes.find((entry) => entry?.pluginId === pluginId),
warning: warnings.find((entry) => entry?.pluginId === pluginId),
integrityDrift: integrityDrifts.find((entry) => entry?.pluginId === pluginId),
syncMessages,
};
}
function assertLegacyPostUpdatePluginFailure(updateJsonPath) {
const payload = readJson(updateJsonPath);
if (payload.status !== "error" || payload.reason !== "post-update-plugins") {