vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-03-12 07:20:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: address markdown image review feedback

Browse Source
This commit is contained in:
Ayaan Zaidi
2026-03-07 19:26:29 +05:30
committed by Ayaan Zaidi
parent 4bf902de58
commit d25b493c7f
4 changed files with 52 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
apps/shared/OpenClawKit/Sources/OpenClawChatUI/ChatMarkdownPreprocessor.swift
View File

@@ -40,24 +40,22 @@ enum ChatMarkdownPreprocessor {
if matches.isEmpty { return Result(cleaned: self.normalize(withoutTimestamps), images: []) }
var images: [InlineImage] = []
var cleaned = withoutTimestamps
let cleaned = NSMutableString(string: withoutTimestamps)
for match in matches.reversed() {
guard match.numberOfRanges >= 3 else { continue }
let label = ns.substring(with: match.range(at: 1))
let source = ns.substring(with: match.range(at: 2))
let start = cleaned.index(cleaned.startIndex, offsetBy: match.range.location)
let end = cleaned.index(start, offsetBy: match.range.length)
if let inlineImage = self.inlineImage(label: label, source: source) {
images.append(inlineImage)
cleaned.replaceSubrange(start..<end, with: "")
cleaned.replaceCharacters(in: match.range, with: "")
} else {
cleaned.replaceSubrange(start..<end, with: self.fallbackImageLabel(label))
cleaned.replaceCharacters(in: match.range, with: self.fallbackImageLabel(label))
}
}
return Result(cleaned: self.normalize(cleaned), images: images.reversed())
return Result(cleaned: self.normalize(cleaned as String), images: images.reversed())
}
private static func inlineImage(label: String, source: String) -> InlineImage? {

9
apps/shared/OpenClawKit/Tests/OpenClawKitTests/ChatMarkdownPreprocessorTests.swift
View File

@@ -42,6 +42,15 @@ struct ChatMarkdownPreprocessorTests {
#expect(result.images.isEmpty)
}
@Test func handlesUnicodeBeforeRemoteMarkdownImages() {
let markdown = "🙂![Leak](https://example.com/image.png)"
let result = ChatMarkdownPreprocessor.preprocess(markdown: markdown)
#expect(result.cleaned == "🙂Leak")
#expect(result.images.isEmpty)
}
@Test func stripsInboundUntrustedContextBlocks() {
let markdown = """
Conversation info (untrusted metadata):