From d456dd1bd34797c6bdcd7a68b6249748bf9fccbd Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Fri, 8 May 2026 20:50:02 +0100 Subject: [PATCH] test: tighten command extension helper assertions --- extensions/discord/src/api.test.ts | 1 - extensions/discord/src/resolve-allowlist-common.test.ts | 1 - extensions/firecrawl/src/firecrawl-tools.test.ts | 2 -- extensions/qa-lab/src/qa-credentials-admin.runtime.test.ts | 1 - extensions/zalo/src/api.test.ts | 3 --- extensions/zalo/src/setup-surface.test.ts | 5 ----- extensions/zalouser/src/setup-surface.test.ts | 2 -- src/commands/agents.identity.test.ts | 4 ++-- .../channels.adds-non-default-telegram-account.test.ts | 1 - src/commands/doctor-browser.facade.test.ts | 1 - 10 files changed, 2 insertions(+), 19 deletions(-) diff --git a/extensions/discord/src/api.test.ts b/extensions/discord/src/api.test.ts index 375182c58d0..3f90477fd89 100644 --- a/extensions/discord/src/api.test.ts +++ b/extensions/discord/src/api.test.ts @@ -142,7 +142,6 @@ describe("fetchDiscord", () => { }); expect(result).toEqual({ id: "42" }); - expect(request).toBeDefined(); if (!request) { throw new Error("expected Discord request init"); } diff --git a/extensions/discord/src/resolve-allowlist-common.test.ts b/extensions/discord/src/resolve-allowlist-common.test.ts index 163a708057c..a110d54832e 100644 --- a/extensions/discord/src/resolve-allowlist-common.test.ts +++ b/extensions/discord/src/resolve-allowlist-common.test.ts @@ -14,7 +14,6 @@ describe("resolve-allowlist-common", () => { it("resolves and filters guilds by id or name", () => { const mainGuild = findDiscordGuildByName(guilds, "Main Guild"); - expect(mainGuild).toBeDefined(); if (!mainGuild) { throw new Error("expected Main Guild lookup result"); } diff --git a/extensions/firecrawl/src/firecrawl-tools.test.ts b/extensions/firecrawl/src/firecrawl-tools.test.ts index 027a8e9df04..52a3f37956d 100644 --- a/extensions/firecrawl/src/firecrawl-tools.test.ts +++ b/extensions/firecrawl/src/firecrawl-tools.test.ts @@ -83,7 +83,6 @@ describe("firecrawl tools", () => { expect(provider.id).toBe("firecrawl"); expect(provider.credentialPath).toBe("plugins.entries.firecrawl.config.webSearch.apiKey"); const pluginEntry = applied.plugins?.entries?.firecrawl; - expect(pluginEntry).toBeDefined(); if (!pluginEntry) { throw new Error("expected Firecrawl plugin entry"); } @@ -354,7 +353,6 @@ describe("firecrawl tools", () => { expect(provider.id).toBe("firecrawl"); expect(provider.credentialPath).toBe("plugins.entries.firecrawl.config.webFetch.apiKey"); const pluginEntry = applied.plugins?.entries?.firecrawl; - expect(pluginEntry).toBeDefined(); if (!pluginEntry) { throw new Error("expected Firecrawl fetch plugin entry"); } diff --git a/extensions/qa-lab/src/qa-credentials-admin.runtime.test.ts b/extensions/qa-lab/src/qa-credentials-admin.runtime.test.ts index 7f0122ddd52..e56e5146a27 100644 --- a/extensions/qa-lab/src/qa-credentials-admin.runtime.test.ts +++ b/extensions/qa-lab/src/qa-credentials-admin.runtime.test.ts @@ -18,7 +18,6 @@ function jsonResponse(payload: unknown, status = 200) { function requireFirstFetchInput(fetchImpl: ReturnType): RequestInfo | URL { const input = fetchImpl.mock.calls[0]?.[0] as RequestInfo | URL | undefined; - expect(input).toBeDefined(); if (!input) { throw new Error("expected fetch input"); } diff --git a/extensions/zalo/src/api.test.ts b/extensions/zalo/src/api.test.ts index 919d6f0b4b7..8a13c4d8871 100644 --- a/extensions/zalo/src/api.test.ts +++ b/extensions/zalo/src/api.test.ts @@ -18,7 +18,6 @@ async function expectPostJsonRequest(run: (token: string, fetcher: ZaloFetch) => await run("test-token", fetcher); expect(fetcher).toHaveBeenCalledTimes(1); const [, init] = fetcher.mock.calls[0] ?? []; - expect(init).toBeDefined(); if (!init) { throw new Error("expected Zalo request init"); } @@ -71,11 +70,9 @@ describe("Zalo API request methods", () => { await rejected; const [, init] = fetcher.mock.calls[0] ?? []; - expect(init).toBeDefined(); if (!init) { throw new Error("expected Zalo chat action request init"); } - expect(init.signal).toBeDefined(); if (!init.signal) { throw new Error("expected Zalo chat action abort signal"); } diff --git a/extensions/zalo/src/setup-surface.test.ts b/extensions/zalo/src/setup-surface.test.ts index 856963f292b..5065017a6a6 100644 --- a/extensions/zalo/src/setup-surface.test.ts +++ b/extensions/zalo/src/setup-surface.test.ts @@ -61,7 +61,6 @@ describe("zalo setup wizard", () => { expect(result.accountId).toBe("default"); const zaloConfig = result.cfg.channels?.zalo; - expect(zaloConfig).toBeDefined(); if (!zaloConfig) { throw new Error("expected Zalo config"); } @@ -123,7 +122,6 @@ describe("zalo setup wizard", () => { const next = zaloDmPolicy.setPolicy(cfg, "open"); const zaloConfig = next.channels?.zalo; - expect(zaloConfig).toBeDefined(); if (!zaloConfig) { throw new Error("expected Zalo config"); } @@ -131,7 +129,6 @@ describe("zalo setup wizard", () => { const workAccount = next.channels?.zalo?.accounts?.work as | { dmPolicy?: string; allowFrom?: Array } | undefined; - expect(workAccount).toBeDefined(); if (!workAccount) { throw new Error("expected Zalo work account"); } @@ -157,7 +154,6 @@ describe("zalo setup wizard", () => { ); const zaloConfig = next.channels?.zalo; - expect(zaloConfig).toBeDefined(); if (!zaloConfig) { throw new Error("expected Zalo config"); } @@ -165,7 +161,6 @@ describe("zalo setup wizard", () => { const workAccount = next.channels?.zalo?.accounts?.work as | { dmPolicy?: string; allowFrom?: Array } | undefined; - expect(workAccount).toBeDefined(); if (!workAccount) { throw new Error("expected Zalo work account"); } diff --git a/extensions/zalouser/src/setup-surface.test.ts b/extensions/zalouser/src/setup-surface.test.ts index 79e0955889e..67510b26254 100644 --- a/extensions/zalouser/src/setup-surface.test.ts +++ b/extensions/zalouser/src/setup-surface.test.ts @@ -33,12 +33,10 @@ describe("zalouser setup wizard", () => { ) { expect(result.accountId).toBe("default"); const channelConfig = result.cfg.channels?.zalouser; - expect(channelConfig).toBeDefined(); if (!channelConfig) { throw new Error("expected Zalo Personal channel config"); } const pluginEntry = result.cfg.plugins?.entries?.zalouser; - expect(pluginEntry).toBeDefined(); if (!pluginEntry) { throw new Error("expected Zalo Personal plugin entry"); } diff --git a/src/commands/agents.identity.test.ts b/src/commands/agents.identity.test.ts index adce0af0b8a..e5ef4d8bc93 100644 --- a/src/commands/agents.identity.test.ts +++ b/src/commands/agents.identity.test.ts @@ -44,11 +44,11 @@ async function writeIdentityFile(workspace: string, lines: string[]) { function getWrittenMainIdentity() { const [written] = configMocks.writeConfigFile.mock.calls[0] ?? []; - expect(written).toBeDefined(); if (!written) { throw new Error("expected written agent config"); } - return written.agents?.list?.find((entry) => entry.id === "main")?.identity; + const payload = written as ConfigWritePayload; + return payload.agents?.list?.find((entry) => entry.id === "main")?.identity; } async function runIdentityCommandFromWorkspace(workspace: string, fromIdentity = true) { diff --git a/src/commands/channels.adds-non-default-telegram-account.test.ts b/src/commands/channels.adds-non-default-telegram-account.test.ts index 68090ff2cd1..604c6e67941 100644 --- a/src/commands/channels.adds-non-default-telegram-account.test.ts +++ b/src/commands/channels.adds-non-default-telegram-account.test.ts @@ -340,7 +340,6 @@ describe("channels command", () => { function getWrittenConfig(): T { expect(configMocks.writeConfigFile).toHaveBeenCalledTimes(1); const [config] = configMocks.writeConfigFile.mock.calls[0] ?? []; - expect(config).toBeDefined(); if (config === undefined) { throw new Error("expected written channel config"); } diff --git a/src/commands/doctor-browser.facade.test.ts b/src/commands/doctor-browser.facade.test.ts index 522e6c9a7dc..9f89ac36891 100644 --- a/src/commands/doctor-browser.facade.test.ts +++ b/src/commands/doctor-browser.facade.test.ts @@ -10,7 +10,6 @@ vi.mock("../plugin-sdk/facade-loader.js", () => ({ function requireFirstNoteCall(noteFn: ReturnType): unknown[] { const call = noteFn.mock.calls[0]; - expect(call).toBeDefined(); if (!call) { throw new Error("expected browser doctor note"); }