From d9a209161e09a3cfbaea1d9cedc7e23943290c56 Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Sat, 9 May 2026 09:28:48 +0100 Subject: [PATCH] docs(skills): clarify issue triage ship flow --- .../skills/openclaw-pr-maintainer/SKILL.md | 15 ++++++++----- .../openclaw-small-bugfix-sweep/SKILL.md | 21 +++++++++++-------- 2 files changed, 22 insertions(+), 14 deletions(-) diff --git a/.agents/skills/openclaw-pr-maintainer/SKILL.md b/.agents/skills/openclaw-pr-maintainer/SKILL.md index a9ad35d4cd5..44367b84929 100644 --- a/.agents/skills/openclaw-pr-maintainer/SKILL.md +++ b/.agents/skills/openclaw-pr-maintainer/SKILL.md @@ -103,11 +103,16 @@ Exceptions: When asked for `X` issues or PRs to triage, `X` means qualified candidates, not sampled threads. -Triage is read/prove/patch-local by default. Do not commit unless the requester writes -`commit` in the current instruction for the exact diff being handled. Do not -treat earlier messages, inferred intent, "next", sweep momentum, or bundled -publish language as commit permission. If the requester asks for follow-up work without -saying `commit`, keep the files dirty after local fixes and proof. +Issue triage is review/prove/patch-local by default: + +1. Review the issue body, comments, related threads, current code, and adjacent tests. +2. Fix only issues that are easy, high-confidence, and narrowly owned by the implicated path. +3. Add focused regression proof when practical. +4. Stop with the dirty diff, touched files, and test/gate output for Peter's manual review. +5. After Peter approves shipping, make one commit per accepted fix, with its own changelog entry when user-facing. +6. Pull/rebase, push, then comment and close only the issues that were fixed or explicitly triaged closed. + +Do not batch unrelated issue fixes into one commit. Do not publish, comment, close, or label during the review/prove phase. Missing changelog is not a PR review finding or merge blocker. If landing/fixing a user-visible change, add/update changelog automatically when practical; never ask or block solely on it. diff --git a/.agents/skills/openclaw-small-bugfix-sweep/SKILL.md b/.agents/skills/openclaw-small-bugfix-sweep/SKILL.md index a9caf9105d8..efe6971925f 100644 --- a/.agents/skills/openclaw-small-bugfix-sweep/SKILL.md +++ b/.agents/skills/openclaw-small-bugfix-sweep/SKILL.md @@ -7,17 +7,19 @@ description: Fix only small, high-certainty OpenClaw bugs from a pasted issue/PR Batch workflow for pasted OpenClaw issue/PR refs. Execute, do not summarize. -Triage does not commit, push, create PRs, comment, close, label, land, or merge. +Triage reviews, proves, and patches local fixes first; publishing waits for Peter's manual review. ## Peter Review Gate Peter always wants to review code before commits. -After local fixes and proof, stop with the diff summary, touched files, and test/gate output. -Do not commit unless Peter writes `commit` in the current instruction for the exact diff being handled. -Do not treat earlier messages, inferred intent, "next", sweep momentum, or bundled publish language as commit permission. -If Peter asks for follow-up work without saying `commit`, keep the files dirty after local fixes and proof. -Do not push, comment, close, label, land, merge, or otherwise publish until Peter explicitly asks for that exact action after the code has been reviewed. -If Peter asks for a bundled action like `commit push close`, first confirm the code has already been reviewed in chat; if not, stop with the dirty diff and ask for review/approval. +Default flow: +1. Review each issue deeply enough to prove current behavior and root cause. +2. Fix only easy, high-confidence bugs with narrow ownership and focused proof. +3. Stop with the dirty diff summary, touched files, and test/gate output for Peter's manual review. +4. After Peter approves shipping, make one commit per accepted fix, with a changelog entry for each user-facing fix. +5. Pull/rebase, push, then comment and close only the fixed or explicitly triaged-closed issues. + +Do not batch unrelated issue fixes into one commit. Do not push, create PRs, comment, close, label, land, merge, or otherwise publish during the review/prove phase. ## Companion Skills @@ -58,8 +60,9 @@ Skip with terse reason. Do not pad with low-confidence fixes. - no drive-by refactors - tests near failing surface - docs only for changed public behavior -- no commit unless Peter writes `commit` in the current instruction -- no push/create PR/comment/close/label/land/merge unless explicitly asked for that exact action after review +- no commit during the review/prove phase +- after Peter approves shipping, one commit plus changelog per accepted user-facing fix +- no push/create PR/comment/close/label/land/merge until Peter approves shipping after review ## PR Rules