From daa48e8681e2e27686dfd0a9cf7ec4cd254cc00b Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Fri, 8 May 2026 21:17:59 +0100
Subject: [PATCH] test: tighten acp security helpers

---
 src/acp/translator.permission-relay.test.ts      | 4 +++-
 src/security/audit-node-command-findings.test.ts | 1 -
 src/security/fix.test.ts                         | 1 -
 src/security/windows-acl.test.ts                 | 1 -
 4 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/acp/translator.permission-relay.test.ts b/src/acp/translator.permission-relay.test.ts
index b1c9cf4b5ca..e61b76445ca 100644
--- a/src/acp/translator.permission-relay.test.ts
+++ b/src/acp/translator.permission-relay.test.ts
@@ -113,7 +113,9 @@ async function createHarness(
   const promptPromise = promptAgent(agent, SESSION_ID);
 
   await vi.waitFor(() => {
-    expect(runId).toBeDefined();
+    if (!runId) {
+      throw new Error("expected ACP permission relay run id");
+    }
   });
 
   return {
diff --git a/src/security/audit-node-command-findings.test.ts b/src/security/audit-node-command-findings.test.ts
index 2197968ed0b..7247b2608ec 100644
--- a/src/security/audit-node-command-findings.test.ts
+++ b/src/security/audit-node-command-findings.test.ts
@@ -27,7 +27,6 @@ function requireFinding(
   label: string,
 ) {
   const finding = findings.find((entry) => entry.checkId === checkId);
-  expect(finding, label).toBeDefined();
   if (!finding) {
     throw new Error(`Expected ${checkId} finding for ${label}`);
   }
diff --git a/src/security/fix.test.ts b/src/security/fix.test.ts
index 4250da21d0a..0f85dce98f0 100644
--- a/src/security/fix.test.ts
+++ b/src/security/fix.test.ts
@@ -123,7 +123,6 @@ describe("security fix", () => {
     const whatsapp = channels.whatsapp;
     const accounts = whatsapp.accounts as Record<string, Record<string, unknown>>;
     const account = accounts[accountId];
-    expect(account).toBeDefined();
     if (!account) {
       throw new Error(`Expected WhatsApp account ${accountId}`);
     }
diff --git a/src/security/windows-acl.test.ts b/src/security/windows-acl.test.ts
index ed6c7109a24..1cdf5096ca8 100644
--- a/src/security/windows-acl.test.ts
+++ b/src/security/windows-acl.test.ts
@@ -88,7 +88,6 @@ function expectInspectSuccess(
 function expectIcaclsResetCommand(
   result: ReturnType<typeof createIcaclsResetCommand>,
 ): NonNullable<ReturnType<typeof createIcaclsResetCommand>> {
-  expect(result).toBeDefined();
   if (!result) {
     throw new Error("Expected icacls reset command");
   }