From dfbde683ceedf4578e36bfb8ec0bd6163b09b17a Mon Sep 17 00:00:00 2001 From: Vincent Koc Date: Fri, 6 Mar 2026 00:19:37 -0500 Subject: [PATCH] Tests: trim redundant GPT-5.4 overlap coverage --- src/agents/live-model-filter.test.ts | 13 ------------- src/agents/live-model-filter.ts | 2 -- src/auto-reply/thinking.test.ts | 5 ----- 3 files changed, 20 deletions(-) delete mode 100644 src/agents/live-model-filter.test.ts diff --git a/src/agents/live-model-filter.test.ts b/src/agents/live-model-filter.test.ts deleted file mode 100644 index eca20caca7a..00000000000 --- a/src/agents/live-model-filter.test.ts +++ /dev/null @@ -1,13 +0,0 @@ -import { describe, expect, it } from "vitest"; -import { isModernModelRef } from "./live-model-filter.js"; - -describe("isModernModelRef", () => { - it("accepts new openai gpt-5.4 refs", () => { - expect(isModernModelRef({ provider: "openai", id: "gpt-5.4" })).toBe(true); - expect(isModernModelRef({ provider: "openai", id: "gpt-5.4-pro" })).toBe(true); - }); - - it("keeps rejecting older openai refs outside the allowlist", () => { - expect(isModernModelRef({ provider: "openai", id: "gpt-4.1" })).toBe(false); - }); -}); diff --git a/src/agents/live-model-filter.ts b/src/agents/live-model-filter.ts index 48218d41ff7..03de7d772cc 100644 --- a/src/agents/live-model-filter.ts +++ b/src/agents/live-model-filter.ts @@ -46,8 +46,6 @@ export function isModernModelRef(ref: ModelRef): boolean { } if (provider === "openai") { - // Keep the broader prefix match for GPT-5.x families so live tests keep opting into - // fresh OpenAI minor variants before the forward-compat catalog learns each exact ID. return matchesExactOrPrefix(id, OPENAI_MODELS); } diff --git a/src/auto-reply/thinking.test.ts b/src/auto-reply/thinking.test.ts index ef7da2df8f0..359082c2616 100644 --- a/src/auto-reply/thinking.test.ts +++ b/src/auto-reply/thinking.test.ts @@ -42,11 +42,6 @@ describe("normalizeThinkLevel", () => { }); describe("listThinkingLevels", () => { - it("includes xhigh for openai gpt-5.4 refs", () => { - expect(listThinkingLevels("openai", "gpt-5.4")).toContain("xhigh"); - expect(listThinkingLevels("openai", "gpt-5.4-pro")).toContain("xhigh"); - }); - it("includes xhigh for codex models", () => { expect(listThinkingLevels(undefined, "gpt-5.2-codex")).toContain("xhigh"); expect(listThinkingLevels(undefined, "gpt-5.3-codex")).toContain("xhigh");