From e71da6705b29e727279dfe57174792766cc42ac5 Mon Sep 17 00:00:00 2001 From: Vincent Koc Date: Wed, 22 Apr 2026 12:40:38 -0700 Subject: [PATCH] fix(hooks): skip skill workshop capture when review is off --- extensions/skill-workshop/index.test.ts | 13 +++++++++++++ extensions/skill-workshop/index.ts | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/extensions/skill-workshop/index.test.ts b/extensions/skill-workshop/index.test.ts index 205b72b8e8a..750ca9f8dc6 100644 --- a/extensions/skill-workshop/index.test.ts +++ b/extensions/skill-workshop/index.test.ts @@ -226,6 +226,19 @@ describe("skill-workshop", () => { expect(on).not.toHaveBeenCalledWith("agent_end", expect.any(Function)); }); + it("skips agent_end hook wiring when review mode is off", () => { + const on = vi.fn(); + const api = createTestPluginApi({ + pluginConfig: { reviewMode: "off" }, + on, + }); + + plugin.register(api); + + expect(on).toHaveBeenCalledWith("before_prompt_build", expect.any(Function)); + expect(on).not.toHaveBeenCalledWith("agent_end", expect.any(Function)); + }); + it("lets explicit tool suggestions stay pending in auto mode", async () => { const workspaceDir = await makeTempDir(); const stateDir = await makeTempDir(); diff --git a/extensions/skill-workshop/index.ts b/extensions/skill-workshop/index.ts index 40f391a4538..6ba61925427 100644 --- a/extensions/skill-workshop/index.ts +++ b/extensions/skill-workshop/index.ts @@ -25,7 +25,7 @@ export default definePluginEntry({ prependSystemContext: buildWorkshopGuidance(config), })); - if (config.autoCapture) { + if (config.autoCapture && config.reviewMode !== "off") { api.on("agent_end", async (event, ctx) => { if (!event.success) { return;