From ebd8b00cc318bd71a10cafeb6540f72162ce37ce Mon Sep 17 00:00:00 2001 From: Dallin Romney Date: Thu, 21 May 2026 11:56:59 -0700 Subject: [PATCH] fix(qa-lab): rename codex lifecycle fixtures to match knip ignore pattern (#85066) knip's deadcode-unused-files check ignores fixtures matching **/*.fixture.ts (dot before "fixture"). The codex lifecycle fixtures landed in bbf3eec786 as auth-profile-fixture.ts and codex-plugin-fixture.ts (hyphen), so knip flagged them as unexpected unused files and CI's check-dependencies job has been failing on main since then. Rename to auth-profile.fixture.ts and codex-plugin.fixture.ts and update the lifecycle test, the fixture cross-import, and the six qa/scenarios markdown files that reference them by path and qaImport specifier. --- .../{auth-profile-fixture.ts => auth-profile.fixture.ts} | 0 extensions/qa-lab/src/codex-plugin-lifecycle.test.ts | 4 ++-- .../{codex-plugin-fixture.ts => codex-plugin.fixture.ts} | 2 +- qa/scenarios/runtime/auth-profile-codex-mixed-profiles.md | 4 ++-- .../runtime/auth-profile-doctor-migration-safety.md | 8 ++++---- qa/scenarios/runtime/codex-plugin-cold-install.md | 8 ++++---- qa/scenarios/runtime/codex-plugin-install-race.md | 4 ++-- qa/scenarios/runtime/codex-plugin-pinned-new.md | 6 +++--- qa/scenarios/runtime/codex-plugin-pinned-old.md | 6 +++--- 9 files changed, 21 insertions(+), 21 deletions(-) rename extensions/qa-lab/src/{auth-profile-fixture.ts => auth-profile.fixture.ts} (100%) rename extensions/qa-lab/src/{codex-plugin-fixture.ts => codex-plugin.fixture.ts} (99%) diff --git a/extensions/qa-lab/src/auth-profile-fixture.ts b/extensions/qa-lab/src/auth-profile.fixture.ts similarity index 100% rename from extensions/qa-lab/src/auth-profile-fixture.ts rename to extensions/qa-lab/src/auth-profile.fixture.ts diff --git a/extensions/qa-lab/src/codex-plugin-lifecycle.test.ts b/extensions/qa-lab/src/codex-plugin-lifecycle.test.ts index 20cd8b9bf27..63a9addbdac 100644 --- a/extensions/qa-lab/src/codex-plugin-lifecycle.test.ts +++ b/extensions/qa-lab/src/codex-plugin-lifecycle.test.ts @@ -7,7 +7,7 @@ import { resolveCodexAuthProfile, seedAuthProfiles, snapshotAuthProfiles, -} from "./auth-profile-fixture.js"; +} from "./auth-profile.fixture.js"; import { CODEX_PLUGIN_CURRENT_VERSION, CODEX_PLUGIN_LIFECYCLE_MESSAGES, @@ -15,7 +15,7 @@ import { evaluateCodexPluginLifecycle, seedCodexPluginAt, snapshotCodexPluginState, -} from "./codex-plugin-fixture.js"; +} from "./codex-plugin.fixture.js"; import { createTempDirHarness } from "./temp-dir.test-helper.js"; const tempDirs = createTempDirHarness(); diff --git a/extensions/qa-lab/src/codex-plugin-fixture.ts b/extensions/qa-lab/src/codex-plugin.fixture.ts similarity index 99% rename from extensions/qa-lab/src/codex-plugin-fixture.ts rename to extensions/qa-lab/src/codex-plugin.fixture.ts index a286f5bcf4c..f6e072f6550 100644 --- a/extensions/qa-lab/src/codex-plugin-fixture.ts +++ b/extensions/qa-lab/src/codex-plugin.fixture.ts @@ -1,6 +1,6 @@ import fs from "node:fs/promises"; import path from "node:path"; -import { resolveCodexAuthProfile, type QaAuthProfileSnapshot } from "./auth-profile-fixture.js"; +import { resolveCodexAuthProfile, type QaAuthProfileSnapshot } from "./auth-profile.fixture.js"; export const CODEX_PLUGIN_CURRENT_VERSION = "2026.5.20"; export const CODEX_PLUGIN_HEAD_VERSION = "head"; diff --git a/qa/scenarios/runtime/auth-profile-codex-mixed-profiles.md b/qa/scenarios/runtime/auth-profile-codex-mixed-profiles.md index fb160a0be66..3adebe2cddd 100644 --- a/qa/scenarios/runtime/auth-profile-codex-mixed-profiles.md +++ b/qa/scenarios/runtime/auth-profile-codex-mixed-profiles.md @@ -18,7 +18,7 @@ successCriteria: docsRefs: - docs/cli/doctor.md codeRefs: - - extensions/qa-lab/src/auth-profile-fixture.ts + - extensions/qa-lab/src/auth-profile.fixture.ts - extensions/qa-lab/src/codex-plugin-lifecycle.test.ts execution: kind: flow @@ -34,7 +34,7 @@ steps: actions: - set: auth value: - expr: await qaImport("./auth-profile-fixture.js") + expr: await qaImport("./auth-profile.fixture.js") - set: tmpRoot value: expr: await fs.mkdtemp(path.join(env.gateway?.workspaceDir ?? "/tmp", "qa-codex-auth-")) diff --git a/qa/scenarios/runtime/auth-profile-doctor-migration-safety.md b/qa/scenarios/runtime/auth-profile-doctor-migration-safety.md index cf4f5ae83f0..78a2c56dbc9 100644 --- a/qa/scenarios/runtime/auth-profile-doctor-migration-safety.md +++ b/qa/scenarios/runtime/auth-profile-doctor-migration-safety.md @@ -19,8 +19,8 @@ successCriteria: docsRefs: - docs/cli/doctor.md codeRefs: - - extensions/qa-lab/src/auth-profile-fixture.ts - - extensions/qa-lab/src/codex-plugin-fixture.ts + - extensions/qa-lab/src/auth-profile.fixture.ts + - extensions/qa-lab/src/codex-plugin.fixture.ts - extensions/qa-lab/src/codex-plugin-lifecycle.test.ts execution: kind: flow @@ -39,10 +39,10 @@ steps: actions: - set: auth value: - expr: await qaImport("./auth-profile-fixture.js") + expr: await qaImport("./auth-profile.fixture.js") - set: plugin value: - expr: await qaImport("./codex-plugin-fixture.js") + expr: await qaImport("./codex-plugin.fixture.js") - forEach: items: ref: config.matrixCells diff --git a/qa/scenarios/runtime/codex-plugin-cold-install.md b/qa/scenarios/runtime/codex-plugin-cold-install.md index f4820c6b117..7b8b602b123 100644 --- a/qa/scenarios/runtime/codex-plugin-cold-install.md +++ b/qa/scenarios/runtime/codex-plugin-cold-install.md @@ -20,8 +20,8 @@ docsRefs: - docs/cli/plugins.md - docs/plugins/install-overrides.md codeRefs: - - extensions/qa-lab/src/codex-plugin-fixture.ts - - extensions/qa-lab/src/auth-profile-fixture.ts + - extensions/qa-lab/src/codex-plugin.fixture.ts + - extensions/qa-lab/src/auth-profile.fixture.ts - extensions/qa-lab/src/codex-plugin-lifecycle.test.ts execution: kind: flow @@ -36,10 +36,10 @@ steps: actions: - set: auth value: - expr: await qaImport("./auth-profile-fixture.js") + expr: await qaImport("./auth-profile.fixture.js") - set: plugin value: - expr: await qaImport("./codex-plugin-fixture.js") + expr: await qaImport("./codex-plugin.fixture.js") - set: tmpRoot value: expr: await fs.mkdtemp(path.join(env.gateway?.workspaceDir ?? "/tmp", "qa-codex-cold-")) diff --git a/qa/scenarios/runtime/codex-plugin-install-race.md b/qa/scenarios/runtime/codex-plugin-install-race.md index d8eaeda9cf0..8185bdc3a91 100644 --- a/qa/scenarios/runtime/codex-plugin-install-race.md +++ b/qa/scenarios/runtime/codex-plugin-install-race.md @@ -18,7 +18,7 @@ successCriteria: docsRefs: - docs/cli/plugins.md codeRefs: - - extensions/qa-lab/src/codex-plugin-fixture.ts + - extensions/qa-lab/src/codex-plugin.fixture.ts - extensions/qa-lab/src/codex-plugin-lifecycle.test.ts execution: kind: flow @@ -34,7 +34,7 @@ steps: actions: - set: plugin value: - expr: await qaImport("./codex-plugin-fixture.js") + expr: await qaImport("./codex-plugin.fixture.js") - set: gate value: expr: plugin.createCodexPluginInstallGate() diff --git a/qa/scenarios/runtime/codex-plugin-pinned-new.md b/qa/scenarios/runtime/codex-plugin-pinned-new.md index a9c162013c2..706b87b87b8 100644 --- a/qa/scenarios/runtime/codex-plugin-pinned-new.md +++ b/qa/scenarios/runtime/codex-plugin-pinned-new.md @@ -17,7 +17,7 @@ docsRefs: - docs/cli/plugins.md - docs/cli/update.md codeRefs: - - extensions/qa-lab/src/codex-plugin-fixture.ts + - extensions/qa-lab/src/codex-plugin.fixture.ts - extensions/qa-lab/src/codex-plugin-lifecycle.test.ts execution: kind: flow @@ -35,10 +35,10 @@ steps: actions: - set: auth value: - expr: await qaImport("./auth-profile-fixture.js") + expr: await qaImport("./auth-profile.fixture.js") - set: plugin value: - expr: await qaImport("./codex-plugin-fixture.js") + expr: await qaImport("./codex-plugin.fixture.js") - set: tmpRoot value: expr: await fs.mkdtemp(path.join(env.gateway?.workspaceDir ?? "/tmp", "qa-codex-new-")) diff --git a/qa/scenarios/runtime/codex-plugin-pinned-old.md b/qa/scenarios/runtime/codex-plugin-pinned-old.md index 261a9794efe..7c814e61a72 100644 --- a/qa/scenarios/runtime/codex-plugin-pinned-old.md +++ b/qa/scenarios/runtime/codex-plugin-pinned-old.md @@ -17,7 +17,7 @@ docsRefs: - docs/cli/plugins.md - docs/cli/update.md codeRefs: - - extensions/qa-lab/src/codex-plugin-fixture.ts + - extensions/qa-lab/src/codex-plugin.fixture.ts - extensions/qa-lab/src/codex-plugin-lifecycle.test.ts execution: kind: flow @@ -35,10 +35,10 @@ steps: actions: - set: auth value: - expr: await qaImport("./auth-profile-fixture.js") + expr: await qaImport("./auth-profile.fixture.js") - set: plugin value: - expr: await qaImport("./codex-plugin-fixture.js") + expr: await qaImport("./codex-plugin.fixture.js") - set: tmpRoot value: expr: await fs.mkdtemp(path.join(env.gateway?.workspaceDir ?? "/tmp", "qa-codex-old-"))