vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-09 10:50:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: reject agent-scoped model default writes

Browse Source
This commit is contained in:
Peter Steinberger
2026-05-02 04:19:01 +01:00
parent 9a814bcec2
commit ebe8f615e5
3 changed files with 40 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/cli/models-cli.test.ts
View File

@@ -5,6 +5,8 @@ import { registerModelsCli } from "./models-cli.js";
const mocks = vi.hoisted(() => ({
modelsStatusCommand: vi.fn().mockResolvedValue(undefined),
modelsSetCommand: vi.fn().mockResolvedValue(undefined),
modelsSetImageCommand: vi.fn().mockResolvedValue(undefined),
noopAsync: vi.fn(async () => undefined),
modelsAuthAddCommand: vi.fn().mockResolvedValue(undefined),
modelsAuthLoginCommand: vi.fn().mockResolvedValue(undefined),
@@ -17,6 +19,8 @@ const {
modelsAuthLoginCommand,
modelsAuthPasteTokenCommand,
modelsAuthSetupTokenCommand,
modelsSetCommand,
modelsSetImageCommand,
modelsStatusCommand,
} = mocks;
@@ -58,10 +62,10 @@ vi.mock("../commands/models/scan.js", () => ({
modelsScanCommand: mocks.noopAsync,
}));
vi.mock("../commands/models/set.js", () => ({
modelsSetCommand: mocks.noopAsync,
modelsSetCommand: mocks.modelsSetCommand,
}));
vi.mock("../commands/models/set-image.js", () => ({
modelsSetImageCommand: mocks.noopAsync,
modelsSetImageCommand: mocks.modelsSetImageCommand,
}));
describe("models cli", () => {
@@ -70,6 +74,8 @@ describe("models cli", () => {
modelsAuthLoginCommand.mockClear();
modelsAuthPasteTokenCommand.mockClear();
modelsAuthSetupTokenCommand.mockClear();
modelsSetCommand.mockClear();
modelsSetImageCommand.mockClear();
modelsStatusCommand.mockClear();
});
@@ -162,6 +168,23 @@ describe("models cli", () => {
expect(command).toHaveBeenCalledWith(expect.objectContaining(expected), expect.any(Object));
});
it.each([
{
label: "set",
args: ["models", "--agent", "poe", "set", "anthropic/claude-sonnet-4-6"],
command: modelsSetCommand,
},
{
label: "set-image",
args: ["models", "--agent", "poe", "set-image", "openai/gpt-image-1"],
command: modelsSetImageCommand,
},
])("rejects parent --agent for models $label", async ({ args, command }) => {
await expect(runModelsCommand(args)).rejects.toThrow("does not support `--agent`");
expect(command).not.toHaveBeenCalled();
});
it("shows help for models auth without error exit", async () => {
const program = new Command();
program.exitOverride();