fix(cli): fast-path bare channels help (#77659)

* fix(cli): fast-path bare channels help

* fix(cli): normalize channels add argv gating

* fix(cli): restore channel add completion flags
This commit is contained in:
Vincent Koc
2026-05-05 16:02:39 -07:00
committed by GitHub
parent 1e1903487f
commit fdddb413ef
16 changed files with 319 additions and 48 deletions

View File

@@ -1,15 +1,22 @@
import { Command } from "commander";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import { applyParentDefaultHelpAction } from "./parent-default-help.js";
import { applyParentDefaultHelpAction, isParentDefaultHelpAction } from "./parent-default-help.js";
describe("applyParentDefaultHelpAction (#73077)", () => {
let originalExitCode: NodeJS.Process["exitCode"];
let originalSuppressHelpBanner: string | undefined;
beforeEach(() => {
originalExitCode = process.exitCode;
originalSuppressHelpBanner = process.env.OPENCLAW_SUPPRESS_HELP_BANNER;
process.exitCode = undefined;
});
afterEach(() => {
process.exitCode = originalExitCode;
if (originalSuppressHelpBanner === undefined) {
delete process.env.OPENCLAW_SUPPRESS_HELP_BANNER;
} else {
process.env.OPENCLAW_SUPPRESS_HELP_BANNER = originalSuppressHelpBanner;
}
});
function buildParent(): Command {
@@ -24,10 +31,17 @@ describe("applyParentDefaultHelpAction (#73077)", () => {
it("invokes parent help and exits 0 when invoked without subcommand", async () => {
const parent = buildParent();
const helpSpy = vi.spyOn(parent, "outputHelp").mockImplementation(() => {});
const suppressHelpBannerValues: Array<string | undefined> = [];
const helpSpy = vi.spyOn(parent, "outputHelp").mockImplementation(() => {
suppressHelpBannerValues.push(process.env.OPENCLAW_SUPPRESS_HELP_BANNER);
});
expect(isParentDefaultHelpAction(parent)).toBe(false);
applyParentDefaultHelpAction(parent);
expect(isParentDefaultHelpAction(parent)).toBe(true);
await parent.parent!.parseAsync(["node", "test", "parent"]);
expect(helpSpy).toHaveBeenCalledTimes(1);
expect(suppressHelpBannerValues).toEqual(["1"]);
expect(process.env.OPENCLAW_SUPPRESS_HELP_BANNER).toBeUndefined();
expect(process.exitCode).toBe(0);
});