5 Commits

Author	SHA1	Message	Date
StingNing	944abe0a6c	fix(security): recognize localized Windows SYSTEM account in ACL audit (#29698) ... * fix(security): recognize localized Windows SYSTEM account in ACL audit On non-English Windows (e.g. French "AUTORITE NT\Système"), the security audit falsely reports fs.config.perms_writable because the localized SYSTEM account name is not recognized as trusted. Changes: - Add common localized SYSTEM principal names (French, German, Spanish, Portuguese) to TRUSTED_BASE - Add diacritics-stripping fallback in classifyPrincipal for unhandled locales - Use well-known SID *S-1-5-18 in icacls reset commands instead of hardcoded "SYSTEM" string for locale independence Fixes #29681 * style: format windows acl files --------- Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>	2026-03-02 08:38:56 -06:00
Peter Steinberger	bd4f670544	refactor: simplify windows ACL parsing and expand coverage	2026-02-22 10:43:03 +01:00
SK Akram	85a3c0c818	fix: use SID-based ACL classification for non-English Windows	2026-02-22 10:37:34 +01:00
Peter Steinberger	d6cde28c8e	fix: stabilize windows acl tests and command auth registry (#9335) (thanks @M00N7682)	2026-02-05 00:38:35 -08:00
M00N7682	f26cc60872	Tests: add test coverage for security/windows-acl.ts ... Adds comprehensive unit tests for Windows ACL inspection utilities: - resolveWindowsUserPrincipal: username resolution with fallback - parseIcaclsOutput: icacls output parsing - summarizeWindowsAcl: ACL entry classification (trusted/world/group) - inspectWindowsAcl: async ACL inspection with mocked exec - formatWindowsAclSummary: summary string formatting - formatIcaclsResetCommand: reset command string generation - createIcaclsResetCommand: structured reset command generation All 26 tests passing. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>	2026-02-05 00:35:29 -08:00