Peter Steinberger
6afdf10266
fix: honor exec approval security from approvals ( #60310 )
2026-04-04 16:50:25 +09:00
jianxing zhang
302c6e30bb
fix: resolve type errors where workdir (string | undefined) flows to string-only params
...
After the node early-return, narrow workdir back to string via
resolvedWorkdir for gateway/sandbox paths. Update
buildExecApprovalPendingToolResult and buildApprovalPendingMessage
to accept string | undefined for cwd since node execution may omit it.
2026-04-03 02:04:26 +09:00
Gustavo Madeira Santana
ba735d0158
Exec approvals: unify effective policy reporting and actions ( #59283 )
...
Merged via squash.
Prepared head SHA: d579b97a935599352+gumadeiras@users.noreply.github.com >
Co-authored-by: gumadeiras <5599352+gumadeiras@users.noreply.github.com >
Reviewed-by: @gumadeiras
2026-04-01 22:02:39 -04:00
Vincent Koc
2d53ffdec1
fix(exec): resolve remote approval regressions ( #58792 )
...
* fix(exec): restore remote approval policy defaults
* fix(exec): handle headless cron approval conflicts
* fix(exec): make allow-always durable
* fix(exec): persist exact-command shell trust
* fix(doctor): match host exec fallback
* fix(exec): preserve blocked and inline approval state
* Doctor: surface allow-always ask bypass
* Doctor: match effective exec policy
* Exec: match node durable command text
* Exec: tighten durable approval security
* Exec: restore owner approver fallback
* Config: refresh Slack approval metadata
---------
Co-authored-by: scoootscooob <zhentongfan@gmail.com >
2026-04-01 02:07:20 -07:00
Josh Avant
5e4a64848f
fix(exec): harden async approval followup delivery in webchat-only sessions ( #57359 )
...
* fix(exec): harden approval followup delivery fallback
* refactor(delivery): share best-effort followup routing helpers
* test(subagents): cover webchat-only completion announce delivery
* docs(exec): clarify async followup delivery behavior
* fix(exec): harden delivery downgrade logging
* test(gateway): cover multi-channel best-effort fallback
* fix(exec): preserve webchat origin on session-only followups
* fix(subagents): keep internal announces channel-less
2026-03-29 20:54:13 -05:00
Peter Steinberger
6720bf5be0
refactor: share exec host approval helpers
2026-03-14 02:40:28 +00:00
Peter Steinberger
565dc0d17b
refactor: share exec approval registration context
2026-03-13 18:38:12 +00:00
Peter Steinberger
173132165d
fix(exec): honor exec-approvals ask=off for gateway/node runs
...
Landed from contributor PR #26789 by @pandego.
Co-authored-by: Miguel Miranda Dias <7780875+pandego@users.noreply.github.com >
2026-03-08 00:29:34 +00:00
Peter Steinberger
3c71e2bd48
refactor(core): extract shared dedup helpers
2026-03-07 10:41:05 +00:00
Peter Steinberger
9617ac9dd5
refactor: dedupe agent and reply runtimes
2026-03-02 19:57:33 +00:00
