Commit Graph

17588 Commits

Author SHA1 Message Date
Vincent Koc
240b143bde test(telegram): cover sender-only groupAllowFrom normalization 2026-03-07 16:34:42 -08:00
Vincent Koc
13ed6afe60 telegram: restore sender-only allowFrom validation 2026-03-07 16:34:21 -08:00
Peter Steinberger
173132165d fix(exec): honor exec-approvals ask=off for gateway/node runs
Landed from contributor PR #26789 by @pandego.

Co-authored-by: Miguel Miranda Dias <7780875+pandego@users.noreply.github.com>
2026-03-08 00:29:34 +00:00
Peter Steinberger
79e3d1f956 fix: retry git lock in committer 2026-03-08 00:28:37 +00:00
Josh Avant
25252ab5ab gateway: harden shared auth resolution across systemd, discord, and node host 2026-03-07 18:28:32 -06:00
Martin-Max
a7f6e0a921 fix(telegram): support negative IDs in groupAllowFrom (#36753) (#37134)
* fix(telegram): support negative IDs in groupAllowFrom for group/channel whitelist (#36753)

When configuring Telegram group restrictions with groupAllowFrom,
negative group/channel IDs (e.g., -1001234567890) are rejected with
'authorization requires numeric Telegram sender IDs only' error,
even though the field name suggests it should accept group IDs.

Root cause:
- normalizeAllowFrom() uses regex /^\d+$/ to validate IDs
- Telegram group/channel IDs are negative integers
- Regex only matches positive integers, rejecting all group IDs

Impact:
- Users cannot whitelist specific groups using groupAllowFrom
- Workaround requires groupPolicy: "open" (security risk)
- Field name is misleading (suggests group IDs, but only accepts user IDs)

Fix:
- Change regex from /^\d+$/ to /^-?\d+$/ (support optional minus sign)
- Apply to both invalidEntries filter and ids filter
- Add comment explaining negative ID support for groups/channels

Testing:
- Positive user IDs (745123456) →  still work
- Negative group IDs (-1001234567890) →  now accepted
- Invalid entries (@username) → ⚠️  still warned

Fixes #36753

* test(telegram): add signed ID runtime regression

---------

Co-authored-by: Martin Qiu <qiuyuemartin@gmail.com>
Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
2026-03-07 19:27:25 -05:00
Vincent Koc
73e510cdf4 Gateway UI: allowlist device key fixtures 2026-03-07 16:27:00 -08:00
Vincent Koc
27b6b0c119 Gateway Secrets: allowlist unresolved secret ref label 2026-03-07 16:27:00 -08:00
Vincent Koc
a7c605ec4a Gateway Credentials: allowlist precedence fixtures 2026-03-07 16:27:00 -08:00
Vincent Koc
ace64831e0 Gateway Credentials: allowlist password fixtures 2026-03-07 16:27:00 -08:00
Vincent Koc
889a60e122 Gateway Auth: allowlist bootstrap password references 2026-03-07 16:27:00 -08:00
Vincent Koc
475b0cb49a Docker Setup: allowlist dotenv token fixtures 2026-03-07 16:27:00 -08:00
Vincent Koc
d83f2c145a Zalo User: use scoped plugin SDK imports 2026-03-07 16:27:00 -08:00
Vincent Koc
5b0fa341fb Zalo: use scoped plugin SDK imports 2026-03-07 16:27:00 -08:00
Vincent Koc
b46ac250d1 WhatsApp: use scoped plugin SDK imports 2026-03-07 16:27:00 -08:00
Vincent Koc
e9cf3506fd Telegram: use scoped plugin SDK imports 2026-03-07 16:27:00 -08:00
Vincent Koc
d899990b44 Slack: use scoped plugin SDK imports 2026-03-07 16:27:00 -08:00
Vincent Koc
4bcef8631c Signal: use scoped plugin SDK imports 2026-03-07 16:27:00 -08:00
Vincent Koc
c7c5c0edaa Nextcloud Talk: use scoped plugin SDK imports 2026-03-07 16:26:59 -08:00
Vincent Koc
6035677545 Teams: use scoped plugin SDK allowlist imports 2026-03-07 16:26:59 -08:00
Vincent Koc
6b2adf663e Teams: use scoped plugin SDK channel imports 2026-03-07 16:26:59 -08:00
Vincent Koc
4cc619f06c Mattermost: use scoped plugin SDK imports 2026-03-07 16:26:59 -08:00
Vincent Koc
4b0d55dadf Matrix: use scoped plugin SDK resolve-target imports 2026-03-07 16:26:59 -08:00
Vincent Koc
4b02a4eacf Matrix: use scoped plugin SDK channel imports 2026-03-07 16:26:59 -08:00
Vincent Koc
43fd45f038 LINE: use scoped plugin SDK imports 2026-03-07 16:26:59 -08:00
Vincent Koc
7980dc59e3 IRC: use scoped plugin SDK imports 2026-03-07 16:26:59 -08:00
Vincent Koc
4cd81b0c7b iMessage: use scoped plugin SDK imports 2026-03-07 16:26:59 -08:00
Vincent Koc
566f30828d Google Chat: use scoped plugin SDK imports 2026-03-07 16:26:59 -08:00
Vincent Koc
1b034f08e0 Feishu: scope plugin SDK directory imports 2026-03-07 16:26:59 -08:00
Vincent Koc
2a5158295e Feishu: scope plugin SDK channel imports 2026-03-07 16:26:59 -08:00
Vincent Koc
e47b63acaa Discord: use scoped plugin SDK imports 2026-03-07 16:26:59 -08:00
Vincent Koc
8f40b132f9 BlueBubbles: use scoped plugin SDK imports 2026-03-07 16:26:59 -08:00
Peter Steinberger
9856d8432d chore(scripts): remove changelog fragment workflow helpers 2026-03-08 00:24:49 +00:00
Peter Steinberger
efdff9c738 fix(scripts): enforce changelog.md and post clickable SHA links 2026-03-08 00:23:45 +00:00
Peter Steinberger
eed403dc74 refactor(agents): unify spawned metadata and extract attachments service 2026-03-08 00:23:45 +00:00
Peter Steinberger
61000b8e4d fix(acp): block sandboxed slash spawns 2026-03-08 00:23:07 +00:00
Peter Steinberger
bda035768f fix(plugins): fall back to src plugin-sdk aliases 2026-03-08 00:18:45 +00:00
Peter Steinberger
4e07bdbdfd fix(cron): restore isolated delivery defaults 2026-03-08 00:18:45 +00:00
Peter Steinberger
8a469a12b2 test(exec): dedupe wrapper boundary regressions 2026-03-08 00:12:08 +00:00
Peter Steinberger
5f50823abf refactor(exec): share wrapper depth classification 2026-03-08 00:12:08 +00:00
Vincent Koc
168c65aa26 Allowlists: type test runtime mocks 2026-03-07 16:09:57 -08:00
Vincent Koc
3b1be1a08c Plugin SDK: align allowFrom helper test input 2026-03-07 16:08:39 -08:00
Vincent Koc
d15a3d3454 Telegram: coerce route allowlist warning flag 2026-03-07 16:08:38 -08:00
Vincent Koc
9d3469c914 Nextcloud Talk: coerce route allowlist warning flag 2026-03-07 16:08:17 -08:00
Vincent Koc
a4ffebbef4 Mattermost: default unknown media kind 2026-03-07 16:07:41 -08:00
Vincent Koc
7c5d6c3dc9 Matrix: default missing media kind to unknown 2026-03-07 16:07:41 -08:00
Vincent Koc
3800f6700a Feishu: narrow directory entry types 2026-03-07 16:07:41 -08:00
Peter Steinberger
990fc36cbd refactor: share sampled entry summary formatting 2026-03-08 00:05:24 +00:00
Peter Steinberger
cc03c097c5 refactor: share provider group-policy warning collectors 2026-03-08 00:05:24 +00:00
Peter Steinberger
566a821e5d refactor: share missing-sender matched allowlist evaluation 2026-03-08 00:05:24 +00:00