Commit Graph

2265 Commits

Author SHA1 Message Date
Josh Lehman
6bd480ea1f fix: honor explicit auth profile selection (#62744)
* Auth: fix native model profile selection

Fix native `/model ...@profile` targeting so profile selections persist onto the intended session, and preserve explicit session auth-profile overrides even when stored auth order prefers another profile. Update the reply/session regressions to use placeholder example.test profile ids.

Regeneration-Prompt: |
  Native `/model ...@profile` commands in chat were acknowledging the requested auth profile but later runs still used another account. Fix the target-session handling so native slash commands mutate the real chat session rather than a slash-session surrogate, and keep explicit session auth-profile overrides from being cleared just because stored provider order prefers another profile. Update the tests to cover the target-session path and the override-preservation behavior, and use placeholder profile ids instead of real email addresses in test fixtures.

* Auth: honor explicit user-locked profiles in runner

Allow an explicit user-selected auth profile to run even when per-agent auth-state order excludes it. Keep auth-state order for automatic selection and failover, and add an embedded runner regression that seeds stored order with one profile while verifying a different user-locked profile still executes.

Regeneration-Prompt: |
  The remaining bug after fixing native `/model ...@profile` persistence was in the embedded runner itself. A user could explicitly select a valid auth profile for a provider, but the run still failed if per-agent auth-state order did not include that profile. Preserve the intended semantics by validating user-locked profiles directly for provider match and credential eligibility, then using them without requiring membership in resolved auto-order. Add a regression in the embedded auth-profile rotation suite where stored order only includes one OpenAI profile but a different user-locked profile is chosen and must still be used.

* Changelog: note explicit auth profile selection fix

Add the required Unreleased changelog line for the explicit auth-profile selection and runner honor fix in this PR.

Regeneration-Prompt: |
  The PR needed a mandatory CHANGELOG.md entry under Unreleased/Fixes. Add a concise user-facing line describing that native `/model ...@profile` selections now persist on the target session and explicit user-locked OpenAI Codex auth profiles are honored even when per-agent auth order excludes them, and include the PR number plus thanks attribution for the PR author.
2026-04-07 16:12:25 -07:00
Peter Steinberger
669b352d36 refactor: dedupe auto-reply trimmed readers 2026-04-08 00:09:42 +01:00
Peter Steinberger
88ac6f1194 refactor: dedupe remaining lowercase helpers 2026-04-07 22:57:52 +01:00
Peter Steinberger
5fb6aeaf86 fix: preserve fallback error details 2026-04-07 22:07:12 +01:00
Gustavo Madeira Santana
d78512b09d Refactor: centralize native approval lifecycle assembly (#62135)
Merged via squash.

Prepared head SHA: b7c20a7398
Co-authored-by: gumadeiras <5599352+gumadeiras@users.noreply.github.com>
Co-authored-by: gumadeiras <5599352+gumadeiras@users.noreply.github.com>
Reviewed-by: @gumadeiras
2026-04-07 14:40:26 -04:00
pgondhi987
df881d5c18 fix(allowlist): gate write commands behind owner check before channel resolution [AI] (#62383)
* fix: address issue

* docs(changelog): add allowlist owner gate entry

---------

Co-authored-by: Devin Robison <drobison@nvidia.com>
2026-04-07 11:01:15 -06:00
Peter Steinberger
b2dc25cd12 fix: repair ci type narrowing 2026-04-07 17:51:05 +01:00
Peter Steinberger
cebfa70277 refactor: dedupe auto-reply lowercase helpers 2026-04-07 17:50:37 +01:00
Peter Steinberger
6a6a279fda perf(auto-reply): trim duplicate heavy coverage 2026-04-07 16:52:08 +01:00
Peter Steinberger
eb29782416 fix(discord): stabilize DM ACP binding identity 2026-04-07 16:16:06 +01:00
Peter Steinberger
a3d5630232 test: stabilize scoped runners and qa ports 2026-04-07 15:28:46 +01:00
Peter Steinberger
1f48ee8f9c refactor: dedupe remaining lowercase helpers 2026-04-07 15:12:32 +01:00
Peter Steinberger
9314bb7180 refactor: dedupe extension lowercase helpers 2026-04-07 15:12:32 +01:00
Peter Steinberger
948d139399 refactor: dedupe lowercase helper readers 2026-04-07 15:12:32 +01:00
Peter Steinberger
eba04199f8 refactor: dedupe core lowercase helpers 2026-04-07 15:12:32 +01:00
Peter Steinberger
8df1dbb8c7 Auto-reply: preserve compacted transcript subpaths 2026-04-07 14:40:28 +01:00
Peter Steinberger
47563305a2 Tests: isolate full-suite state leaks 2026-04-07 14:39:28 +01:00
Peter Steinberger
40bdf60ad6 Tests: isolate reply task registry state 2026-04-07 20:53:17 +08:00
Peter Steinberger
16fad4d7d6 Tests: align reply state and plugin-sdk surface 2026-04-07 20:00:14 +08:00
Peter Steinberger
c084630f9e test(auto-reply): move mixed reasoning coverage to directive seam 2026-04-07 12:56:17 +01:00
Peter Steinberger
9d358d557d perf(auto-reply): drop duplicate heavy runtime tests 2026-04-07 12:56:17 +01:00
Peter Steinberger
af8712fff1 test: fix auto-reply dispatch ci drift 2026-04-07 12:48:05 +01:00
Peter Steinberger
c83db77629 Auto-reply: fix reset test gate 2026-04-07 12:41:11 +01:00
Peter Steinberger
87e0353b06 test(auto-reply): trim reply utility harnesses 2026-04-07 12:35:08 +01:00
Peter Steinberger
5a652303b5 test(auto-reply): isolate dispatch runtime mocks 2026-04-07 12:35:08 +01:00
Peter Steinberger
353678ec05 refactor: dedupe auto-reply lowercase readers 2026-04-07 12:18:22 +01:00
Peter Steinberger
3a2e347dc7 refactor: dedupe auto-reply lowercase parsers 2026-04-07 12:18:22 +01:00
Peter Steinberger
fbf7859f6d test(auto-reply): isolate fallback selection coverage 2026-04-07 12:17:03 +01:00
Peter Steinberger
43e6c923de perf(auto-reply): extract followup delivery seam 2026-04-07 12:17:02 +01:00
Peter Steinberger
ce18c3e9e7 test: speed up auto-reply registry tests 2026-04-07 11:35:59 +01:00
Bob
f6124f3e17 ACP: harden Discord recovery and reset flow (#62132)
* ACP: harden Discord recovery and reset flow

* CI: harden bundled vitest excludes

* ACP: fix Claude launch and reset recovery

* Discord: use follow-up replies after slash defer

* ACP: route bound resets through gateway service

* ACP: unify bound reset authority

* ACPX: update OpenClaw branch to 0.5.2

* ACP: fix rebuilt branch replay fallout

* ACP: fix CI regressions after ACPX 0.5.2 update

---------

Co-authored-by: Onur <2453968+osolmaz@users.noreply.github.com>
2026-04-07 12:23:50 +02:00
Peter Steinberger
6bd6f4d27c refactor: dedupe shared lowercase helpers 2026-04-07 11:18:18 +01:00
Peter Steinberger
fbdb20ffd3 refactor: dedupe reply lowercase helpers 2026-04-07 11:18:18 +01:00
Peter Steinberger
1e5f5fa319 perf(auto-reply): trim plugin install and directive tests 2026-04-07 11:06:23 +01:00
Peter Steinberger
a5efc9a6c9 refactor: dedupe acp reply lowercase helpers 2026-04-07 10:37:39 +01:00
Peter Steinberger
74ea9de6f2 refactor: dedupe reply lowercase helpers 2026-04-07 10:37:39 +01:00
Peter Steinberger
434d56a948 refactor: dedupe lowercase helper readers 2026-04-07 10:37:39 +01:00
Peter Steinberger
f54a57b80a refactor: dedupe lowercase string helpers 2026-04-07 10:37:39 +01:00
Peter Steinberger
f1bdfca1ed refactor: dedupe reply gateway helpers 2026-04-07 10:37:39 +01:00
Peter Steinberger
85c75f6573 refactor: dedupe auto-reply string helpers 2026-04-07 09:44:53 +01:00
Peter Steinberger
649de6d156 refactor: dedupe provider and channel string helpers 2026-04-07 09:44:53 +01:00
Peter Steinberger
9d8d1dd4c5 refactor: dedupe shared string aliases 2026-04-07 09:44:53 +01:00
Peter Steinberger
7087845f58 refactor: dedupe trim reader aliases 2026-04-07 09:44:53 +01:00
Peter Steinberger
b3e6822ef8 refactor: dedupe helper trim readers 2026-04-07 08:40:34 +01:00
Peter Steinberger
dfec7d7f80 refactor: dedupe session helper readers 2026-04-07 07:36:11 +01:00
Peter Steinberger
1b2f640c5a refactor: dedupe helper string normalization 2026-04-07 07:36:11 +01:00
Peter Steinberger
576fb46e28 fix: clean rebase conflict import 2026-04-07 06:42:34 +01:00
Peter Steinberger
8822f779d9 fix: restore ci after trim reader dedupe 2026-04-07 06:42:34 +01:00
Peter Steinberger
575c486ef4 refactor: dedupe group and acp readers 2026-04-07 06:42:33 +01:00
Peter Steinberger
b514d61000 refactor: dedupe reply execution readers 2026-04-07 06:42:33 +01:00