Commit Graph

14 Commits

Author SHA1 Message Date
ToToKr
7e702bb43d fix(agents): suppress Write/Edit failed warning on response-timeout false-failure (#55424) (#86855)
* fix(agents): suppress Write/Edit failed warning on response-timeout false-failure (#55424)

Reporter sees '⚠️ Write failed' / '⚠️ Edit failed' warnings on Feishu (and other channels) even though the file was 100% saved successfully (8 of 8 verified writes succeeded; warning shown for all 8). Source path: tool-mutation records lastToolError.timedOut=true with a fileTarget when a write/edit tool ack reply times out after the disk mutation has already completed, then resolveToolErrorWarningPolicy goes through the default mutating-tool branch and emits the misleading failure summary.

Add a narrow gate inside resolveToolErrorWarningPolicy that suppresses the warning only when both lastToolError.timedOut is true AND lastToolError.fileTarget is defined. fileTarget is set by tool-mutation.ts only for the write/edit family (FILE_MUTATING_TOOL_NAMES), so this branch never matches exec/message/cron/gateway mutating-tool timeouts where the disk-write idempotency reasoning does not apply. Real file failures (no timeout) and timeouts without recorded fileTarget keep their visible warnings.

* fix: recover completed write timeouts safely

* fix: bound write timeout recovery precheck

* fix: type write recovery precheck fallback

* test: complete write recovery result mock

* test: isolate e2e timeout fixture shims

* test: stabilize e2e timeout fixture path

---------

Co-authored-by: Peter Steinberger <steipete@gmail.com>
2026-05-27 09:03:58 +01:00
Peter Steinberger
cf399d65d8 test: harden e2e instance package fixture 2026-05-27 03:30:57 -04:00
Peter Steinberger
f327df866c test: stabilize main ci lanes 2026-05-27 08:07:13 +01:00
Peter Steinberger
e6937f9f01 test(e2e): harden shell helper env assertions 2026-05-27 07:57:27 +01:00
Peter Steinberger
b28f9e0df3 test(e2e): isolate shell helper env 2026-05-27 07:36:55 +01:00
Vincent Koc
d58f864e23 fix(e2e): bound HTTP readiness probes 2026-05-27 05:52:01 +02:00
Vincent Koc
d0cb7ba55b fix(e2e): bound package cli scenarios 2026-05-27 04:00:55 +02:00
Vincent Koc
b74984dd50 fix(e2e): bound logged onboard commands 2026-05-27 03:41:52 +02:00
Vincent Koc
3e701449ff fix(e2e): keep mac smoke commands bounded without timeout 2026-05-27 01:37:57 +02:00
Vincent Koc
0028c2f793 fix(e2e): require bounded helper timeouts 2026-05-27 01:18:48 +02:00
Vincent Koc
5c1ecda0ca fix(e2e): support plain timeout wrappers 2026-05-26 21:49:04 +02:00
Vincent Koc
ce61d224d8 fix(e2e): kill timed npm install process groups 2026-05-26 15:49:29 +02:00
Vincent Koc
a07dc3896b fix(e2e): time out package npm installs 2026-05-26 14:18:58 +02:00
Vincent Koc
4a1d772f3d fix(e2e): fail on invalid test state payloads 2026-05-26 09:15:06 +02:00