import fs from "node:fs"; import os from "node:os"; import path from "node:path"; import { afterEach, describe, expect, it } from "vitest"; import type { OpenClawConfig } from "./runtime-api.js"; import { resolveMatrixOutboundSessionRoute } from "./session-route.js"; const tempDirs = new Set(); const currentDmSessionKey = "agent:main:matrix:channel:!dm:example.org"; type MatrixChannelConfig = NonNullable["matrix"]>; const perRoomDmMatrixConfig = { dm: { sessionScope: "per-room", }, } satisfies MatrixChannelConfig; const defaultAccountPerRoomDmMatrixConfig = { defaultAccount: "ops", accounts: { ops: { dm: { sessionScope: "per-room", }, }, }, } satisfies MatrixChannelConfig; function createTempStore(entries: Record): string { const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), "matrix-session-route-")); tempDirs.add(tempDir); const storePath = path.join(tempDir, "sessions.json"); fs.writeFileSync(storePath, JSON.stringify(entries), "utf8"); return storePath; } function createMatrixRouteConfig( entries: Record, matrix: MatrixChannelConfig = perRoomDmMatrixConfig, ): OpenClawConfig { return { session: { store: createTempStore(entries), }, channels: { matrix, }, } satisfies OpenClawConfig; } function createStoredDirectDmSession( params: { from?: string; to?: string; accountId?: string | null; nativeChannelId?: string; nativeDirectUserId?: string; lastTo?: string; lastAccountId?: string; } = {}, ): Record { const accountId = params.accountId === null ? undefined : (params.accountId ?? "ops"); const to = params.to ?? "room:!dm:example.org"; const accountMetadata = accountId ? { accountId } : {}; const nativeMetadata = { ...(params.nativeChannelId ? { nativeChannelId: params.nativeChannelId } : {}), ...(params.nativeDirectUserId ? { nativeDirectUserId: params.nativeDirectUserId } : {}), }; return { sessionId: "sess-1", updatedAt: Date.now(), chatType: "direct", origin: { chatType: "direct", from: params.from ?? "matrix:@alice:example.org", to, ...nativeMetadata, ...accountMetadata, }, deliveryContext: { channel: "matrix", to, ...accountMetadata, }, ...(params.lastTo ? { lastTo: params.lastTo } : {}), ...(params.lastAccountId ? { lastAccountId: params.lastAccountId } : {}), }; } function createStoredChannelSession(): Record { return { sessionId: "sess-1", updatedAt: Date.now(), chatType: "channel", origin: { chatType: "channel", from: "matrix:channel:!ops:example.org", to: "room:!ops:example.org", nativeChannelId: "!ops:example.org", nativeDirectUserId: "@alice:example.org", accountId: "ops", }, deliveryContext: { channel: "matrix", to: "room:!ops:example.org", accountId: "ops", }, lastTo: "room:!ops:example.org", lastAccountId: "ops", }; } function resolveUserRoute(params: { cfg: OpenClawConfig; accountId?: string; target?: string }) { const target = params.target ?? "@alice:example.org"; return resolveMatrixOutboundSessionRoute({ cfg: params.cfg, agentId: "main", ...(params.accountId ? { accountId: params.accountId } : {}), currentSessionKey: currentDmSessionKey, target, resolvedTarget: { to: target, kind: "user", source: "normalized", }, }); } function resolveUserRouteForCurrentSession(params: { storedSession: Record; accountId?: string; target?: string; matrix?: MatrixChannelConfig; }) { return resolveUserRoute({ cfg: createMatrixRouteConfig( { [currentDmSessionKey]: params.storedSession, }, params.matrix ?? perRoomDmMatrixConfig, ), ...(params.accountId ? { accountId: params.accountId } : {}), ...(params.target ? { target: params.target } : {}), }); } function expectCurrentDmRoomRoute(route: ReturnType) { expect(route).toMatchObject({ sessionKey: currentDmSessionKey, baseSessionKey: currentDmSessionKey, peer: { kind: "channel", id: "!dm:example.org" }, chatType: "direct", from: "matrix:@alice:example.org", to: "room:!dm:example.org", }); } function expectFallbackUserRoute( route: ReturnType, params?: { userId?: string; }, ) { const userId = params?.userId ?? "@alice:example.org"; expect(route).toMatchObject({ sessionKey: "agent:main:main", baseSessionKey: "agent:main:main", peer: { kind: "direct", id: userId }, chatType: "direct", from: `matrix:${userId}`, to: `room:${userId}`, }); } afterEach(() => { for (const tempDir of tempDirs) { fs.rmSync(tempDir, { recursive: true, force: true }); } tempDirs.clear(); }); describe("resolveMatrixOutboundSessionRoute", () => { it("reuses the current DM room session for same-user sends when Matrix DMs are per-room", () => { const route = resolveUserRouteForCurrentSession({ storedSession: createStoredDirectDmSession(), accountId: "ops", }); expectCurrentDmRoomRoute(route); }); it("falls back to user-scoped routing when the current session is for another DM peer", () => { const route = resolveUserRouteForCurrentSession({ storedSession: createStoredDirectDmSession({ from: "matrix:@bob:example.org" }), accountId: "ops", }); expectFallbackUserRoute(route); }); it("falls back to user-scoped routing when the current session belongs to another Matrix account", () => { const route = resolveUserRouteForCurrentSession({ storedSession: createStoredDirectDmSession(), accountId: "support", }); expectFallbackUserRoute(route); }); it("reuses the canonical DM room after user-target outbound metadata overwrites latest to fields", () => { const route = resolveUserRouteForCurrentSession({ storedSession: createStoredDirectDmSession({ from: "matrix:@bob:example.org", to: "room:@bob:example.org", nativeChannelId: "!dm:example.org", nativeDirectUserId: "@alice:example.org", lastTo: "room:@bob:example.org", lastAccountId: "ops", }), accountId: "ops", }); expectCurrentDmRoomRoute(route); }); it("does not reuse the canonical DM room for a different Matrix user after latest metadata drift", () => { const route = resolveUserRouteForCurrentSession({ storedSession: createStoredDirectDmSession({ from: "matrix:@bob:example.org", to: "room:@bob:example.org", nativeChannelId: "!dm:example.org", nativeDirectUserId: "@alice:example.org", lastTo: "room:@bob:example.org", lastAccountId: "ops", }), accountId: "ops", target: "@bob:example.org", }); expectFallbackUserRoute(route, { userId: "@bob:example.org" }); }); it("does not reuse a room after the session metadata was overwritten by a non-DM Matrix send", () => { const route = resolveUserRouteForCurrentSession({ storedSession: createStoredChannelSession(), accountId: "ops", }); expectFallbackUserRoute(route); }); it("uses the effective default Matrix account when accountId is omitted", () => { const route = resolveUserRouteForCurrentSession({ storedSession: createStoredDirectDmSession(), matrix: defaultAccountPerRoomDmMatrixConfig, }); expectCurrentDmRoomRoute(route); }); it("reuses the current DM room when stored account metadata is missing", () => { const route = resolveUserRouteForCurrentSession({ storedSession: createStoredDirectDmSession({ accountId: null }), matrix: defaultAccountPerRoomDmMatrixConfig, }); expectCurrentDmRoomRoute(route); }); it("recovers channel thread routes from currentSessionKey and preserves Matrix event-id case", () => { const route = resolveMatrixOutboundSessionRoute({ cfg: {}, agentId: "main", target: "room:!Ops:Example.Org", currentSessionKey: "agent:main:matrix:channel:!ops:example.org:thread:$RootEvent:Example.Org", }); expect(route).toMatchObject({ sessionKey: "agent:main:matrix:channel:!ops:example.org:thread:$RootEvent:Example.Org", baseSessionKey: "agent:main:matrix:channel:!ops:example.org", threadId: "$RootEvent:Example.Org", }); }); it("resolves per-room DM metadata from the base key when currentSessionKey has a thread suffix", () => { const storedSession = createStoredDirectDmSession(); const route = resolveUserRoute({ cfg: createMatrixRouteConfig({ [currentDmSessionKey]: storedSession, }), accountId: "ops", target: "@alice:example.org", }); const threadedRoute = resolveMatrixOutboundSessionRoute({ cfg: createMatrixRouteConfig({ [route?.baseSessionKey ?? currentDmSessionKey]: storedSession, }), agentId: "main", accountId: "ops", target: "@alice:example.org", resolvedTarget: { to: "@alice:example.org", kind: "user", source: "normalized", }, currentSessionKey: `${route?.baseSessionKey}:thread:$DmRoot:Example.Org`, }); expect(threadedRoute).toMatchObject({ sessionKey: `${route?.baseSessionKey}:thread:$DmRoot:Example.Org`, baseSessionKey: route?.baseSessionKey, to: "room:!dm:example.org", threadId: "$DmRoot:Example.Org", }); }); it('does not recover currentSessionKey threads for shared dmScope "main" DMs', () => { const route = resolveMatrixOutboundSessionRoute({ cfg: {}, agentId: "main", target: "@alice:example.org", currentSessionKey: "agent:main:main:thread:$DmRoot:Example.Org", resolvedTarget: { to: "@alice:example.org", kind: "user", source: "normalized", }, }); expect(route).toMatchObject({ sessionKey: "agent:main:main", baseSessionKey: "agent:main:main", }); expect(route?.threadId).toBeUndefined(); }); });