import type { WebClient } from "@slack/web-api"; import { afterEach, beforeAll, beforeEach, describe, expect, it, vi } from "vitest"; import { installSlackBlockTestMocks } from "./blocks.test-helpers.js"; // --- Module mocks (must precede dynamic import) --- installSlackBlockTestMocks(); const fetchWithSsrFGuard = vi.fn( async (params: { url: string; init?: RequestInit }) => ({ response: await fetch(params.url, params.init), finalUrl: params.url, release: async () => {}, }) as const, ); vi.mock("../../../src/infra/net/fetch-guard.js", () => ({ fetchWithSsrFGuard: (...args: unknown[]) => fetchWithSsrFGuard(...(args as [params: { url: string; init?: RequestInit }])), withTrustedEnvProxyGuardedFetchMode: (params: Record) => ({ ...params, mode: "trusted_env_proxy", }), })); vi.mock("openclaw/plugin-sdk/web-media", () => ({ loadWebMedia: vi.fn(async () => ({ buffer: Buffer.from("fake-image"), contentType: "image/png", kind: "image", fileName: "screenshot.png", })), })); let sendMessageSlack: typeof import("./send.js").sendMessageSlack; let clearSlackDmChannelCache: typeof import("./send.js").clearSlackDmChannelCache; type UploadTestClient = WebClient & { conversations: { open: ReturnType }; chat: { postMessage: ReturnType }; files: { getUploadURLExternal: ReturnType; completeUploadExternal: ReturnType; }; }; function createUploadTestClient(): UploadTestClient { return { conversations: { open: vi.fn(async () => ({ channel: { id: "D99RESOLVED" } })), }, chat: { postMessage: vi.fn(async () => ({ ts: "171234.567" })), }, files: { getUploadURLExternal: vi.fn(async () => ({ ok: true, upload_url: "https://uploads.slack.test/upload", file_id: "F001", })), completeUploadExternal: vi.fn(async () => ({ ok: true })), }, } as unknown as UploadTestClient; } describe("sendMessageSlack file upload with user IDs", () => { const originalFetch = globalThis.fetch; beforeAll(async () => { vi.resetModules(); ({ sendMessageSlack, clearSlackDmChannelCache } = await import("./send.js")); }); beforeEach(() => { globalThis.fetch = vi.fn( async () => new Response("ok", { status: 200 }), ) as unknown as typeof fetch; fetchWithSsrFGuard.mockClear(); clearSlackDmChannelCache(); }); afterEach(() => { globalThis.fetch = originalFetch; vi.restoreAllMocks(); }); it("resolves bare user ID to DM channel before completing upload", async () => { const client = createUploadTestClient(); // Bare user ID — parseSlackTarget classifies this as kind="channel" await sendMessageSlack("U2ZH3MFSR", "screenshot", { token: "xoxb-test", client, mediaUrl: "/tmp/screenshot.png", }); // Should call conversations.open to resolve user ID → DM channel expect(client.conversations.open).toHaveBeenCalledWith({ users: "U2ZH3MFSR", }); expect(client.files.completeUploadExternal).toHaveBeenCalledWith( expect.objectContaining({ channel_id: "D99RESOLVED", files: [expect.objectContaining({ id: "F001", title: "screenshot.png" })], }), ); }); it("resolves prefixed user ID to DM channel before completing upload", async () => { const client = createUploadTestClient(); await sendMessageSlack("user:UABC123", "image", { token: "xoxb-test", client, mediaUrl: "/tmp/photo.png", }); expect(client.conversations.open).toHaveBeenCalledWith({ users: "UABC123", }); expect(client.files.completeUploadExternal).toHaveBeenCalledWith( expect.objectContaining({ channel_id: "D99RESOLVED" }), ); }); it("caches DM channel resolution per account", async () => { const client = createUploadTestClient(); await sendMessageSlack("user:UABC123", "first", { token: "xoxb-test", client, }); await sendMessageSlack("user:UABC123", "second", { token: "xoxb-test", client, }); expect(client.conversations.open).toHaveBeenCalledTimes(1); expect(client.chat.postMessage).toHaveBeenCalledTimes(2); expect(client.chat.postMessage).toHaveBeenNthCalledWith( 2, expect.objectContaining({ channel: "D99RESOLVED", text: "second", }), ); }); it("scopes DM channel resolution cache by token identity", async () => { const client = createUploadTestClient(); await sendMessageSlack("user:UABC123", "first", { token: "xoxb-test-a", client, }); await sendMessageSlack("user:UABC123", "second", { token: "xoxb-test-b", client, }); expect(client.conversations.open).toHaveBeenCalledTimes(2); }); it("sends file directly to channel without conversations.open", async () => { const client = createUploadTestClient(); await sendMessageSlack("channel:C123CHAN", "chart", { token: "xoxb-test", client, mediaUrl: "/tmp/chart.png", }); expect(client.conversations.open).not.toHaveBeenCalled(); expect(client.files.completeUploadExternal).toHaveBeenCalledWith( expect.objectContaining({ channel_id: "C123CHAN" }), ); }); it("resolves mention-style user ID before file upload", async () => { const client = createUploadTestClient(); await sendMessageSlack("<@U777TEST>", "report", { token: "xoxb-test", client, mediaUrl: "/tmp/report.png", }); expect(client.conversations.open).toHaveBeenCalledWith({ users: "U777TEST", }); expect(client.files.completeUploadExternal).toHaveBeenCalledWith( expect.objectContaining({ channel_id: "D99RESOLVED" }), ); }); it("uploads bytes to the presigned URL and completes with thread+caption", async () => { const client = createUploadTestClient(); await sendMessageSlack("channel:C123CHAN", "caption", { token: "xoxb-test", client, mediaUrl: "/tmp/threaded.png", threadTs: "171.222", }); expect(client.files.getUploadURLExternal).toHaveBeenCalledWith({ filename: "screenshot.png", length: Buffer.from("fake-image").length, }); expect(globalThis.fetch).toHaveBeenCalledWith( "https://uploads.slack.test/upload", expect.objectContaining({ method: "POST", }), ); expect(fetchWithSsrFGuard).toHaveBeenCalledWith( expect.objectContaining({ url: "https://uploads.slack.test/upload", mode: "trusted_env_proxy", auditContext: "slack-upload-file", }), ); expect(client.files.completeUploadExternal).toHaveBeenCalledWith( expect.objectContaining({ channel_id: "C123CHAN", initial_comment: "caption", thread_ts: "171.222", }), ); }); it("uses explicit upload filename and title overrides when provided", async () => { const client = createUploadTestClient(); await sendMessageSlack("channel:C123CHAN", "caption", { token: "xoxb-test", client, mediaUrl: "/tmp/threaded.png", uploadFileName: "custom-name.bin", uploadTitle: "Custom Title", }); expect(client.files.getUploadURLExternal).toHaveBeenCalledWith({ filename: "custom-name.bin", length: Buffer.from("fake-image").length, }); expect(client.files.completeUploadExternal).toHaveBeenCalledWith( expect.objectContaining({ files: [expect.objectContaining({ id: "F001", title: "Custom Title" })], }), ); }); it("uses uploadFileName as the title fallback when uploadTitle is omitted", async () => { const client = createUploadTestClient(); await sendMessageSlack("channel:C123CHAN", "caption", { token: "xoxb-test", client, mediaUrl: "/tmp/threaded.png", uploadFileName: "custom-name.bin", }); expect(client.files.getUploadURLExternal).toHaveBeenCalledWith({ filename: "custom-name.bin", length: Buffer.from("fake-image").length, }); expect(client.files.completeUploadExternal).toHaveBeenCalledWith( expect.objectContaining({ files: [expect.objectContaining({ id: "F001", title: "custom-name.bin" })], }), ); }); });