// Node match tests cover node selection from names, ids, and address hints. import { describe, expect, it } from "vitest"; import { normalizeNodeKey, resolveNodeIdFromCandidates } from "./node-match.js"; describe("shared/node-match", () => { it("normalizes node keys by lowercasing and collapsing separators", () => { expect(normalizeNodeKey(" Mac Studio! ")).toBe("mac-studio"); expect(normalizeNodeKey("---PI__Node---")).toBe("pi-node"); expect(normalizeNodeKey("工作站 01")).toBe("工作站-01"); expect(normalizeNodeKey("Cafe\u0301 01")).toBe("café-01"); expect(normalizeNodeKey("किताब")).toBe("किताब"); expect(normalizeNodeKey("Mac ❤️ Studio")).toBe("mac-studio"); expect(normalizeNodeKey("Node 1️⃣")).toBe("node-1"); expect(normalizeNodeKey("❤️")).toBe(""); expect(normalizeNodeKey("###")).toBe(""); }); it("resolves unique matches and prefers a unique connected node", () => { expect( resolveNodeIdFromCandidates( [ { nodeId: "ios-old", displayName: "iPhone", connected: false }, { nodeId: "ios-live", displayName: "iPhone", connected: true }, ], "iphone", ), ).toBe("ios-live"); }); it("prefers the strongest match type before client heuristics", () => { expect( resolveNodeIdFromCandidates( [ { nodeId: "mac-studio", displayName: "Other Node", connected: false }, { nodeId: "mac-2", displayName: "Mac Studio", connected: true }, ], "mac-studio", ), ).toBe("mac-studio"); }); it("prefers a unique current OpenClaw client over a legacy clawdbot client", () => { expect( resolveNodeIdFromCandidates( [ { nodeId: "legacy-mac", displayName: "Peter’s Mac Studio", clientId: "clawdbot-macos", connected: false, }, { nodeId: "current-mac", displayName: "Peter’s Mac Studio", clientId: "openclaw-macos", connected: false, }, ], "Peter's Mac Studio", ), ).toBe("current-mac"); }); it("falls back to raw ambiguous matches when none of them are connected", () => { expect(() => resolveNodeIdFromCandidates( [ { nodeId: "ios-a", displayName: "iPhone", connected: false }, { nodeId: "ios-b", displayName: "iPhone", connected: false }, ], "iphone", ), ).toThrow(/ambiguous node: iphone.*node=ios-a.*node=ios-b/); }); it("throws clear unknown and ambiguous node errors", () => { expect(() => resolveNodeIdFromCandidates( [ { nodeId: "mac-123", displayName: "Mac Studio", remoteIp: "100.0.0.1" }, { nodeId: "pi-456" }, ], "nope", ), ).toThrow(/unknown node: nope.*known: Mac Studio, pi-456/); expect(() => resolveNodeIdFromCandidates( [ { nodeId: "ios-a", displayName: "iPhone", connected: true }, { nodeId: "ios-b", displayName: "iPhone", connected: true }, ], "iphone", ), ).toThrow(/ambiguous node: iphone.*node=ios-a.*node=ios-b/); expect(() => resolveNodeIdFromCandidates([], "")).toThrow(/node required/); }); it("prints client ids in ambiguous-node errors when available", () => { expect(() => resolveNodeIdFromCandidates( [ { nodeId: "legacy-mac", displayName: "Peter’s Mac Studio", clientId: "clawdbot-macos", connected: true, }, { nodeId: "other-mac", displayName: "Peter’s Mac Studio", clientId: "openclaw-macos", connected: true, }, { nodeId: "third-mac", displayName: "Peter’s Mac Studio", clientId: "openclaw-macos", connected: true, }, ], "Peter's Mac Studio", ), ).toThrow( /ambiguous node: Peter's Mac Studio.*node=other-mac.*client=openclaw-macos.*node=third-mac.*client=openclaw-macos/, ); }); it("lists remote ips in unknown-node errors when display names are missing", () => { expect(() => resolveNodeIdFromCandidates( [{ nodeId: "mac-123", remoteIp: "100.0.0.1" }, { nodeId: "pi-456" }], "nope", ), ).toThrow(/unknown node: nope.*known: 100.0.0.1, pi-456/); }); it("matches Unicode names without letting punctuation select them", () => { const nodes = [ { nodeId: "cn-desktop", displayName: "工作站" }, { nodeId: "cn-laptop", displayName: "笔记本" }, ]; expect(resolveNodeIdFromCandidates(nodes, "工作站")).toBe("cn-desktop"); expect(() => resolveNodeIdFromCandidates(nodes, "###")).toThrow(/unknown node: ###/); }); it("preserves combining marks that distinguish Unicode display names", () => { const nodes = [ { nodeId: "hi-short-i", displayName: "किताब" }, { nodeId: "hi-short-u", displayName: "कुताब" }, ]; expect(resolveNodeIdFromCandidates(nodes, "किताब")).toBe("hi-short-i"); expect(resolveNodeIdFromCandidates(nodes, "कुताब")).toBe("hi-short-u"); }); it("ignores emoji decoration marks during display-name matching", () => { const nodes = [ { nodeId: "heart", displayName: "Mac ❤️ Studio" }, { nodeId: "keycap", displayName: "Node 1️⃣" }, ]; expect(resolveNodeIdFromCandidates(nodes, "Mac Studio")).toBe("heart"); expect(resolveNodeIdFromCandidates(nodes, "Node 1")).toBe("keycap"); }); it("keeps compact display-name selectors below exact name matches", () => { const nodes = [ { nodeId: "mac-compact", displayName: "Mac Studio" }, { nodeId: "mac-exact", displayName: "MacStudio" }, { nodeId: "cafe-compact", displayName: "Cafe\u0301 01" }, { nodeId: "cafe-exact", displayName: "Cafe\u030101" }, ]; expect(resolveNodeIdFromCandidates(nodes, "MacStudio", true)).toBe("mac-exact"); expect(resolveNodeIdFromCandidates([nodes[0]!, nodes[2]!], "MacStudio", true)).toBe( "mac-compact", ); expect(resolveNodeIdFromCandidates([nodes[2]!, nodes[3]!], "Café01", true)).toBe("cafe-exact"); expect(resolveNodeIdFromCandidates([nodes[2]!], "Café01", true)).toBe("cafe-compact"); }); it("requires callers to opt in to compact display-name selectors", () => { const nodes = [{ nodeId: "mac-compact", displayName: "Mac Studio" }]; expect(() => resolveNodeIdFromCandidates(nodes, "MacStudio")).toThrow( /unknown node: MacStudio/, ); expect(resolveNodeIdFromCandidates(nodes, "MacStudio", true)).toBe("mac-compact"); }); });